Skip to contentSkip to conversation

w1: more debug level decrease.

DISCUSSION Andi Kleen 3 participants 3 messages Aug 12, 2005 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

Andi Kleen

author
#1 lore raw
Quoted 1 line · Greg KH

Here's a patch for 2.6.13-rc6 to keep people's syslogs a bit nicer.

But why is this thing running every 10 seconds at all in the first place? Looks to me like you're just hiding the symptoms, not fixing the bug that makes this code run on unsuspecting systems.

e.g. one way would be to only probe once and then never again.

-Andi

Quoted 28 lines

From: Evgeniy Polyakov <[email protected]>

Do not spam syslog each 10 seconds when there is nothing on the wire.

---
 drivers/w1/w1.c |    2 +-
 1 files changed, 1 insertion(+), 1 deletion(-)
drivers/w1/w1.c +1 -2
@@ -593,7 +593,7 @@
 		 * Return 0 - device(s) present, 1 - no devices present.
 		 */
 		if (w1_reset_bus(dev)) {
-			dev_info(&dev->dev, "No devices present on the wire.\n");
+			dev_dbg(&dev->dev, "No devices present on the wire.\n");
 			break;
 		}
 
-

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

#2 lore raw
Quoted 9 lines · Andi Kleen
Quoted 1 line · Greg KH

Here's a patch for 2.6.13-rc6 to keep people's syslogs a bit nicer.

But why is this thing running every 10 seconds at all in the first place? Looks to me like you're just hiding the symptoms, not fixing the bug that makes this code run on unsuspecting systems.

e.g. one way would be to only probe once and then never again.

Don't know, Evgeniy?

greg k-h

#3 lore raw
In reply to Andi Kleen
Quoted 9 lines · Andi Kleen
Quoted 1 line · Greg KH

Here's a patch for 2.6.13-rc6 to keep people's syslogs a bit nicer.

But why is this thing running every 10 seconds at all in the first place? Looks to me like you're just hiding the symptoms, not fixing the bug that makes this code run on unsuspecting systems.

e.g. one way would be to only probe once and then never again.

Hmmm, why do you think it is a bug? :)

This bus does not have any kind of notiication, so w1 core searches for devices on this buses and prints when something is found or not. Exactly because of this message people are unhappy.

Quoted 30 lines

-Andi

Quoted 28 lines

From: Evgeniy Polyakov <[email protected]>

Do not spam syslog each 10 seconds when there is nothing on the wire.

---
 drivers/w1/w1.c |    2 +-
 1 files changed, 1 insertion(+), 1 deletion(-)
drivers/w1/w1.c +1 -2
@@ -593,7 +593,7 @@
 		 * Return 0 - device(s) present, 1 - no devices present.
 		 */
 		if (w1_reset_bus(dev)) {
-			dev_info(&dev->dev, "No devices present on the wire.\n");
+			dev_dbg(&dev->dev, "No devices present on the wire.\n");
 			break;
 		}
 
-

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Signature · 1 line
	Evgeniy Polyakov