Skip to contentSkip to conversation

i386 virtualization patches, Set 3

PATCH In review [email protected] 5 participants 7 messages Aug 15, 2005 – Aug 16, 2005

lore
Share & tools
lore
#0 lore raw

cover i386 virtualization patches, Set 3

This round attempts to conclude all of the LDT related cleanup with some finally nice looking LDT code, fixes for the UML build, a bugfix for really rather nasty kprobes problems, and the basic framework for an LDT test suite. It is really rather unfortunate that this code is so difficult to test, even with DOSemu and Wine, there are still very nasty corner cases here - anyone want an iret to 16-bit stack test?.

I was going to attempt to clean up the math-emu code to make it use the nice new segment and descriptor table accessors, but it quickly became apparent that this would be a long, tedious, error prone process that would eventually result in the death of a large section of my brain. In addition, it is not very fun to test this on the actual hardware it is designed to run on (although I did manage to track down a 386 with detachable i387 coprocessor, the owner is not sure it still boots). Someday it would be nice to have an audit of this code; it appears to be riddled with bugs relating to segmentation, for example it assumes LDT segments on overrides, does not use the mm->context semaphore to protect LDT access, and generally looks scarily out of date in both function and appearance.

I also have a makeover for the pgtable.h code. Splitting operations that write hardware page tables into the sub-arch layer was very ugly, hopefully this is a much cleaner approach. There really must be a way for a paravirtualized hypervisor to hook the page table updates, and this appears to be the cleanest solution so far.

This patch set is based on 2.6.13-rc6 -mm1 broken out series. It applies and builds i386, x86_64, and um-i386 on 2.6.13-rc5. I've tested PAE and non-PAE SMP kernels and am working on an LDT test suite. Depends on the i386 cleanups, sub-arch movement, and LDT cleanups I've already sent out.

--
Zachary Amsden <[email protected]>
Whee! Actually deliver the signal.

#1 lore raw
Quoted 4 lines · On Mon, Aug 15, 2005 at 03:58:09PM -0700, [email protected] wrote:

I was going to attempt to clean up the math-emu code to make it use the nice new segment and descriptor table accessors, but it quickly became apparent that this would be a long, tedious, error prone process that would eventually result in the death of a large section of my brain.

Quoted 8 lines

In addition, it is not very fun to test this on the actual hardware it is designed to run on (although I did manage to track down a 386 with detachable i387 coprocessor, the owner is not sure it still boots). Someday it would be nice to have an audit of this code; it appears to be riddled with bugs relating to segmentation, for example it assumes LDT segments on overrides, does not use the mm->context semaphore to protect LDT access, and generally looks scarily out of date in both function and appearance.

Perhaps the best would be to just remove it. Near all 386s should be far beyond their MTBF by now. Mark it CONFIG_BROKEN and if nobody complains for one or two releases remove it completely.

The ugly verify_area 386 bugfix workaround code could go at the same time.

-Andi

#2 lore raw
Quoted 15 lines · Andi Kleen
Quoted 4 lines · On Mon, Aug 15, 2005 at 03:58:09PM -0700, [email protected] wrote:

I was going to attempt to clean up the math-emu code to make it use the nice new segment and descriptor table accessors, but it quickly became apparent that this would be a long, tedious, error prone process that would eventually result in the death of a large section of my brain.

Quoted 8 lines

In addition, it is not very fun to test this on the actual hardware it is designed to run on (although I did manage to track down a 386 with detachable i387 coprocessor, the owner is not sure it still boots). Someday it would be nice to have an audit of this code; it appears to be riddled with bugs relating to segmentation, for example it assumes LDT segments on overrides, does not use the mm->context semaphore to protect LDT access, and generally looks scarily out of date in both function and appearance.

Quoted 3 lines

Perhaps the best would be to just remove it. Near all 386s should be far beyond their MTBF by now. Mark it CONFIG_BROKEN and if nobody complains for one or two releases remove it completely.

you are forgetting about the embedded market, there 386 cpu (or things that look like 386 cpu's) are still available.

David Lang

Quoted 10 lines

The ugly verify_area 386 bugfix workaround code could go at the same time.

(quoted diff) +0 -2
-Andi
-

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Signature · 2 lines
There are two ways of constructing a software design. One way is to make it so simple that there are obviously no deficiencies. And the other way is to make it so complicated that there are no obvious deficiencies.
 -- C.A.R. Hoare
#3 lore raw
Quoted 2 lines

you are forgetting about the embedded market, there 386 cpu (or things that look like 386 cpu's) are still available.

They cannot use it much though because the code is obviously in so bad shape. Perhaps they have all FPUs ? Ok given LDT usage is rare, but still there are probably lots of other bugs in that unmaintained code too.

-Andi

#4 lore raw
In reply to [email protected]
Quoted 7 lines · [email protected] wrote:

This round attempts to conclude all of the LDT related cleanup with some finally nice looking LDT code, fixes for the UML build, a bugfix for really rather nasty kprobes problems, and the basic framework for an LDT test suite. It is really rather unfortunate that this code is so difficult to test, even with DOSemu and Wine, there are still very nasty corner cases here - anyone want an iret to 16-bit stack test?.

Quoted 12 lines

I was going to attempt to clean up the math-emu code to make it use the nice new segment and descriptor table accessors, but it quickly became apparent that this would be a long, tedious, error prone process that would eventually result in the death of a large section of my brain. In addition, it is not very fun to test this on the actual hardware it is designed to run on (although I did manage to track down a 386 with detachable i387 coprocessor, the owner is not sure it still boots). Someday it would be nice to have an audit of this code; it appears to be riddled with bugs relating to segmentation, for example it assumes LDT segments on overrides, does not use the mm->context semaphore to protect LDT access, and generally looks scarily out of date in both function and appearance.

If you really want to test the math emu code, you can hack check_x87 in head.S to always leave the fpu disabled. Then you can test it on any cpu, not just a 386.

--
Brian Gerst

#5 lore raw
Quoted 1 line · Brian Gerst

If you really want to test the math emu code, you can hack check_x87 in head.S to always leave the fpu disabled. Then you can test it on any cpu, not just a 386.

That is a good idea, and while a valid point, it actually still requires writing the code to actually test the FPU, specifically, using weird prefixes, LDT based segments, and other oddities that don't get generated from "normal" C code. I'm pretty sure the existing code works for the 99% cases or else it wouldn't have gotten there in the first place. But testing the corner cases here is even nastier than testing the LDT corner cases - you would basically need to write a lot of hand coded i387 assembler. Perhaps such a test might exist, but in all honesty, without a comprehensive test, it is simply far too easy to introduce a bug here, and far too likely it will either not be noticed until it has caused someone a possibly undetected numerical error, or I'm just wasting my time because noone is using this code anyways. Fortunately, the Hubble telescope has been upgraded to a 486 ;)

Zach

#6 lore raw
In reply to [email protected]
Quoted 5 lines · * [email protected] ([email protected]) wrote:

This patch set is based on 2.6.13-rc6 -mm1 broken out series. It applies and builds i386, x86_64, and um-i386 on 2.6.13-rc5. I've tested PAE and non-PAE SMP kernels and am working on an LDT test suite. Depends on the i386 cleanups, sub-arch movement, and LDT cleanups I've already sent out.

I put these in the virt-2.6 git tree, with the one minor wrprotect macro change I mentioned.

thanks,
-chris