Skip to contentSkip to conversation

Cleanups/debugging fixes in pcmcia/soc_common.c

PATCH New Pavel Machek 1 participant 1 message Aug 16, 2005 Pcmcia

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Cleanups/debugging fixes in pcmcia/soc_common.c

Hi!

This fixes debugging in soc_common.c (vprintk, not printk may be used at that point), makes "no cpufreq" hooks a little bit safer and fixes whitespace a tiny bit. Please apply,
Pavel

drivers/pcmcia/soc_common.c +4 -4
@@ -66,7 +67,7 @@ void soc_pcmcia_debug(struct soc_pcmcia_
 	if (pc_debug > lvl) {
 		printk(KERN_DEBUG "skt%u: %s: ", skt->nr, func);
 		va_start(args, fmt);
-		printk(fmt, args);
+		vprintk(fmt, args);
 		va_end(args);
 	}
 }
@@ -655,8 +656,8 @@ static void soc_pcmcia_cpufreq_unregiste
 }
 
 #else
-#define soc_pcmcia_cpufreq_register()
-#define soc_pcmcia_cpufreq_unregister()
+static int soc_pcmcia_cpufreq_register(void) { return 0; }
+static void soc_pcmcia_cpufreq_unregister(void) {}
 #endif
 
 int soc_common_drv_pcmcia_probe(struct device *dev, struct pcmcia_low_level *ops, int first, int nr)
@@ -738,7 +739,7 @@ int soc_common_drv_pcmcia_probe(struct d
 			goto out_err_5;
 		}
 
-		if ( list_empty(&soc_pcmcia_sockets) )
+		if (list_empty(&soc_pcmcia_sockets))
 			soc_pcmcia_cpufreq_register();
 
 		list_add(&skt->node, &soc_pcmcia_sockets);
Signature · 1 line
if you have sharp zaurus hardware you don't need... you know my address