Skip to contentSkip to conversation

configfs: export config_group_find_obj

PATCH In review David Teigland 2 participants 4 messages Aug 18, 2005 – Aug 19, 2005 2 messages not in the archive configfs

lore
Share & tools
lore

David Teigland

author
#0 lore raw

PATCH 1/1 configfs: export config_group_find_obj

In the dlm I use config_group_find_obj() which isn't exported.

Signed-off-by David Teigland <[email protected]>
fs/configfs/item.c +1 -0
diff -urpN a/fs/configfs/item.c b/fs/configfs/item.c
@@ -224,4 +224,5 @@ EXPORT_SYMBOL(config_item_init);
 EXPORT_SYMBOL(config_group_init);
 EXPORT_SYMBOL(config_item_get);
 EXPORT_SYMBOL(config_item_put);
+EXPORT_SYMBOL(config_group_find_obj);
#1 lore raw
Quoted 1 line · David Teigland

In the dlm I use config_group_find_obj() which isn't exported.

Did you notice the /* XXX Locking */? Let me go see how you use
it, if it is the best way, we'll need to revisit the function and be sure it's happy.

Joel

Quoted 17 lines
Signed-off-by David Teigland <[email protected]>

diff -urpN a/fs/configfs/item.c b/fs/configfs/item.c

fs/configfs/item.c +1 -1
@@ -224,4 +224,5 @@ EXPORT_SYMBOL(config_item_init);
 EXPORT_SYMBOL(config_group_init);
 EXPORT_SYMBOL(config_item_get);
 EXPORT_SYMBOL(config_item_put);
+EXPORT_SYMBOL(config_group_find_obj);
 
-

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Signature · 5 lines
"Time is an illusion, lunchtime doubly so."
        -Douglas Adams

			http://www.jlbec.org/
			[email protected]

A message that is not in the archive (sent off-list or not yet received): 20050818211749.GD22742@insight

#3 lore raw
Quoted 6 lines · Joel Becker
Quoted 1 line · David Teigland

In the dlm I use config_group_find_obj() which isn't exported.

Did you notice the /* XXX Locking */? Let me go see how you use
it, if it is the best way, we'll need to revisit the function and be sure it's happy.

Yeah, your usage is unsafe, but the fault lies with find_obj().
Needs fixing.

Joel

Signature · 5 lines
"Vote early and vote often." 
        - Al Capone

			http://www.jlbec.org/
			[email protected]

A message that is not in the archive (sent off-list or not yet received): 20050818212022.GE22742@insight

#5 lore raw
Quoted 10 lines · Joel Becker
Quoted 6 lines · Joel Becker
Quoted 1 line · David Teigland

In the dlm I use config_group_find_obj() which isn't exported.

Did you notice the /* XXX Locking */? Let me go see how you use
it, if it is the best way, we'll need to revisit the function and be sure it's happy.

Yeah, your usage is unsafe, but the fault lies with find_obj().
Needs fixing.

And you copied the same issue into get_comm(). When navigating
cg_children (or any part of the object tree), you need to be holding the subsystem semaphore. Someone could race with mkdir/rmdir.

Joel

Signature · 5 lines
"Senator let's be sincere,
 As much as you can."

			http://www.jlbec.org/
			[email protected]