2.6.13-rc6-mm1
A message that is not in the archive (sent off-list or not yet received): [email protected]
Hi,
Quoted 4 lines · Andrew Morton
ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.13-rc6/2.6.13-rc6-mm1/
- Lots of fixes, updates and cleanups all over the place.
Quoted 8 lines
- If you have the right debugging options set, this kernel will generate a storm of sleeping-in-atomic-code warnings at boot, from the scsi code. It is being worked on.
Changes since 2.6.13-rc5-mm1:
linus.patch
Noted this in my log earlier today.
Is this inotify related?
Aug 21 08:33:04 tornado kernel: idr_remove called for id=2048 which is not allocated. Aug 21 08:33:04 tornado kernel: [<c0103a00>] dump_stack+0x17/0x19 Aug 21 08:33:04 tornado kernel: [<c01c9f9a>] idr_remove_warning+0x1b/0x1d Aug 21 08:33:04 tornado kernel: [<c01ca024>] sub_remove+0x88/0xea Aug 21 08:33:04 tornado kernel: [<c01ca0a1>] idr_remove+0x1b/0x7f Aug 21 08:33:04 tornado kernel: [<c018176a>] remove_watch_no_event+0x7a/0x12e Aug 21 08:33:04 tornado kernel: [<c0181f64>] inotify_release+0x8f/0x1af Aug 21 08:33:04 tornado kernel: [<c015ca80>] __fput+0xaf/0x199 Aug 21 08:33:04 tornado kernel: [<c015c9b8>] fput+0x22/0x3b Aug 21 08:33:04 tornado kernel: [<c015b2ed>] filp_close+0x41/0x67 Aug 21 08:33:04 tornado kernel: [<c015b383>] sys_close+0x70/0x92 Aug 21 08:33:04 tornado kernel: [<c0102a9b>] sysenter_past_esp+0x54/0x75 Aug 21 08:33:04 tornado kernel: idr_remove called for id=3072 which is not allocated. Aug 21 08:33:05 tornado kernel: [<c0103a00>] dump_stack+0x17/0x19 Aug 21 08:33:05 tornado kernel: [<c01c9f9a>] idr_remove_warning+0x1b/0x1d Aug 21 08:33:05 tornado kernel: [<c01ca024>] sub_remove+0x88/0xea Aug 21 08:33:05 tornado kernel: [<c01ca0a1>] idr_remove+0x1b/0x7f Aug 21 08:33:05 tornado kernel: [<c018176a>] remove_watch_no_event+0x7a/0x12e Aug 21 08:33:05 tornado kernel: [<c0181f64>] inotify_release+0x8f/0x1af Aug 21 08:33:05 tornado kernel: [<c015ca80>] __fput+0xaf/0x199 Aug 21 08:33:05 tornado kernel: [<c015c9b8>] fput+0x22/0x3b Aug 21 08:33:05 tornado kernel: [<c015b2ed>] filp_close+0x41/0x67 Aug 21 08:33:05 tornado kernel: [<c015b383>] sys_close+0x70/0x92 Aug 21 08:33:05 tornado kernel: [<c0102a9b>] sysenter_past_esp+0x54/0x75
This would have been triggered by using dovecot IMAP which is configured to use inotify on Maildir. I'm also seeing some userspace errors logged for dovecot:
"Aug 21 04:17:22 Error: IMAP(reuben): inotify_rm_watch() failed: Invalid argument"
I'll deal with those with the guy who wrote the inotify code in dovecot.
I'm not so sure userspace should be able or need to cause the kernel to dump stack traces like that though?
reuben
Quoted 52 lines · Reuben Farrelly
Hi,
Quoted 4 lines · Andrew Morton
ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.13-rc6/2.6.13-rc6-mm1/
- Lots of fixes, updates and cleanups all over the place.
Quoted 8 lines
- If you have the right debugging options set, this kernel will generate a storm of sleeping-in-atomic-code warnings at boot, from the scsi code. It is being worked on.
Changes since 2.6.13-rc5-mm1:
linus.patch
Noted this in my log earlier today.
Is this inotify related?
Aug 21 08:33:04 tornado kernel: idr_remove called for id=2048 which is not allocated. Aug 21 08:33:04 tornado kernel: [<c0103a00>] dump_stack+0x17/0x19 Aug 21 08:33:04 tornado kernel: [<c01c9f9a>] idr_remove_warning+0x1b/0x1d Aug 21 08:33:04 tornado kernel: [<c01ca024>] sub_remove+0x88/0xea Aug 21 08:33:04 tornado kernel: [<c01ca0a1>] idr_remove+0x1b/0x7f Aug 21 08:33:04 tornado kernel: [<c018176a>] remove_watch_no_event+0x7a/0x12e Aug 21 08:33:04 tornado kernel: [<c0181f64>] inotify_release+0x8f/0x1af Aug 21 08:33:04 tornado kernel: [<c015ca80>] __fput+0xaf/0x199 Aug 21 08:33:04 tornado kernel: [<c015c9b8>] fput+0x22/0x3b Aug 21 08:33:04 tornado kernel: [<c015b2ed>] filp_close+0x41/0x67 Aug 21 08:33:04 tornado kernel: [<c015b383>] sys_close+0x70/0x92 Aug 21 08:33:04 tornado kernel: [<c0102a9b>] sysenter_past_esp+0x54/0x75 Aug 21 08:33:04 tornado kernel: idr_remove called for id=3072 which is not allocated. Aug 21 08:33:05 tornado kernel: [<c0103a00>] dump_stack+0x17/0x19 Aug 21 08:33:05 tornado kernel: [<c01c9f9a>] idr_remove_warning+0x1b/0x1d Aug 21 08:33:05 tornado kernel: [<c01ca024>] sub_remove+0x88/0xea Aug 21 08:33:05 tornado kernel: [<c01ca0a1>] idr_remove+0x1b/0x7f Aug 21 08:33:05 tornado kernel: [<c018176a>] remove_watch_no_event+0x7a/0x12e Aug 21 08:33:05 tornado kernel: [<c0181f64>] inotify_release+0x8f/0x1af Aug 21 08:33:05 tornado kernel: [<c015ca80>] __fput+0xaf/0x199 Aug 21 08:33:05 tornado kernel: [<c015c9b8>] fput+0x22/0x3b Aug 21 08:33:05 tornado kernel: [<c015b2ed>] filp_close+0x41/0x67 Aug 21 08:33:05 tornado kernel: [<c015b383>] sys_close+0x70/0x92 Aug 21 08:33:05 tornado kernel: [<c0102a9b>] sysenter_past_esp+0x54/0x75This would have been triggered by using dovecot IMAP which is configured to use inotify on Maildir.
I'm also seeing some userspace errors logged for dovecot:
Quoted 7 lines
"Aug 21 04:17:22 Error: IMAP(reuben):
inotify_rm_watch()failed: Invalid argument"I'll deal with those with the guy who wrote the inotify code in dovecot.
I'm not so sure userspace should be able or need to cause the kernel to dump stack traces like that though?
Yes, the stack dumps would appear to be due to an inotify bug.
The message from dovecot is allegedly due to dovecot passing in a file descriptor which was not obtained from the inotify_init() syscall. But until we know what caused those stack dumps we cannot definitely say whether dovecot is at fault.
Quoted 61 lines · Andrew Morton
Quoted 52 lines · Reuben Farrelly
Hi,
Quoted 4 lines · Andrew Morton
ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.13-rc6/2.6.13-rc6-mm1/
- Lots of fixes, updates and cleanups all over the place.
Quoted 8 lines
- If you have the right debugging options set, this kernel will generate a storm of sleeping-in-atomic-code warnings at boot, from the scsi code. It is being worked on.
Changes since 2.6.13-rc5-mm1:
linus.patch
Noted this in my log earlier today.
Is this inotify related?
Aug 21 08:33:04 tornado kernel: idr_remove called for id=2048 which is not allocated. Aug 21 08:33:04 tornado kernel: [<c0103a00>] dump_stack+0x17/0x19 Aug 21 08:33:04 tornado kernel: [<c01c9f9a>] idr_remove_warning+0x1b/0x1d Aug 21 08:33:04 tornado kernel: [<c01ca024>] sub_remove+0x88/0xea Aug 21 08:33:04 tornado kernel: [<c01ca0a1>] idr_remove+0x1b/0x7f Aug 21 08:33:04 tornado kernel: [<c018176a>] remove_watch_no_event+0x7a/0x12e Aug 21 08:33:04 tornado kernel: [<c0181f64>] inotify_release+0x8f/0x1af Aug 21 08:33:04 tornado kernel: [<c015ca80>] __fput+0xaf/0x199 Aug 21 08:33:04 tornado kernel: [<c015c9b8>] fput+0x22/0x3b Aug 21 08:33:04 tornado kernel: [<c015b2ed>] filp_close+0x41/0x67 Aug 21 08:33:04 tornado kernel: [<c015b383>] sys_close+0x70/0x92 Aug 21 08:33:04 tornado kernel: [<c0102a9b>] sysenter_past_esp+0x54/0x75 Aug 21 08:33:04 tornado kernel: idr_remove called for id=3072 which is not allocated. Aug 21 08:33:05 tornado kernel: [<c0103a00>] dump_stack+0x17/0x19 Aug 21 08:33:05 tornado kernel: [<c01c9f9a>] idr_remove_warning+0x1b/0x1d Aug 21 08:33:05 tornado kernel: [<c01ca024>] sub_remove+0x88/0xea Aug 21 08:33:05 tornado kernel: [<c01ca0a1>] idr_remove+0x1b/0x7f Aug 21 08:33:05 tornado kernel: [<c018176a>] remove_watch_no_event+0x7a/0x12e Aug 21 08:33:05 tornado kernel: [<c0181f64>] inotify_release+0x8f/0x1af Aug 21 08:33:05 tornado kernel: [<c015ca80>] __fput+0xaf/0x199 Aug 21 08:33:05 tornado kernel: [<c015c9b8>] fput+0x22/0x3b Aug 21 08:33:05 tornado kernel: [<c015b2ed>] filp_close+0x41/0x67 Aug 21 08:33:05 tornado kernel: [<c015b383>] sys_close+0x70/0x92 Aug 21 08:33:05 tornado kernel: [<c0102a9b>] sysenter_past_esp+0x54/0x75This would have been triggered by using dovecot IMAP which is configured to use inotify on Maildir.
I'm also seeing some userspace errors logged for dovecot:Quoted 7 lines
"Aug 21 04:17:22 Error: IMAP(reuben):
inotify_rm_watch()failed: Invalid argument"I'll deal with those with the guy who wrote the inotify code in dovecot.
I'm not so sure userspace should be able or need to cause the kernel to dump stack traces like that though?
Quoted 7 lines
Yes, the stack dumps would appear to be due to an inotify bug.
The message from dovecot is allegedly due to dovecot passing in a file descriptor which was not obtained from the
inotify_init()syscall. But until we know what caused those stack dumps we cannot definitely say whether dovecot is at fault.
Inotify has a check on both add and rm watch syscalls:
/* verify that this is indeed an inotify instance */
if (unlikely(filp->f_op != &inotify_fops)) {
ret = -EINVAL;
goto out;
}This is crashing in inotify_release, which is called on close of the inotify instance. So this fd must be from an inotify instance right?
I looked at the dovecot code, it looks fine wrt inotify. Long shot, but the close-on-exec flag is set. Could this be tripping anything up?
Signature · 1 line
John McCutchan <[email protected]>