Skip to contentSkip to conversation

SECURITY must depend on SYSFS

PATCH In review Adrian Bunk 3 participants 5 messages Aug 22, 2005 Security (LSM)

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 SECURITY must depend on SYSFS

CONFIG_SECURITY=y and CONFIG_SYSFS=n results in the following compile error:

<-- snip -->

...
LD vmlinux
security/built-in.o: In function `securityfs_init':
inode.c:(.init.text+0x1c2): undefined reference to `kernel_subsys'
make: *** [vmlinux] Error 1

<-- snip -->

---

This patch was already sent on:
- 24 Jul 2005

security/Kconfig renamed from security/Kconfig.old +1 -0
@@ -35,6 +35,7 @@
 
 config SECURITY
 	bool "Enable different security models"
+	depends on SYSFS
 	help
 	  This allows you to choose different security modules to be
 	  configured into your kernel.
#1 lore raw

security/Kconfig line 38

Quoted 3 lines · * Adrian Bunk ([email protected]) wrote:

config SECURITY

security/Kconfig renamed from security/Kconfig.old +1 -0
 	bool "Enable different security models"
+	depends on SYSFS

Hmm, what about select instead?

thanks,
-chris

#2 lore raw
Quoted 6 lines · Chris Wright

security/Kconfig line 38

Quoted 3 lines · * Adrian Bunk ([email protected]) wrote:

config SECURITY

security/Kconfig renamed from security/Kconfig.old +1 -0
 	bool "Enable different security models"
+	depends on SYSFS

Hmm, what about select instead?

I have no strong opinion on this, especially since this is only an issue in the COMFIG_EMBEDDED=y case.

Quoted 2 lines

thanks,
-chris

cu
Adrian

Signature · 4 lines
       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed
#3 lore raw
In reply to Chris Wright

Hi,

Quoted 6 lines · Chris Wright

security/Kconfig line 38

Quoted 3 lines · * Adrian Bunk ([email protected]) wrote:

config SECURITY

security/Kconfig renamed from security/Kconfig.old +1 -0
 	bool "Enable different security models"
+	depends on SYSFS

Hmm, what about select instead?

What's wrong with a normal dependency?
Please don't abuse select, use it only if you really have to.

bye, Roman

#4 lore raw
Quoted 1 line · * Roman Zippel ([email protected]) wrote:

What's wrong with a normal dependency?

Trying to enable when SYSFS under fs->pseudo->fs but security is under security-> is just confusing, with no obvious (user perspective) dependency.

Quoted 1 line

Please don't abuse select, use it only if you really have to.

OK, depends will be fine, esp. since it's just effecting CONFIG_EMBEDDED.

thanks,
-chris