Skip to contentSkip to conversation

dereference of uninitialized pointer in zatm

PATCH New Al Viro 1 participant 1 message Sep 19, 2005 ATM

lore
Share & tools
lore

Al Viro

author
#0 lore raw

PATCH 1/1 dereference of uninitialized pointer in zatm

	Breakage from [NET]: Kill skb->list

----

drivers/atm/zatm.c +2 -2
diff -urN RC13-base/drivers/atm/zatm.c current/drivers/atm/zatm.c
@@ -417,9 +417,9 @@
 		chan = (here[3] & uPD98401_AAL5_CHAN) >>
 		    uPD98401_AAL5_CHAN_SHIFT;
 		if (chan < zatm_dev->chans && zatm_dev->rx_map[chan]) {
-			int pos = ZATM_VCC(vcc)->pool;
-
+			int pos;
 			vcc = zatm_dev->rx_map[chan];
+			pos = ZATM_VCC(vcc)->pool;
 			if (skb == zatm_dev->last_free[pos])
 				zatm_dev->last_free[pos] = NULL;
 			skb_unlink(skb, zatm_dev->pool + pos);