Skip to contentSkip to conversation

more of sparc32 dependencies fallout

PATCH Applied [email protected] 3 participants 5 messages Sep 2, 2005

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 more of sparc32 dependencies fallout

More stuff that got exposed to sparc32 build due to inclusion of drivers/char/Kconfig in arch/sparc/Kconfig needs to be excluded.

----

drivers/char/Kconfig +1 -1
diff -urN RC13-zatm/drivers/char/Kconfig RC13-mxser-sparc32/drivers/char/Kconfig
@@ -175,7 +175,7 @@
 
 config MOXA_SMARTIO
 	tristate "Moxa SmartIO support"
-	depends on SERIAL_NONSTANDARD
+	depends on SERIAL_NONSTANDARD && (BROKEN || !SPARC32)
 	help
 	  Say Y here if you have a Moxa SmartIO multiport serial card.
 
#2 lore raw
In reply to [email protected]

drivers/char/Kconfig line 179

Quoted 5 lines · On Gwe, 2005-09-02 at 20:12 +0100, [email protected] wrote:

config MOXA_SMARTIO

drivers/char/Kconfig +1 -1
 	tristate "Moxa SmartIO support"
-	depends on SERIAL_NONSTANDARD
+	depends on SERIAL_NONSTANDARD && (BROKEN || !SPARC32)
 	help

Why mark it "BROKEN" and !SPARC32. Why not mark it (ISA || PCI) ? Its only available as a plugin card and its apparently working

#3 lore raw

From: Alan Cox <[email protected]>
Subject: Re: [PATCH] more of sparc32 dependencies fallout
Date: Fri, 02 Sep 2005 21:24:08 +0100

Quoted 10 lines · On Gwe, 2005-09-02 at 20:12 +0100, [email protected] wrote:

drivers/char/Kconfig line 179

Quoted 5 lines

config MOXA_SMARTIO

drivers/char/Kconfig +1 -1
 	tristate "Moxa SmartIO support"
-	depends on SERIAL_NONSTANDARD
+	depends on SERIAL_NONSTANDARD && (BROKEN || !SPARC32)
 	help

Why mark it "BROKEN" and !SPARC32. Why not mark it (ISA || PCI) ? Its only available as a plugin card and its apparently working

He marked it BROKEN "OR" !SPARC32, not "AND". Also, SPARC32 supports PCI on Javastation machines.

#4 lore raw
Quoted 15 lines · David S. Miller

From: Alan Cox <[email protected]>
Subject: Re: [PATCH] more of sparc32 dependencies fallout
Date: Fri, 02 Sep 2005 21:24:08 +0100

Quoted 10 lines · On Gwe, 2005-09-02 at 20:12 +0100, [email protected] wrote:

Review

Quoted 5 lines

config MOXA_SMARTIO

(quoted diff) +1 -1
 	tristate "Moxa SmartIO support"
-	depends on SERIAL_NONSTANDARD
+	depends on SERIAL_NONSTANDARD && (BROKEN || !SPARC32)
 	help

Why mark it "BROKEN" and !SPARC32. Why not mark it (ISA || PCI) ? Its only available as a plugin card and its apparently working

Quoted 2 lines

He marked it BROKEN "OR" !SPARC32, not "AND". Also, SPARC32 supports PCI on Javastation machines.

Actually, proper fix of that breakage is embarrassingly simple - it's yet another gratitious leftover include of asm/segment.h, so incremental to the previos would be removal of that BROKEN and removal of bogus include from mxser.c itself.

drivers/char/Kconfig +1 -1
diff -urN RC13-git3-base/drivers/char/Kconfig current/drivers/char/Kconfig
@@ -175,7 +175,7 @@
 
 config MOXA_SMARTIO
 	tristate "Moxa SmartIO support"
-	depends on SERIAL_NONSTANDARD && (BROKEN || !SPARC32)
+	depends on SERIAL_NONSTANDARD
 	help
 	  Say Y here if you have a Moxa SmartIO multiport serial card.
 
drivers/char/mxser.c +0 -1
diff -urN RC13-git3-base/drivers/char/mxser.c current/drivers/char/mxser.c
@@ -63,7 +63,6 @@
 #include <asm/system.h>
 #include <asm/io.h>
 #include <asm/irq.h>
-#include <asm/segment.h>
 #include <asm/bitops.h>
 #include <asm/uaccess.h>