Skip to contentSkip to conversation

My 3 patches

U-Boot-Users Applied luo.jinhua 3 participants 4 messages Sep 2, 2005 – Jul 22, 2006

lore
Share & tools
lore

luo.jinhua

author
#0 lore raw

Hi.

Here is my 3 patches.

sbc2410x.patch is for the new board -- SBC-2410X. I write this new hardware-specific configurations refer to smdk2410 configurations in U-Boot. File list:
MAKEALL
Makefile
board/sbc2410x/Makefile
board/sbc2410x/config.mk
board/sbc2410x/flash.c
board/sbc2410x/lowlevel_init.S
board/sbc2410x/sbc2410x.c
board/sbc2410x/u-boot.lds
cpu/arm920t/s3c24x0/interrupts.c
include/configs/sbc2410x.h
This patch adds a new configuration option -- CONFIG_SBC2410X.

cmdline_editing.patch implements cmdline-editing extension of readline. I pick codes heavily borrowed from vivi bootloader and integrate them into U-Boot. File list:
common/main.c
This patch adds a new configuration option -- CONFIG_CMDLINE_EDITING.

nand_for_sbc2410x.patch adds nand support for SBC-2410X board. It do that by taking nand controller specific codes (from VCMA9 board) in place. File list:
common/cmd_nand.c
include/linux/mtd/nand.h
include/linux/mtd/nand_ids.h

more detail please review:
http://sourceforge.net/mailarchive/forum.php?thread_id=8089177&forum_id=12898

CHANGELOG item:
* Add support for friendly-arm SBC-2410X board
Patch by JinHua Luo, 1 Sep 2005
* Add to readline cmdline-editing extension
Patch by JinHua Luo, 1 Sep 2005
* Add nand support for SBC-2410X
Patch by JinHua Luo, 1 Sep 2005

CREDIT item (if proper):
N: JinHua Luo
E: luo.jinhua at gd-linux.com home_king at 163.com
D: Support for friendly-arm SBC-2410X board
D: Add to readline cmdline-editing extension
D: Add nand support for SBC-2410X
W: www.gd-linux.com

Best regards,

luo.jinhua

--
JinHua Luo, GuangDong Linux Center, <[email protected]>

-------------- next part --------------
A non-text attachment was scrubbed...
Name: cmdline_editing.patch.gz
Type: application/x-gzip
Size: 2696 bytes
Desc: not available
Url : http://lists.denx.de/pipermail/u-boot/attachments/20050902/c769e81a/attachment.bin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: sbc2410x.patch.gz
Type: application/x-gzip
Size: 9577 bytes
Desc: not available
Url : http://lists.denx.de/pipermail/u-boot/attachments/20050902/c769e81a/attachment-0001.bin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: nand_for_sbc2410x.patch.gz
Type: application/x-gzip
Size: 972 bytes
Desc: not available
Url : http://lists.denx.de/pipermail/u-boot/attachments/20050902/c769e81a/attachment-0002.bin

#1 lore raw

Hi:

I applied your patch my U-Boot. But I found one bug in this patch in cread_line() function, you should return the number of read characters. You return the "rc" at the end of the function, but rc always equals 0. The u-boot command will NOT be executed.

I modified the to return (eol_num). It is ok.

You can check it.

Bryan Wu from China.

----- Original Message -----
From: "luo.jinhua" <[email protected]>
To: "u-boot-users" <[email protected]>
Sent: Friday, September 02, 2005 10:02 AM
Subject: [U-Boot-Users] My 3 patches

Quoted 59 lines

Hi.

Here is my 3 patches.

sbc2410x.patch is for the new board -- SBC-2410X. I write this new hardware-specific configurations refer to smdk2410 configurations in U-Boot. File list:
MAKEALL
Makefile
board/sbc2410x/Makefile
board/sbc2410x/config.mk
board/sbc2410x/flash.c
board/sbc2410x/lowlevel_init.S
board/sbc2410x/sbc2410x.c
board/sbc2410x/u-boot.lds
cpu/arm920t/s3c24x0/interrupts.c
include/configs/sbc2410x.h
This patch adds a new configuration option -- CONFIG_SBC2410X.

cmdline_editing.patch implements cmdline-editing extension of readline. I pick codes heavily borrowed from vivi bootloader and integrate them into U-Boot. File list:
common/main.c
This patch adds a new configuration option -- CONFIG_CMDLINE_EDITING.

nand_for_sbc2410x.patch adds nand support for SBC-2410X board. It do that by taking nand controller specific codes (from VCMA9 board) in place. File list:
common/cmd_nand.c
include/linux/mtd/nand.h
include/linux/mtd/nand_ids.h

more detail please review:
http://sourceforge.net/mailarchive/forum.php?thread_id=8089177&forum_id=12898

CHANGELOG item:
* Add support for friendly-arm SBC-2410X board
Patch by JinHua Luo, 1 Sep 2005
* Add to readline cmdline-editing extension
Patch by JinHua Luo, 1 Sep 2005
* Add nand support for SBC-2410X
Patch by JinHua Luo, 1 Sep 2005

CREDIT item (if proper):
N: JinHua Luo
E: luo.jinhua at gd-linux.com home_king at 163.com
D: Support for friendly-arm SBC-2410X board
D: Add to readline cmdline-editing extension
D: Add nand support for SBC-2410X
W: www.gd-linux.com

Best regards,

luo.jinhua

--
JinHua Luo, GuangDong Linux Center, <[email protected]>

author
#2 lore raw

On Fri, 16 Sep 2005 18:36:09 +0800, Bryan Wu wrote

Quoted 7 lines

Hi:

I applied your patch my U-Boot. But I found one bug in this patch in cread_line() function, you should return the number of read characters. You return the "rc" at the end of the function, but rc always equals
0. The u-boot command will NOT be executed.

Quoted 5 lines

I modified the to return (eol_num). It is ok.

You can check it.

Bryan Wu from China.

Thank you.

It is indeed a bug. However, while I always use CFG_HUSH_PARSER, the hush engine ignores the "rc" retval and recalculates the console_buffer length, which make me miss the bug.

Best regards,

luo.jinhua
----------
JinHua Luo, GuangDong Linux Center, <[email protected]>

#3 lore raw
In reply to luo.jinhua

Dear JinHua Luo,

Quoted 2 lines · in message <[email protected]> you wrote:

Here is my 3 patches.

Thanks a lot for your contribution.

Quoted 2 lines

sbc2410x.patch is for the new board -- SBC-2410X. I write this new hardware-specific configurations refer to smdk2410 configurations in U-Boot.

Applied, thanks.

Quoted 2 lines

cmdline_editing.patch implements cmdline-editing extension of readline. I pick codes heavily borrowed from vivi bootloader and integrate them into U-Boot.

Applied, thanks a lot!

Quoted 1 line

This patch adds a new configuration option -- CONFIG_CMDLINE_EDITING.

...which should have been documented in the README (I did this for you).

Quoted 6 lines

nand_for_sbc2410x.patch adds nand support for SBC-2410X board. It do that by taking nand controller specific codes (from VCMA9 board) in place. File list:
common/cmd_nand.c
include/linux/mtd/nand.h
include/linux/mtd/nand_ids.h

I did not add this patch, though. I think you will have to adapt it to the current (new) NAND code first. Can you please do this, and then resubmit this part? Thanks!

Best regards,

Wolfgang Denk

Signature · 3 lines
Software Engineering:  Embedded and Realtime Systems,  Embedded Linux
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
The light at the end of the tunnel is usually a "No Exit" sign.