Skip to contentSkip to conversation

net/netfilter/nfnetlink*: make functions static

PATCH In review Adrian Bunk 2 participants 2 messages Sep 3, 2005

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 net/netfilter/nfnetlink*: make functions static

This patch makes needlessly global functions static.

---

 net/netfilter/nfnetlink.c       |    4 ++--
 net/netfilter/nfnetlink_queue.c |    2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)
net/netfilter/nfnetlink.c renamed from net/netfilter/nfnetlink.c.old +2 -2
@@ -344,14 +344,14 @@
 	} while(nfnl && nfnl->sk_receive_queue.qlen);
 }
 
-void __exit nfnetlink_exit(void)
+static void __exit nfnetlink_exit(void)
 {
 	printk("Removing netfilter NETLINK layer.\n");
 	sock_release(nfnl->sk_socket);
 	return;
 }
 
-int __init nfnetlink_init(void)
+static int __init nfnetlink_init(void)
 {
 	printk("Netfilter messages via NETLINK v%s.\n", nfversion);
 
net/netfilter/nfnetlink_queue.c renamed from net/netfilter/nfnetlink_queue.c.old +1 -1
@@ -76,7 +76,7 @@
 
 static DEFINE_RWLOCK(instances_lock);
 
-u_int64_t htonll(u_int64_t in)
+static u_int64_t htonll(u_int64_t in)
 {
 	u_int64_t out;
 	int i;
#1 lore raw
Quoted 1 line · Adrian Bunk

This patch makes needlessly global functions static.

Thanks for your patch. I'll merge it with my local changes (it clashes, since the "htonll" implementation was removed) and submit it via davem later today.

Signature · 5 lines
- Harald Welte <[email protected]>                 http://netfilter.org/
============================================================================
  "Fragmentation is like classful addressing -- an interesting early
   architectural error that shows how much experimentation was going
   on while IP was being designed."                    -- Paul Vixie