Skip to contentSkip to conversation

orinoco: New driver - spectrum_cs.

PATCH In review Pavel Roskin 2 participants 3 messages Sep 2, 2005 – Sep 9, 2005 1 message not in the archive

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 8/8 orinoco: New driver - spectrum_cs.

diff-tree dee4f325520d4ea29397dd67ca657b7235bb1790 (from c88faac230cc9775445e5c644991c352e35c72a1)

Author: Pavel Roskin <proski-mXXj517/[email protected]>
Date:   Thu Sep 1 17:46:39 2005 -0400

New driver - spectrum_cs.

Driver for 802.11b cards using RAM-loadable Symbol firmware, such as Symbol Wireless Networker LA4100, CompactFlash cards by Socket Communications and Intel PRO/Wireless 2011B.

The driver implements Symbol firmware download. The rest is handled in hermes.c and orinoco.c.

Utilities for downloading the Symbol firmware are available at
http://sourceforge.net/projects/orinoco/

drivers/net/wireless/Kconfig +13 -0
@@ -269,10 +269,23 @@ config PCMCIA_HERMES
 
 	  You will also very likely also need the Wireless Tools in order to
 	  configure your card and that /etc/pcmcia/wireless.opts works:
 	  <http://www.hpl.hp.com/personal/Jean_Tourrilhes/Linux/Tools.html>.
 
+config PCMCIA_SPECTRUM
+	tristate "Symbol Spectrum24 Trilogy PCMCIA card support"
+	depends on NET_RADIO && PCMCIA && HERMES
+	---help---
+
+	  This is a driver for 802.11b cards using RAM-loadable Symbol
+	  firmware, such as Symbol Wireless Networker LA4100, CompactFlash
+	  cards by Socket Communications and Intel PRO/Wireless 2011B.
+
+	  This driver requires firmware download on startup.  Utilities
+	  for downloading Symbol firmware are available at
+	  <http://sourceforge.net/projects/orinoco/>
+
 config AIRO_CS
 	tristate "Cisco/Aironet 34X/35X/4500/4800 PCMCIA cards"
 	depends on NET_RADIO && PCMCIA && (BROKEN || !M32R)
 	---help---
 	  This is the standard Linux driver to support Cisco/Aironet PCMCIA
drivers/net/wireless/Makefile +1 -0
@@ -17,10 +17,11 @@ obj-$(CONFIG_PCMCIA_HERMES)	+= orinoco_c
 obj-$(CONFIG_APPLE_AIRPORT)	+= airport.o
 obj-$(CONFIG_PLX_HERMES)	+= orinoco_plx.o
 obj-$(CONFIG_PCI_HERMES)	+= orinoco_pci.o
 obj-$(CONFIG_TMD_HERMES)	+= orinoco_tmd.o
 obj-$(CONFIG_NORTEL_HERMES)	+= orinoco_nortel.o
+obj-$(CONFIG_PCMCIA_SPECTRUM)	+= spectrum_cs.o
 
 obj-$(CONFIG_AIRO)		+= airo.o
 obj-$(CONFIG_AIRO_CS)		+= airo_cs.o airo.o
 
 obj-$(CONFIG_ATMEL)             += atmel.o
drivers/net/wireless/spectrum_cs.c new file +1120 -0

1,120 lines not on this page · raw message

Signature · 10 lines
Regards,
Pavel Roskin



-------------------------------------------------------
SF.Net email is Sponsored by the Better Software Conference & EXPO
September 19-22, 2005 * San Francisco, CA * Development Lifecycle Practices
Agile & Plan-Driven Development * Managing Projects & Teams * Testing & QA
Security * Process Improvement & Measurement * http://www.sqe.com/bsce5sf
#1 lore raw

drivers/net/wireless/spectrum_cs.c line 27

Quoted 3 lines
drivers/net/wireless/spectrum_cs.c new file +3 -0
+#ifdef  __IN_PCMCIA_PACKAGE__
+#include <pcmcia/k_compat.h>
+#endif /* __IN_PCMCIA_PACKAGE__ */

this doesn't make sense for a 2.6 driver.

Quoted 7 lines
drivers/net/wireless/spectrum_cs.c new file +7 -0
+/*
+ * If SPECTRUM_FW_INCLUDED is defined, the firmware is hardcoded into
+ * the driver.  Use get_symbol_fw script to generate spectrum_fw.h and
+ * copy it to the same directory as spectrum_cs.c.
+ *
+ * If SPECTRUM_FW_INCLUDED is not defined, the firmware is loaded at the
+ * runtime using hotplug.  Use the same get_symbol_fw script to generate

drivers/net/wireless/spectrum_cs.c line 70

Quoted 10 lines
drivers/net/wireless/spectrum_cs.c new file +10 -0
+ * files symbol_sp24t_prim_fw symbol_sp24t_sec_fw, copy them to the
+ * hotplug firmware directory (typically /usr/lib/hotplug/firmware) and
+ * make sure that you have hotplug installed and enabled in the kernel.
+ */
+/* #define SPECTRUM_FW_INCLUDED 1 */
+
+#ifdef SPECTRUM_FW_INCLUDED
+/* Header with the firmware */
+#include "spectrum_fw.h"
+#else	/* !SPECTRUM_FW_INCLUDED */

While I see the point of this for the standalone orinoco driver package it doesn't make sense for the version in the kernel tree.

drivers/net/wireless/spectrum_cs.c line 296

Quoted 2 lines
drivers/net/wireless/spectrum_cs.c new file +2 -0
+#define CS_CHECK(fn, ret) \
+  do { last_fn = (fn); if ((last_ret = (ret)) != 0) goto cs_failed; } while (0)

I don't think this macro abuse helps anyone..

-------------------------------------------------------
SF.Net email is Sponsored by the Better Software Conference & EXPO September 19-22, 2005 * San Francisco, CA * Development Lifecycle Practices Agile & Plan-Driven Development * Managing Projects & Teams * Testing & QA Security * Process Improvement & Measurement * http://www.sqe.com/bsce5sf

A message that is not in the archive (sent off-list or not yet received): [email protected]

#3 lore raw
Quoted 5 lines · Christoph Hellwig

drivers/net/wireless/spectrum_cs.c line 27

Quoted 3 lines
drivers/net/wireless/spectrum_cs.c new file +3 -0
+#ifdef  __IN_PCMCIA_PACKAGE__
+#include <pcmcia/k_compat.h>
+#endif /* __IN_PCMCIA_PACKAGE__ */

this doesn't make sense for a 2.6 driver.

Fixed in my tree, thanks. Patches will be sent shortly.

Quoted 7 lines

drivers/net/wireless/spectrum_cs.c line 70

Quoted 4 lines
drivers/net/wireless/spectrum_cs.c new file +4 -0
+#ifdef SPECTRUM_FW_INCLUDED
+/* Header with the firmware */
+#include "spectrum_fw.h"
+#else	/* !SPECTRUM_FW_INCLUDED */

While I see the point of this for the standalone orinoco driver package it doesn't make sense for the version in the kernel tree.

Likewise.

Quoted 5 lines

drivers/net/wireless/spectrum_cs.c line 296

Quoted 3 lines
drivers/net/wireless/spectrum_cs.c new file +2 -0
+#define CS_CHECK(fn, ret) \
+  do { last_fn = (fn); if ((last_ret = (ret)) != 0) goto cs_failed; } while (0)

I don't think this macro abuse helps anyone..

Sure, but it's abused by many drivers. Maybe next time.

Signature · 10 lines
Regards,
Pavel Roskin



-------------------------------------------------------
SF.Net email is Sponsored by the Better Software Conference & EXPO
September 19-22, 2005 * San Francisco, CA * Development Lifecycle Practices
Agile & Plan-Driven Development * Managing Projects & Teams * Testing & QA
Security * Process Improvement & Measurement * http://www.sqe.com/bsce5sf