x86: check host bridge when applying vendor quirks
PATCH 1/1 x86: check host bridge when applying vendor quirks
I was looking at the i386 ACPI early quirk code and x86_64 equivalent and it seems to me it should be checking the host bridge vendor, not the one for various PCI bridges. Nvidia might release some kind of PCI card with an embedded bridge that would break this code, for example. I made this patch but I can't test it:
arch/i386/kernel/acpi/earlyquirk.c | 2 +- arch/x86_64/kernel/io_apic.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
arch/i386/kernel/acpi/earlyquirk.c +1 -1
@@ -36,7 +36,7 @@ void __init check_acpi_pci(void)if (class ==0xffffffff )break ; -if ((class >>16 ) !=PCI_CLASS_BRIDGE_PCI ) +if ((class >>16 ) !=PCI_CLASS_BRIDGE_HOST )continue ; vendor = read_pci_config(num, slot, func,
arch/x86_64/kernel/io_apic.c +1 -1
@@ -242,7 +242,7 @@ void __init check_ioapic(void)if (class ==0xffffffff )break ; -if ((class >>16 ) !=PCI_CLASS_BRIDGE_PCI ) +if ((class >>16 ) !=PCI_CLASS_BRIDGE_HOST )continue ; vendor = read_pci_config(num, slot, func,
__
Chuck
Quoted 5 lines · Chuck Ebbert
I was looking at the i386 ACPI early quirk code and
x86_64equivalent and it seems to me it should be checking the host bridge vendor, not the one for various PCI bridges. Nvidia might release some kind of PCI card with an embedded bridge that would break this code, for example. I made this patch but I can't test it:
It's wrong. On AMD K8 systems the host bridge is always from AMD because the Northbridge is part of the CPU.
-Andi
Quoted 10 lines · Andi Kleen
Quoted 5 lines · Chuck Ebbert
I was looking at the i386 ACPI early quirk code and
x86_64equivalent and it seems to me it should be checking the host bridge vendor, not the one for various PCI bridges. Nvidia might release some kind of PCI card with an embedded bridge that would break this code, for example. I made this patch but I can't test it:It's wrong. On AMD K8 systems the host bridge is always from AMD because the Northbridge is part of the CPU.
Hmmm... no.
root@Weasley:/etc# lspci 00:00.0 Host bridge: ATI Technologies Inc: Unknown device 5950 <...many things...> 00:18.0 Host bridge: Advanced Micro Devices [AMD] K8 [Athlon64/Opteron] HyperTransport Technology Configuration 00:18.1 Host bridge: Advanced Micro Devices [AMD] K8 [Athlon64/Opteron] Address Map 00:18.2 Host bridge: Advanced Micro Devices [AMD] K8 [Athlon64/Opteron] DRAM Controller 00:18.3 Host bridge: Advanced Micro Devices [AMD] K8 [Athlon64/Opteron] Miscellaneous Control
The Athlon64 machines has an external host bridge. You can look the ATI Host Bridge in the first line of lspci.
Piter PUNK
Quoted 1 line · Piter PUNK
Hmmm... no.
Yes. e.g. the Machines with AMD 8111 or Nvidia chipsets don't have another Hostbridge.
Quoted 12 lines
Quoted 1 line
root@Weasley:/etc# lspci00:00.0 Host bridge: ATI Technologies Inc: Unknown device 5950 <...many things...>
00:18.0 Host bridge: Advanced Micro Devices [AMD] K8 [Athlon64/Opteron] HyperTransport Technology Configuration
00:18.1 Host bridge: Advanced Micro Devices [AMD] K8 [Athlon64/Opteron] Address Map
00:18.2 Host bridge: Advanced Micro Devices [AMD] K8 [Athlon64/Opteron] DRAM Controller
00:18.3 Host bridge: Advanced Micro Devices [AMD] K8 [Athlon64/Opteron] Miscellaneous Control
Quoted 2 lines
The Athlon64 machines has an external host bridge. You can look the ATI Host Bridge in the first line of lspci.
Maybe your ATI chipset, but not in general.
-Andi