Skip to contentSkip to conversation

x86: check host bridge when applying vendor quirks

PATCH Chuck Ebbert 1 participant 1 message Sep 9, 2005

lore
Share & tools
lore
#0 lore raw

In-Reply-To: <[email protected]>

Quoted 9 lines · Andi Kleen
Quoted 5 lines · Chuck Ebbert

I was looking at the i386 ACPI early quirk code and x86_64 equivalent and it seems to me it should be checking the host bridge vendor, not the one for various PCI bridges. Nvidia might release some kind of PCI card with an embedded bridge that would break this code, for example. I made this patch but I can't test it:

It's wrong. On AMD K8 systems the host bridge is always from AMD because the Northbridge is part of the CPU.

It's at least right on my system:

00:00.0 Host bridge: ATI Technologies Inc RS480 Host Bridge (rev 01)
00:18.0 Host bridge: Advanced Micro Devices [AMD] K8 [Athlon64/Opteron] HyperTransport Technology Configuration 00:18.1 Host bridge: Advanced Micro Devices [AMD] K8 [Athlon64/Opteron] Address Map
00:18.2 Host bridge: Advanced Micro Devices [AMD] K8 [Athlon64/Opteron] DRAM Controller 00:18.3 Host bridge: Advanced Micro Devices [AMD] K8 [Athlon64/Opteron] Miscellaneous Control __
Chuck