Skip to contentSkip to conversation

SCSI: Don't be so verbose if no disc is present

PATCH In review Daniel Drake 2 participants 2 messages Sep 9, 2005 SCSI

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 SCSI: Don't be so verbose if no disc is present

Running a simple "touch /dev/scd0" on a SCSI cdrom will cause the following message to appear in the logs if no disc is present:

Device not ready. Make sure there is a disc in the drive.

This results in the logs being flooded for some users by those userspace agents which repeatedly poll the device for media change.

This patch demotes the message to a quieter scsi-logging message only.

drivers/scsi/scsi_ioctl.c renamed from drivers/scsi/scsi_ioctl.c.orig +3 -2
@@ -118,8 +118,9 @@ static int ioctl_internal_command(struct
 			break;
 		case NOT_READY:	/* This happens if there is no disc in drive */
 			if (sdev->removable && (cmd[0] != TEST_UNIT_READY)) {
-				printk(KERN_INFO "Device not ready. Make sure"
-				       " there is a disc in the drive.\n");
+				SCSI_LOG_IOCTL(2, printk(
+				       "Device not ready. Make sure"
+				       " there is a disc in the drive.\n"));
 				break;
 			}
 		case UNIT_ATTENTION:
#1 lore raw

Hi ... did you try James' patch? Looks like the same problem.

Patch here:

http://marc.theaimsgroup.com/?l=linux-scsi&m=112585164819923&w=2

Was hidden within some other thread ...

Quoted 12 lines · Daniel Drake

Running a simple "touch /dev/scd0" on a SCSI cdrom will cause the following message to appear in the logs if no disc is present:

Device not ready. Make sure there is a disc in the drive.

This results in the logs being flooded for some users by those userspace agents which repeatedly poll the device for media change.

This patch demotes the message to a quieter scsi-logging message only.