drivers/char: pci_find_device remove
Subsystems (2)
cover drivers/char: pci_find_device remove
Set of patches, which removes pci_find_device from drivers/char subtree.
ip2main.c | 8 +++++--- istallion.c | 9 +++++---- mxser.c | 3 ++- rocket.c | 2 +- specialix.c | 9 ++++++--- stallion.c | 6 ++++-- sx.c | 2 +- watchdog/alim1535_wdt.c | 12 +++++++++--- watchdog/alim7101_wdt.c | 9 +++++++-- watchdog/i8xx_tco.c | 5 +++-- 10 files changed, 43 insertions(+), 22 deletions(-)
PATCH 1/10 drivers/char: pci_find_device remove (drivers/char/ip2main.c)
ip2main.c | 8 +++++--- 1 files changed, 5 insertions(+), 3 deletions(-)
drivers/char/ip2main.c +5 -3
@@ -442,6 +442,7 @@ cleanup_module(void)#ifdef CONFIG_PCI if (ip2config.type[i] ==PCI && ip2config.pci_dev[i]) {pci_disable_device (ip2config.pci_dev[i]); +pci_dev_put (ip2config.pci_dev[i]); ip2config.pci_dev[i] =NULL ; }#endif
@@ -594,9 +595,10 @@ ip2_loadmain(int *iop, int *irqp, unsigncase PCI :#ifdef CONFIG_PCI { -struct pci_dev *pci_dev_i =NULL ; - pci_dev_i =pci_find_device (PCI_VENDOR_ID_COMPUTONE , -PCI_DEVICE_ID_COMPUTONE_IP2EX , pci_dev_i); +struct pci_dev *pci_dev_i; + pci_dev_i =pci_get_device ( +PCI_VENDOR_ID_COMPUTONE , +PCI_DEVICE_ID_COMPUTONE_IP2EX ,NULL );if (pci_dev_i !=NULL ) {unsigned int addr;
Re: [PATCH 1/10] drivers/char: pci_find_device remove (drivers/char/ip2main.c)
Jiri Slaby napsal(a):
Quoted 32 lines
Signed-off-by Jiri Slaby <[email protected]>
ip2main.c| 8 +++++---1 files changed, 5 insertions(+), 3 deletions(-)drivers/char/ip2main.c +5
-3@@ -442,6 +442,7 @@ cleanup_module(void)#ifdef CONFIG_PCI if (ip2config.type[i] ==PCI && ip2config.pci_dev[i]) {pci_disable_device (ip2config.pci_dev[i]); +pci_dev_put (ip2config.pci_dev[i]); ip2config.pci_dev[i] =NULL ; }#endif @@ -594,9 +595,10 @@ ip2_loadmain(int *iop, int *irqp, unsigncase PCI :#ifdef CONFIG_PCI { -struct pci_dev *pci_dev_i =NULL ; - pci_dev_i =pci_find_device (PCI_VENDOR_ID_COMPUTONE , -PCI_DEVICE_ID_COMPUTONE_IP2EX , pci_dev_i); +struct pci_dev *pci_dev_i; + pci_dev_i =pci_get_device ( +PCI_VENDOR_ID_COMPUTONE , +PCI_DEVICE_ID_COMPUTONE_IP2EX ,NULL );if (pci_dev_i !=NULL ) {unsigned int addr;
Re: [PATCH 1/10] drivers/char: pci_find_device remove (drivers/char/ip2main.c)
Jiri Slaby napsal(a):
Quoted 1 line
Cc [email protected] [maintainer]
Hello.
Is drivers/char/ip2main.c still maintained? Are you going to rewrite this driver to 2.6 API (PCI probing etc.)?
thanks,
Signature · 3 lines
Jiri Slaby www.fi.muni.cz/~xslaby ~\-/~ [email protected] ~\-/~ 241B347EC88228DE51EE A49C4A73A25004CB2A10
Re: [PATCH 1/10] drivers/char: pci_find_device remove (drivers/char/ip2main.c)
Quoted 8 lines · Jiri Slaby
Jiri Slaby napsal(a):
Quoted 1 line
Cc [email protected] [maintainer]Hello.
Is
drivers/char/ip2main.cstill maintained? Are you going to rewrite this driver to 2.6 API (PCI probing etc.)?
It seems, like it isn't, last chance to respond, otherwise the driver becomes unmaintained (let's say on 12 Oct).
thanks,
--
Jiri Slaby www.fi.muni.cz/~xslaby
~\-/~ [email protected] ~\-/~
B67499670407CE62ACC8 22A032CC55C339D47A7E
Maintainers one entry removed
Computone intelliport multiport card is no longer maintained. The maintainer doesn't respond to e-mails (3 times during 1 month). The page was updated 2 years ago and there is no other contact.
---
commit a6e455aea055d5c0bd9abd69fc0c40b41d76b993
tree 583e168ce727b57836064b2a0eb63326a1ef529e
parent ef1b647cf1a27b138123d31ab885b3e92cdbe4e9
author root <root@anemoi.(none)> Wed, 12 Oct 2005 18:33:10 +0200 committer root <root@anemoi.(none)> Wed, 12 Oct 2005 18:33:10 +0200
MAINTAINERS | 6 ------ 1 files changed, 0 insertions(+), 6 deletions(-)
MAINTAINERS +0 -6
@@ -580,12 +580,6 @@ M: [email protected] L: [email protected] S: Supported -COMPUTONE INTELLIPORT MULTIPORT CARD -P: Michael H. Warfield -M: [email protected] -W: http://www.wittsend.com/computone.html -S: Maintained - COSA/SRP SYNC SERIAL DRIVER P: Jan "Yenya" Kasprzak M: [email protected]
PATCH 1/1 Maintainers one entry removed
Maintainers one entry removed
Computone intelliport multiport card is no longer maintained. The maintainer doesn't respond to e-mails (3 times during 1 month). The page was updated 2 years ago and there is no other contact.
---
commit a6e455aea055d5c0bd9abd69fc0c40b41d76b993
tree 583e168ce727b57836064b2a0eb63326a1ef529e
parent ef1b647cf1a27b138123d31ab885b3e92cdbe4e9
author root <root@anemoi.(none)> Wed, 12 Oct 2005 18:33:10 +0200 committer root <root@anemoi.(none)> Wed, 12 Oct 2005 18:33:10 +0200
MAINTAINERS | 6 ------ 1 files changed, 0 insertions(+), 6 deletions(-)
MAINTAINERS +0 -6
@@ -580,12 +580,6 @@ M: [email protected] L: [email protected] S: Supported -COMPUTONE INTELLIPORT MULTIPORT CARD -P: Michael H. Warfield -M: [email protected] -W: http://www.wittsend.com/computone.html -S: Maintained - COSA/SRP SYNC SERIAL DRIVER P: Jan "Yenya" Kasprzak M: [email protected]
Re: [PATCH 2.6.14-rc4] Maintainers one entry removed
Quoted 8 lines · Jiri Slaby
Maintainers one entry removed
Computone intelliport multiport card is no longer maintained. The maintainer doesn't respond to e-mails (3 times during 1 month). The page was updated 2 years ago and there is no other contact.
Signed-off-by Jiri Slaby <[email protected]>
Rather than removing the entry entirely, wouldn't something like this be more appropriate?
MAINTAINERS +1 -4
@@ -581,10 +581,7 @@ L: [email protected] S: Supported COMPUTONE INTELLIPORT MULTIPORT CARD -P: Michael H. Warfield -M: [email protected] -W: http://www.wittsend.com/computone.html -S: Maintained +S: Orphaned COSA/SRP SYNC SERIAL DRIVER P: Jan "Yenya" Kasprzak
Re: [PATCH 2.6.14-rc4] Maintainers one entry removed
In reply to Jiri SlabyQuoted 5 lines · Jiri Slaby
Maintainers one entry removed
Computone intelliport multiport card is no longer maintained. The maintainer doesn't respond to e-mails (3 times during 1 month). The page was updated 2 years ago and there is no other contact.
Michael posted to fedora-list on October 1st and seems active. Have you allowed for the fact he might be away, busy or that you could be in his spam filters ?
Alan
A message that is not in the archive (sent off-list or not yet received): [email protected]
Re: [PATCH 2.6.14-rc4] Maintainers one entry removed
Quoted 4 lines · Jiri Slaby
Quoted 3 lines · Alan Cox
Quoted 2 lines · Jiri Slaby
Maintainers one entry removed
Quoted 8 lines
Quoted 7 lines
Quoted 3 lines
Computone intelliport multiport card is no longer maintained. The maintainer doesn't respond to e-mails (3 times during 1 month). The page was updated 2 years ago and there is no other contact.
Michael posted to fedora-list on October 1st and seems active. Have you allowed for the fact he might be away, busy or that you could be in his spam filters ?
So let's try his other e-mails, which I was not able to find before. Thanks.
I'm still here and still responding to [email protected]. You may have
gotten caught up in a spam filter. IAC... I don't recall getting any messages. I have had contact with others on that address and I posted to LKML back early this year that I was still alive after Andrew Morton chimed in that I was still around and WittsEnd was still around.
Quoted 5 lines
Hello Michael, is the Computone intelliport multiport card still maintained [and are you going to rewrite it to pci probing and the new api?] and/or [email protected] e-mail from
MAINTAINERSstill active (as Alan wrote, I could be at on your black-list). So could you reply and tell us?
You're not on a black list but CRM-114 may have caught you anyways.
I spoke with Andrew about the Computone driver when we were both
speaking at Linux Lunacy last week. I still intend to maintain it an I've been working on the 2.6 driver. I've got a spinlock problem that has me in a bind at the moment with the patches. I jokingly told Andrew that he would get the patch as soon as I shot this problem and I was not going to be like some people who sends him patches that don't even compile. :-)
I thought the PCI stuff was there. I'll look that over and see what
needs to be done. Got some pointers to docs on what I need to update for that? I was talking to Andrew about the spinlock problems but he didn't say anything about PCI probing. What's missing?
Quoted 5 lines
thanks,
--
Jiri Slaby www.fi.muni.cz/~xslaby
~\-/~ [email protected] ~\-/~
B67499670407CE62ACC8 22A032CC55C339D47A7E
Mike
Signature · 4 lines
Michael H. Warfield | (770) 985-6132 | [email protected] /\/\|=mhw=|\/\/ | (678) 463-0932 | http://www.wittsend.com/mhw/ NIC whois: MHW9 | An optimist believes we live in the best of all PGP Key: 0xDF1DD471 | possible worlds. A pessimist is sure of it!
Re: [PATCH 2.6.14-rc4] Maintainers one entry removed
Damn, I can't post nor to LKML now?
Quoted 7 lines · Michael H. Warfield
Quoted 5 lines
Hello Michael, is the Computone intelliport multiport card still maintained [and are you going to rewrite it to pci probing and the new api?] and/or [email protected] e-mail from
MAINTAINERSstill active (as Alan wrote, I could be at on your black-list). So could you reply and tell us?You're not on a black list but CRM-114 may have caught you anyways.
Grr.
Quoted 5 lines
I thought the PCI stuff was there. I'll look that over and see what
needs to be done. Got some pointers to docs on what I need to update for that? I was talking to Andrew about the spinlock problems but he didn't say anything about PCI probing. What's missing?
I wrote it badly. The driver is written old-styled with pci_find_device function, which Greg KH wants to eliminate from the kernel. The way how to do it is to rewrite the driver to PCI hotplug (not as much work). The code needs to be splitted, some for loops would go away, you will get an event, when the device, you decribe in pci_tbl, is in the system.
regards,
--
Jiri Slaby www.fi.muni.cz/~xslaby
~\-/~ [email protected] ~\-/~
B67499670407CE62ACC8 22A032CC55C339D47A7E
Re: [PATCH 2.6.14-rc4] Maintainers one entry removed
From: Jiri Slaby <[email protected]>
Date: Wed, 12 Oct 2005 22:09:39 +0200
Quoted 1 line
Damn, I can't post nor to LKML now?
If you're using gmail to send, probably you can't. It's using various encoding types, such as HTML, that we filter out here as %99 of that is spam.
Re: [PATCH 2.6.14-rc4] Maintainers one entry removed
In reply to a message not in the archiveQuoted 11 lines · Jiri Slaby
Quoted 10 lines · Alan Cox
Quoted 5 lines · Jiri Slaby
Maintainers one entry removed
Computone intelliport multiport card is no longer maintained. The maintainer doesn't respond to e-mails (3 times during 1 month). The page was updated 2 years ago and there is no other contact.
Michael posted to fedora-list on October 1st and seems active. Have you allowed for the fact he might be away, busy or that you could be in his spam filters ?
Quoted 7 lines
So let's try his other e-mails, which I was not able to find before. Thanks.
Hello Michael, is the Computone intelliport multiport card still maintained [and are you going to rewrite it to pci probing and the new api?] and/or [email protected] e-mail from
MAINTAINERSstill active (as Alan wrote, I could be at on your black-list). So could you reply and tell us?
Ah... Found out what happened. They weren't getting dumped in a spam
folder (unless you consider LKML a spam folder :-) ). All of your messages included LKML in the cc and my procmail scripts obligingly dumped all of them in my LKML folder. And I'm just a few thousand messages behind on that one ATM. :-( Sorry about that. On it now. Guess I need to "fine tune" that procmail receipe.
Quoted 5 lines
thanks,
--
Jiri Slaby www.fi.muni.cz/~xslaby
~\-/~ [email protected] ~\-/~
B67499670407CE62ACC8 22A032CC55C339D47A7E
Signature · 4 lines
Michael H. Warfield | (770) 985-6132 | [email protected] /\/\|=mhw=|\/\/ | (678) 463-0932 | http://www.wittsend.com/mhw/ NIC whois: MHW9 | An optimist believes we live in the best of all PGP Key: 0xDF1DD471 | possible worlds. A pessimist is sure of it!
Re: [PATCH 1/10] drivers/char: pci_find_device remove (drivers/char/ip2main.c)
In reply to Jiri SlabyQuoted 17 lines · Jiri Slaby
Signed-off-by Jiri Slaby <[email protected]>ip2main.c | 8 +++++--- 1 files changed, 5 insertions(+), 3 deletions(-)drivers/char/ip2main.c +1
-0@@ -442,6 +442,7 @@ cleanup_module(void)#ifdef CONFIG_PCI if (ip2config.type[i] ==PCI && ip2config.pci_dev[i]) {pci_disable_device (ip2config.pci_dev[i]); +pci_dev_put (ip2config.pci_dev[i]); ip2config.pci_dev[i] =NULL ; }#endif
drivers/char/ip2main.c ip2_loadmain(int *iop, int *irqp, unsign · line 601
Quoted 10 lines
drivers/char/ip2main.c +4
-3@@ -594,9 +595,10 @@ ip2_loadmain(int *iop, int *irqp, unsigncase PCI :#ifdef CONFIG_PCI { -struct pci_dev *pci_dev_i =NULL ; - pci_dev_i =pci_find_device (PCI_VENDOR_ID_COMPUTONE , -PCI_DEVICE_ID_COMPUTONE_IP2EX , pci_dev_i); +struct pci_dev *pci_dev_i; + pci_dev_i =pci_get_device ( +PCI_VENDOR_ID_COMPUTONE , +PCI_DEVICE_ID_COMPUTONE_IP2EX ,NULL );
convert to PCI probing
PATCH 2/10 drivers/char: pci_find_device remove (drivers/char/istallion.c)
In reply to Jiri Slabyistallion.c | 9 +++++---- 1 files changed, 5 insertions(+), 4 deletions(-)
drivers/char/istallion.c +5 -4
@@ -4602,11 +4602,12 @@ static int stli_findpcibrds(void)printk ("stli_findpcibrds()\n" );#endif -while ((dev =pci_find_device (PCI_VENDOR_ID_STALLION , -PCI_DEVICE_ID_ECRA , dev))) { -if ((rc =stli_initpcibrd (BRD_ECPPCI , dev))) +while ((dev =pci_get_device (PCI_VENDOR_ID_STALLION , +PCI_DEVICE_ID_ECRA , dev))) +if ((rc =stli_initpcibrd (BRD_ECPPCI , dev))) { +pci_dev_put (dev);return (rc); - } + }return (0 ); }
PATCH 3/10 drivers/char: pci_find_device remove (drivers/char/mxser.c)
In reply to Jiri Slabymxser.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletion(-)
drivers/char/mxser.c +2 -1
@@ -511,6 +511,7 @@ static void __exit mxser_module_exit(voiif (pdev !=NULL ) {//PCI release_region (pci_resource_start (pdev,2 ),pci_resource_len (pdev,2 ));release_region (pci_resource_start (pdev,3 ),pci_resource_len (pdev,3 )); +pci_dev_put (pdev); }else {release_region (mxsercfg[i].ioaddr[0 ],8 * mxsercfg[i].ports);release_region (mxsercfg[i].vector,1 );
@@ -831,7 +832,7 @@ static int mxser_init(void) index =0 ; b =0 ;while (b < n) { - pdev =pci_find_device (mxser_pcibrds[b].vendor, mxser_pcibrds[b].device, pdev); + pdev =pci_get_device (mxser_pcibrds[b].vendor, mxser_pcibrds[b].device, pdev);if (pdev ==NULL ) { b++;continue ;
PATCH 4/10 drivers/char: pci_find_device remove (drivers/char/rocket.c)
In reply to Jiri Slabyrocket.c | 2 +- 1 files changed, 1 insertion(+), 1 deletion(-)
drivers/char/rocket.c +1 -1
@@ -2234,7 +2234,7 @@ static int __init init_PCI(int boards_foint count =0 ;/* Work through the PCI device list, pulling out ours */ -while ((dev =pci_find_device (PCI_VENDOR_ID_RP ,PCI_ANY_ID , dev))) { +while ((dev =pci_get_device (PCI_VENDOR_ID_RP ,PCI_ANY_ID , dev))) {if (register_PCI (count + boards_found, dev)) count++; }
Re: [PATCH 4/10] drivers/char: pci_find_device remove (drivers/char/rocket.c)
drivers/char/rocket.c static int __init init_PCI(int boards_fo · line 2239
Quoted 11 lines · Jiri Slaby
drivers/char/rocket.c +1
-1@@ -2234,7 +2234,7 @@ static int __init init_PCI(int boards_foint count =0 ;/* Work through the PCI device list, pulling out ours */ -while ((dev =pci_find_device (PCI_VENDOR_ID_RP ,PCI_ANY_ID , dev))) { +while ((dev =pci_get_device (PCI_VENDOR_ID_RP ,PCI_ANY_ID , dev))) {if (register_PCI (count + boards_found, dev)) count++;
convert to PCI probing, rather than this
Jeff
PATCH 5/10 drivers/char: pci_find_device remove (drivers/char/specialix.c)
In reply to Jiri Slabyspecialix.c | 9 ++++++--- 1 files changed, 6 insertions(+), 3 deletions(-)
drivers/char/specialix.c +6 -3
@@ -2502,9 +2502,9 @@ static int __init specialix_init(void) i++;continue ; } - pdev =pci_find_device (PCI_VENDOR_ID_SPECIALIX , -PCI_DEVICE_ID_SPECIALIX_IO8 , - pdev); + pdev =pci_get_device (PCI_VENDOR_ID_SPECIALIX , +PCI_DEVICE_ID_SPECIALIX_IO8 , + pdev);if (!pdev)break ;if (pci_enable_device (pdev))
@@ -2517,7 +2517,10 @@ static int __init specialix_init(void) sx_board[i].flags |=SX_BOARD_IS_PCI ;if (!sx_probe (&sx_board[i])) found ++; + } +if (i >=SX_NBOARD ) +pci_dev_put (pdev); }#endif
Re: [PATCH 5/10] drivers/char: pci_find_device remove (drivers/char/specialix.c)
Jiri Slaby napsal(a):
Quoted 34 lines
Signed-off-by Jiri Slaby <[email protected]>
specialix.c| 9 ++++++---1 files changed, 6 insertions(+), 3 deletions(-)drivers/char/specialix.c +6
-3@@ -2502,9 +2502,9 @@ static int __init specialix_init(void) i++;continue ; } - pdev =pci_find_device (PCI_VENDOR_ID_SPECIALIX , -PCI_DEVICE_ID_SPECIALIX_IO8 , - pdev); + pdev =pci_get_device (PCI_VENDOR_ID_SPECIALIX , +PCI_DEVICE_ID_SPECIALIX_IO8 , + pdev);if (!pdev)break ;if (pci_enable_device (pdev))@@ -2517,7 +2517,10 @@ static int __init specialix_init(void) sx_board[i].flags |=SX_BOARD_IS_PCI ;if (!sx_probe (&sx_board[i])) found ++; + } +if (i >=SX_NBOARD ) +pci_dev_put (pdev); }#endif
Re: [PATCH 5/10] drivers/char: pci_find_device remove (drivers/char/specialix.c)
Quoted 1 line · Jiri Slaby
Cc [email protected] [maintainer]
Hello.
Is drivers/char/ip2main.c still maintained? Are you going to rewrite this driver to 2.6 API (PCI probing etc.)?
thanks,
--
Jiri Slaby www.fi.muni.cz/~xslaby
~\-/~ [email protected] ~\-/~
241B347EC88228DE51EE A49C4A73A25004CB2A10
Re: [PATCH 5/10] drivers/char: pci_find_device remove (drivers/char/specialix.c)
In reply to Jiri SlabyQuoted 22 lines · Jiri Slaby
Signed-off-by Jiri Slaby <[email protected]>specialix.c | 9 ++++++--- 1 files changed, 6 insertions(+), 3 deletions(-)drivers/char/specialix.c +3
-3@@ -2502,9 +2502,9 @@ static int __init specialix_init(void) i++;continue ; } - pdev =pci_find_device (PCI_VENDOR_ID_SPECIALIX , -PCI_DEVICE_ID_SPECIALIX_IO8 , - pdev); + pdev =pci_get_device (PCI_VENDOR_ID_SPECIALIX , +PCI_DEVICE_ID_SPECIALIX_IO8 , + pdev);if (!pdev)break ;if (pci_enable_device (pdev))
drivers/char/specialix.c static int __init specialix_init(void) · line 2523
Quoted 7 lines
drivers/char/specialix.c +3
-0@@ -2517,7 +2517,10 @@ static int __init specialix_init(void) sx_board[i].flags |=SX_BOARD_IS_PCI ;if (!sx_probe (&sx_board[i])) found ++; + } +if (i >=SX_NBOARD ) +pci_dev_put (pdev);
should be converted to PCI probing, rather than this.
Jeff
Re: [PATCH 5/10] drivers/char: pci_find_device remove (drivers/char/specialix.c)
Jeff Garzik napsal(a):
Quoted 22 lines
Quoted 20 lines · Jiri Slaby
Signed-off-by Jiri Slaby <[email protected]>specialix.c | 9 ++++++--- 1 files changed, 6 insertions(+), 3 deletions(-)drivers/char/specialix.c +3
-3@@ -2502,9 +2502,9 @@ static int __init specialix_init(void) i++;continue ; } - pdev =pci_find_device (PCI_VENDOR_ID_SPECIALIX , -PCI_DEVICE_ID_SPECIALIX_IO8 , - pdev); + pdev =pci_get_device (PCI_VENDOR_ID_SPECIALIX , +PCI_DEVICE_ID_SPECIALIX_IO8 , + pdev);if (!pdev)break ;
Quoted 12 lines
drivers/char/specialix.c static int __init specialix_init(void) · line 2523
Quoted 9 lines
drivers/char/specialix.c +3
-0if (pci_enable_device (pdev))@@ -2517,7 +2517,10 @@ static int __init specialix_init(void) sx_board[i].flags |=SX_BOARD_IS_PCI ;if (!sx_probe (&sx_board[i])) found ++; + } +if (i >=SX_NBOARD ) +pci_dev_put (pdev);should be converted to PCI probing, rather than this.
I won't do that, i did that for 2 drivers and nobody was interested in that (and its much time left for nothing). These (unrewritten) drivers would be deleted in some time. Greg wants simply wipe this function out.
regards,
Signature · 3 lines
Jiri Slaby www.fi.muni.cz/~xslaby ~\-/~ [email protected] ~\-/~ 241B347EC88228DE51EE A49C4A73A25004CB2A10
Re: [PATCH 5/10] drivers/char: pci_find_device remove (drivers/char/specialix.c)
Quoted 35 lines · Jiri Slaby
Jeff Garzik napsal(a):
Quoted 22 lines
Quoted 20 lines · Jiri Slaby
Signed-off-by Jiri Slaby <[email protected]>
specialix.c| 9 ++++++---1 files changed, 6 insertions(+), 3 deletions(-)drivers/char/specialix.c +3
-3@@ -2502,9 +2502,9 @@ static int __init specialix_init(void) i++;continue ; } - pdev =pci_find_device (PCI_VENDOR_ID_SPECIALIX , -PCI_DEVICE_ID_SPECIALIX_IO8 , - pdev); + pdev =pci_get_device (PCI_VENDOR_ID_SPECIALIX , +PCI_DEVICE_ID_SPECIALIX_IO8 , + pdev);if (!pdev)break ;Quoted 12 lines
drivers/char/specialix.c static int __init specialix_init(void) · line 2523
Quoted 9 lines
drivers/char/specialix.c +3
-0if (pci_enable_device (pdev))@@ -2517,7 +2517,10 @@ static int __init specialix_init(void) sx_board[i].flags |=SX_BOARD_IS_PCI ;if (!sx_probe (&sx_board[i])) found ++; + } +if (i >=SX_NBOARD ) +pci_dev_put (pdev);should be converted to PCI probing, rather than this.
Quoted 3 lines
I won't do that, i did that for 2 drivers and nobody was interested in that (and its much time left for nothing). These (unrewritten) drivers would be deleted in some time. Greg wants simply wipe this function out.
No, I want it done correctly. If I simply wanted the function removed, I would have done this kind of wholesale conversion a long time ago.
If the code needs to be converted to the proper pci probing logic, that's the better way to do it, and that's what should be done.
thanks,
greg k-h
Re: [PATCH 5/10] drivers/char: pci_find_device remove (drivers/char/specialix.c)
Greg KH napsal(a):
Quoted 40 lines · Jiri Slaby
Quoted 39 lines
Jeff Garzik napsal(a):
Quoted 35 lines
Quoted 22 lines · Jiri Slaby
Signed-off-by Jiri Slaby <[email protected]>
specialix.c| 9 ++++++---1 files changed, 6 insertions(+), 3 deletions(-)drivers/char/specialix.c +3
-3@@ -2502,9 +2502,9 @@ static int __init specialix_init(void) i++;continue ; } - pdev =pci_find_device (PCI_VENDOR_ID_SPECIALIX , -PCI_DEVICE_ID_SPECIALIX_IO8 , - pdev); + pdev =pci_get_device (PCI_VENDOR_ID_SPECIALIX , +PCI_DEVICE_ID_SPECIALIX_IO8 , + pdev);if (!pdev)break ;if (pci_enable_device (pdev))drivers/char/specialix.c static int __init specialix_init(void) · line 2523
Quoted 7 lines
drivers/char/specialix.c +3
-0@@ -2517,7 +2517,10 @@ static int __init specialix_init(void) sx_board[i].flags |=SX_BOARD_IS_PCI ;if (!sx_probe (&sx_board[i])) found ++; + } +if (i >=SX_NBOARD ) +pci_dev_put (pdev);should be converted to PCI probing, rather than this.
Quoted 8 lines
Quoted 1 line
I won't do that, i did that for 2 drivers and nobody was interested in that (and its much time left for nothing). These (unrewritten) drivers would be deleted in some time. Greg wants simply wipe this function out.
No, I want it done correctly. If I simply wanted the function removed, I would have done this kind of wholesale conversion a long time ago.
If the code needs to be converted to the proper pci probing logic, that's the better way to do it, and that's what should be done.
I think so too, but some drivers, that uses pci_find_device are broken for a long time and nobody uses it at all.
So what should I do? I want others not to use pci_find_device furthermore, so I sent patch that marks it deprecated. Greg sent, that he wants to remove them and wants to kill 'em all from the tree. When I rewrote the 2 drivers, nobody wanted to test them and nobody acked them, nobody did anything. So:
a) rewrite non-broken drivers, the rest kill (or not to kill, only mark find as deprecated and let them live for some next time)
b) rewrite all
c) change find to get + dev_put
d) others: ................
[What about oss drivers?]
So, Greg and Jeff, your opinions?
thanks,
Signature · 3 lines
Jiri Slaby www.fi.muni.cz/~xslaby ~\-/~ [email protected] ~\-/~ 241B347EC88228DE51EE A49C4A73A25004CB2A10
Re: [PATCH 5/10] drivers/char: pci_find_device remove (drivers/char/specialix.c)
Quoted 56 lines · Jiri Slaby
Greg KH napsal(a):
Quoted 46 lines · Jiri Slaby
Quoted 41 lines
Jeff Garzik napsal(a):
Quoted 23 lines
Quoted 20 lines · Jiri Slaby
Signed-off-by Jiri Slaby <[email protected]>
specialix.c| 9 ++++++---1 files changed, 6 insertions(+), 3 deletions(-)drivers/char/specialix.c +3
-3@@ -2502,9 +2502,9 @@ static int __init specialix_init(void) i++;continue ; } - pdev =pci_find_device (PCI_VENDOR_ID_SPECIALIX , -PCI_DEVICE_ID_SPECIALIX_IO8 , - pdev); + pdev =pci_get_device (PCI_VENDOR_ID_SPECIALIX , +PCI_DEVICE_ID_SPECIALIX_IO8 , + pdev);if (!pdev)break ;Quoted 13 lines
drivers/char/specialix.c static int __init specialix_init(void) · line 2523
Quoted 9 lines
drivers/char/specialix.c +3
-0if (pci_enable_device (pdev))@@ -2517,7 +2517,10 @@ static int __init specialix_init(void) sx_board[i].flags |=SX_BOARD_IS_PCI ;if (!sx_probe (&sx_board[i])) found ++; + } +if (i >=SX_NBOARD ) +pci_dev_put (pdev);should be converted to PCI probing, rather than this.
Quoted 1 line
I won't do that, i did that for 2 drivers and nobody was interested in that (and its much time left for nothing). These (unrewritten) drivers would be deleted in some time. Greg wants simply wipe this function out.
Quoted 5 lines
No, I want it done correctly. If I simply wanted the function removed, I would have done this kind of wholesale conversion a long time ago.
If the code needs to be converted to the proper pci probing logic, that's the better way to do it, and that's what should be done.
I think so too, but some drivers, that uses
pci_find_deviceare broken for a long time and nobody uses it at all.
Quoted 8 lines
So what should I do? I want others not to use
pci_find_devicefurthermore, so I sent patch that marks it deprecated. Greg sent, that he wants to remove them and wants to kill 'em all from the tree. When I rewrote the 2 drivers, nobody wanted to test them and nobody acked them, nobody did anything. So:
a) rewrite non-broken drivers, the rest kill (or not to kill, only mark find as deprecated and let them live for some next time)
b) rewrite all
c) change find to get +dev_put
d) others: ................
[What about oss drivers?]So, Greg and Jeff, your opinions?
If the drivers aren't used or maintained, remove them from the kernel tree.
Jeff
PATCH 1/1 (i)stallion remove
Quoted 1 line · Jeff Garzik
If the drivers aren't used or maintained, remove them from the kernel tree.
So, this as a first:
(I)stallion remove from the tree, it contains pci_find_device, it is unmaintained and broken for a long time. Noone uses it.
Generated in 2.6.13-mm2 kernel version. [Applicable also on 2.6.13-git10]
Documentation/stallion.txt | 392 --
Documentation/00-INDEX | 2 Documentation/devices.txt | 31 Documentation/magic-number.txt | 5 drivers/char/Kconfig | 22 drivers/char/Makefile | 2 drivers/char/istallion.c | 5275 --------------------------------------- drivers/char/stallion.c | 5197 -------------------------------------- include/linux/istallion.h | 132 include/linux/stallion.h | 154 - 10 files changed, 11212 deletions(-)
Patch is here for its size (300 KiB):
http://www.fi.muni.cz/~xslaby/lnx/stallion.txt
Signature · 3 lines
Jiri Slaby www.fi.muni.cz/~xslaby ~\-/~ [email protected] ~\-/~ 241B347EC88228DE51EE A49C4A73A25004CB2A10
Re: [PATCH] (i)stallion remove
Quoted 9 lines · Jiri Slaby
Quoted 2 lines · Jeff Garzik
If the drivers aren't used or maintained, remove them from the kernel tree.
So, this as a first:
(I)stallion remove from the tree, it contains
pci_find_device, it is unmaintained and broken for a long time. Noone uses it.
Its still on my hitlist - I'm slowly fixing them all
Re: [PATCH] (i)stallion remove
Quoted 6 lines · Alan Cox
Quoted 5 lines · Jiri Slaby
Quoted 2 lines · Jeff Garzik
If the drivers aren't used or maintained, remove them from the kernel tree.
Quoted 8 lines
Quoted 4 lines
So, this as a first:
(I)stallion remove from the tree, it contains
pci_find_device, it is unmaintained and broken for a long time. Noone uses it.Nak-by Alan Cox <[email protected]>Its still on my hitlist - I'm slowly fixing them all
Are you converting them to the new serial infrastructure at the same time?
Re: [PATCH] (i)stallion remove
Quoted 6 lines · Matthew Wilcox
Quoted 3 lines
Nak-by Alan Cox <[email protected]>Its still on my hitlist - I'm slowly fixing them all
Are you converting them to the new serial infrastructure at the same time?
No.. I thought I'd be old fashioned and know why they broke by doing one thing at a time 8)
Some of these controllers would fit the serial infrastructure, others have interesting locking (ISA window mapping for example) or DMA/polling interfaces that don't yet seem to fit.
Alan
Re: [PATCH] (i)stallion remove
In reply to Jiri SlabyQuoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Jiri" == Jiri Slaby <[email protected]> writes:
Jiri> (I)stallion remove from the tree, it contains pci_find_device, Jiri> it is unmaintained and broken for a long time. Noone uses it.
Arrrg! We're using it! It works on UP ia64. If you want to remove it, please send us a supported 8-port serial card :-)
Signature · 2 lines
Dr Peter Chubb http://www.gelato.unsw.edu.au peterc AT gelato.unsw.edu.au The technical we do immediately, the political takes *forever*
Re: [PATCH] (i)stallion remove
Peter Chubb napsal(a):
Quoted 9 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Jiri" == Jiri Slaby <[email protected]> writes:
Jiri> (I)stallion remove from the tree, it contains
pci_find_device, Jiri> it is unmaintained and broken for a long time. Noone uses it.Arrrg! We're using it! It works on UP ia64. If you want to remove it, please send us a supported 8-port serial card :-)
No, i don't want to do it (neither remove, nor send :) ).
regards,
Signature · 3 lines
Jiri Slaby www.fi.muni.cz/~xslaby ~\-/~ [email protected] ~\-/~ 241B347EC88228DE51EE A49C4A73A25004CB2A10
Re: [PATCH] (i)stallion remove
In reply to Peter ChubbQuoted 7 lines · Peter Chubb
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Jiri" == Jiri Slaby <[email protected]> writes:
Jiri> (I)stallion remove from the tree, it contains
pci_find_device, Jiri> it is unmaintained and broken for a long time. Noone uses it.Arrrg! We're using it! It works on UP ia64. If you want to remove it, please send us a supported 8-port serial card :-)
At least we found a tester now. With this message you just signed up voluntarily to test a version that brings the driver into the 21st century ;-)
Re: [PATCH 5/10] drivers/char: pci_find_device remove (drivers/char/specialix.c)
In reply to Greg KHGreg KH napsal(a):
Quoted 10 lines
Quoted 3 lines
I won't do that, i did that for 2 drivers and nobody was interested in that (and its much time left for nothing). These (unrewritten) drivers would be deleted in some time. Greg wants simply wipe this function out.
No, I want it done correctly. If I simply wanted the function removed, I would have done this kind of wholesale conversion a long time ago.
If the code needs to be converted to the proper pci probing logic, that's the better way to do it, and that's what should be done.
Okay, could you reply the letter i posted a few seconds ago.
thanks,
Signature · 3 lines
Jiri Slaby www.fi.muni.cz/~xslaby ~\-/~ [email protected] ~\-/~ 241B347EC88228DE51EE A49C4A73A25004CB2A10
PATCH 6/10 drivers/char: pci_find_device remove (drivers/char/stallion.c)
In reply to Jiri Slabystallion.c | 6 ++++-- 1 files changed, 4 insertions(+), 2 deletions(-)
drivers/char/stallion.c +4 -2
@@ -2726,7 +2726,7 @@ static inline int stl_findpcibrds(void)#endif for (i =0 ; (i < stl_nrpcibrds); i++) -while ((dev =pci_find_device (stl_pcibrds[i].vendid, +while ((dev =pci_get_device (stl_pcibrds[i].vendid, stl_pcibrds[i].devid, dev))) {/*
@@ -2737,8 +2737,10 @@ static inline int stl_findpcibrds(void)continue ; rc =stl_initpcibrd (stl_pcibrds[i].brdtype, dev); -if (rc) +if (rc) { +pci_dev_put (dev);return (rc); + } }return (0 );
Re: [PATCH 6/10] drivers/char: pci_find_device remove (drivers/char/stallion.c)
Quoted 7 lines · Jiri Slaby
drivers/char/stallion.c +1
-1for (i =0 ; (i < stl_nrpcibrds); i++) -while ((dev =pci_find_device (stl_pcibrds[i].vendid, +while ((dev =pci_get_device (stl_pcibrds[i].vendid, stl_pcibrds[i].devid, dev))) {/*
drivers/char/stallion.c static inline int stl_findpcibrds(void) · line 2743
Quoted 8 lines
drivers/char/stallion.c +3
-1@@ -2737,8 +2737,10 @@ static inline int stl_findpcibrds(void)continue ; rc =stl_initpcibrd (stl_pcibrds[i].brdtype, dev); -if (rc) +if (rc) { +pci_dev_put (dev);return (rc); + }
convert to PCI probing
Jeff
PATCH 7/10 drivers/char: pci_find_device remove (drivers/char/sx.c)
In reply to Jiri Slabysx.c | 2 +- 1 files changed, 1 insertion(+), 1 deletion(-)
drivers/char/sx.c +1 -1
@@ -2434,7 +2434,7 @@ static int __init sx_init(void) }#ifdef CONFIG_PCI -while ((pdev =pci_find_device (PCI_VENDOR_ID_SPECIALIX , +while ((pdev =pci_get_device (PCI_VENDOR_ID_SPECIALIX ,PCI_DEVICE_ID_SPECIALIX_SX_XIO_IO8 , pdev))) {if (pci_enable_device (pdev))
PATCH 8/10 drivers/char: pci_find_device remove (drivers/char/watchdog/alim1535_wdt.c)
In reply to Jiri Slabyalim1535_wdt.c | 12 +++++++++--- 1 files changed, 9 insertions(+), 3 deletions(-)
drivers/char/watchdog/alim1535_wdt.c +9 -3
@@ -330,17 +330,20 @@ static int __init ali_find_watchdog(voidu32 wdog;/* Check for a 1535 series bridge */ - pdev =pci_find_device (PCI_VENDOR_ID_AL ,0x1535 ,NULL ); + pdev =pci_get_device (PCI_VENDOR_ID_AL ,0x1535 ,NULL );if (pdev ==NULL )return -ENODEV ; +pci_dev_put (pdev);/* Check for the a 7101 PMU */ - pdev =pci_find_device (PCI_VENDOR_ID_AL ,0x7101 ,NULL ); + pdev =pci_get_device (PCI_VENDOR_ID_AL ,0x7101 ,NULL );if (pdev ==NULL )return -ENODEV ; -if (pci_enable_device (pdev)) +if (pci_enable_device (pdev)) { +pci_dev_put (pdev);return -EIO ; + } ali_pci = pdev;
@@ -392,6 +395,8 @@ static int __init watchdog_init(void) {int ret; + ali_pci =NULL ; +spin_lock_init (&ali_lock);/* Check whether or not the hardware watchdog is there */
@@ -445,6 +450,7 @@ static void __exit watchdog_exit(void)ali_stop ();/* Deregister */ +pci_dev_put (ali_pci);unregister_reboot_notifier (&ali_notifier);misc_deregister (&ali_miscdev); }
PATCH 9/10 drivers/char: pci_find_device remove (drivers/char/watchdog/alim7101_wdt.c)
In reply to Jiri Slabyalim7101_wdt.c | 9 +++++++-- 1 files changed, 7 insertions(+), 2 deletions(-)
drivers/char/watchdog/alim7101_wdt.c +7 -2
@@ -333,6 +333,8 @@ static void __exit alim7101_wdt_unload(v/* Deregister */ misc_deregister (&wdt_miscdev);unregister_reboot_notifier (&wdt_notifier); + +pci_dev_put (alim7101_pmu); }static int __init alim7101_wdt_init (void )
@@ -342,7 +344,8 @@ static int __init alim7101_wdt_init(voidchar tmp; printk(KERN_INFO PFX "Steve Hill <[email protected]>.\n"); - alim7101_pmu =pci_find_device (PCI_VENDOR_ID_AL ,PCI_DEVICE_ID_AL_M7101 ,NULL ); + alim7101_pmu =pci_get_device (PCI_VENDOR_ID_AL ,PCI_DEVICE_ID_AL_M7101 , +NULL );if (!alim7101_pmu) { printk(KERN_INFO PFX "ALi M7101 PMU not present - WDT not set\n");return -EBUSY ;
@@ -351,12 +354,14 @@ static int __init alim7101_wdt_init(void/* Set the WDT in the PMU to 1 second */ pci_write_config_byte (alim7101_pmu,ALI_7101_WDT ,0x02 ); - ali1543_south =pci_find_device (PCI_VENDOR_ID_AL ,PCI_DEVICE_ID_AL_M1533 ,NULL ); + ali1543_south =pci_get_device (PCI_VENDOR_ID_AL ,PCI_DEVICE_ID_AL_M1533 , +NULL );if (!ali1543_south) { printk(KERN_INFO PFX "ALi 1543 South-Bridge not present - WDT not set\n");return -EBUSY ; }pci_read_config_byte (ali1543_south,0x5e , &tmp); +pci_dev_put (ali1543_south);if ((tmp &0x1e ) ==0x00 ) {if (!use_gpio) { printk(KERN_INFO PFX "Detected old alim7101 revision 'a1d'. If this is a cobalt board, set the 'use_gpio' module parameter.\n");
PATCH 10/10 drivers/char: pci_find_device remove (drivers/char/watchdog/i8xx_tco.c)
In reply to Jiri Slabyi8xx_tco.c | 5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-)
drivers/char/watchdog/i8xx_tco.c +3 -2
@@ -414,12 +414,11 @@ static unsigned char __init i8xx_tco_get* Find the PCI device */ -while ((dev =pci_find_device (PCI_ANY_ID ,PCI_ANY_ID , dev)) !=NULL ) { +for_each_pci_dev (dev)if (pci_match_id (i8xx_tco_pci_tbl, dev)) { i8xx_tco_pci = dev;break ; } - }if (i8xx_tco_pci) {/*
@@ -535,6 +534,8 @@ static void __exit watchdog_cleanup (voimisc_deregister (&i8xx_tco_miscdev);unregister_reboot_notifier (&i8xx_tco_notifier);release_region (TCOBASE ,0x10 ); + +pci_dev_put (i8xx_tco_pci); }module_init (watchdog_init);
Re: [PATCH 10/10] drivers/char: pci_find_device remove (drivers/char/watchdog/i8xx_tco.c)
Jiri Slaby napsal(a):
Quoted 33 lines
Signed-off-by Jiri Slaby <[email protected]>
i8xx_tco.c| 5 +++--1 files changed, 3 insertions(+), 2 deletions(-)drivers/char/watchdog/i8xx_tco.c +3
-2@@ -414,12 +414,11 @@ static unsigned char __init i8xx_tco_get* Find the PCI device */ -while ((dev =pci_find_device (PCI_ANY_ID ,PCI_ANY_ID , dev)) !=NULL ) { +for_each_pci_dev (dev)if (pci_match_id (i8xx_tco_pci_tbl, dev)) { i8xx_tco_pci = dev;break ; } - }if (i8xx_tco_pci) {/* @@ -535,6 +534,8 @@ static void __exit watchdog_cleanup (voimisc_deregister (&i8xx_tco_miscdev);unregister_reboot_notifier (&i8xx_tco_notifier);release_region (TCOBASE ,0x10 ); + +pci_dev_put (i8xx_tco_pci); }module_init (watchdog_init);
Re: [PATCH 10/10] drivers/char: pci_find_device remove (drivers/char/watchdog/i8xx_tco.c)
Thanks, looks fine to me so I added my signed-off.
Quoted 5 lines · Jiri Slaby
Cc [email protected] [maintainer]Jiri Slaby napsal(a):
Quoted 1 line
Signed-off-by Jiri Slaby <[email protected]>
Quoted 30 lines
Quoted 30 lines
i8xx_tco.c| 5 +++--1 files changed, 3 insertions(+), 2 deletions(-)drivers/char/watchdog/i8xx_tco.c +1
-2@@ -414,12 +414,11 @@ static unsigned char __init i8xx_tco_get* Find the PCI device */ -while ((dev =pci_find_device (PCI_ANY_ID ,PCI_ANY_ID , dev)) != NULL) { +for_each_pci_dev (dev)if (pci_match_id (i8xx_tco_pci_tbl, dev)) { i8xx_tco_pci = dev;break ; } - }if (i8xx_tco_pci) {/*drivers/char/watchdog/i8xx_tco.c +2
-0@@ -535,6 +534,8 @@ static void __exit watchdog_cleanup (voimisc_deregister (&i8xx_tco_miscdev);unregister_reboot_notifier (&i8xx_tco_notifier);release_region (TCOBASE ,0x10 ); + +pci_dev_put (i8xx_tco_pci); }
Quoted 4 lines
drivers/char/watchdog/i8xx_tco.c static void __exit watchdog_cleanup (voi · line 541
Quoted 3 lines
drivers/char/watchdog/i8xx_tco.c +0
-0module_init (watchdog_init);
Cheers
nils faerber
Signature · 4 lines
kernel concepts Tel: +49-271-771091-12 Dreisbachstr. 24 Fax: +49-271-771091-19 D-57250 Netphen Mob: +49-176-21024535 --
Re: [PATCH 10/10] drivers/char: pci_find_device remove (drivers/char/watchdog/i8xx_tco.c)
In reply to Jiri Slabydrivers/char/watchdog/i8xx_tco.c static unsigned char __init i8xx_tco_get · line 422
Quoted 10 lines · Jiri Slaby
drivers/char/watchdog/i8xx_tco.c +1
-2-while ((dev =pci_find_device (PCI_ANY_ID ,PCI_ANY_ID , dev)) !=NULL ) { +for_each_pci_dev (dev)if (pci_match_id (i8xx_tco_pci_tbl, dev)) { i8xx_tco_pci = dev;break ; } - }
Surely there is a better way to handle bridge matching?
Jeff
Re: [PATCH 10/10] drivers/char: pci_find_device remove (drivers/char/watchdog/i8xx_tco.c)
Le Sat, 10 Sep 2005 16:58:49 -0400, Jeff Garzik a écrit :
Quoted 15 lines
drivers/char/watchdog/i8xx_tco.c static unsigned char __init i8xx_tco_get · line 422
Quoted 10 lines · Jiri Slaby
drivers/char/watchdog/i8xx_tco.c +1
-2-while ((dev =pci_find_device (PCI_ANY_ID ,PCI_ANY_ID , dev)) !=NULL ) { +for_each_pci_dev (dev)if (pci_match_id (i8xx_tco_pci_tbl, dev)) { i8xx_tco_pci = dev;break ; } - }Surely there is a better way to handle bridge matching?
That what is already done in drivers/char/hw_random.c ...