Skip to contentSkip to conversation

Another iptables-save buglet

PATCH Applied Tom Eastep 2 participants 2 messages Sep 14, 2005 – Sep 19, 2005 netfilter

lore
Share & tools
lore

Tom Eastep

author
#0 lore raw

PATCH 1/1 Another iptables-save buglet

The conntrack match extension doesn't handle address inversion correctly.

Patch attached.
-Tom

Signature · 4 lines
Tom Eastep    \ Nothing is foolproof to a sufficiently talented fool
Shoreline,     \ http://shorewall.net
Washington USA  \ [email protected]
PGP Public Key   \ https://lists.shorewall.net/teastep.pgp.key
extensions/libipt_conntrack.c renamed from extensions/libipt_conntrack.c~ +2 -2
@@ -414,8 +414,8 @@
 {
 	char buf[BUFSIZ];
 
-        if (inv)
-               	fputc('!', stdout);
+        if (inv) 
+               	printf("! ");
 
 	if (mask->s_addr == 0L && !numeric)
 		printf("%s ", "anywhere");
Applied
#1 lore raw
Quoted 1 line · Tom Eastep

The conntrack match extension doesn't handle address inversion correctly.

Thanks, applied.

Signature · 5 lines
- Harald Welte <[email protected]>                 http://netfilter.org/
============================================================================
  "Fragmentation is like classful addressing -- an interesting early
   architectural error that shows how much experimentation was going
   on while IP was being designed."                    -- Paul Vixie