Skip to contentSkip to conversation

vfs: global namespace semaphore

RFC PATCH In review Ram 3 participants 4 messages Sep 16, 2005 – Sep 20, 2005 VFS

lore
Share & tools
lore

Ram

author
#0 lore raw

RFC PATCH 4/10 vfs: global namespace semaphore

This patch removes the per-namespace semaphore in favor of a global semaphore. This can have an effect on namespace scalability.

 fs/namespace.c            |   44 ++++++++++++++++++++++----------------------
 include/linux/namespace.h |    1 -
 2 files changed, 22 insertions(+), 23 deletions(-)
include/linux/namespace.h +0 -1
Index: 2.6.13.sharedsubtree/include/linux/namespace.h
===================================================================
@@ -7,11 +7,10 @@
 
 struct namespace {
 	atomic_t		count;
 	struct vfsmount *	root;
 	struct list_head	list;
-	struct rw_semaphore	sem;
 };
 
 extern int copy_namespace(int, struct task_struct *);
 extern void __put_namespace(struct namespace *namespace);
 
fs/namespace.c +22 -22

240 lines not on this page · raw message

#1 lore raw
Quoted 2 lines · Ram

This patch removes the per-namespace semaphore in favor of a global semaphore. This can have an effect on namespace scalability.

... and #2 uses that semaphore...

author
#2 lore raw
Quoted 5 lines · Al Viro
Quoted 2 lines · Ram

This patch removes the per-namespace semaphore in favor of a global semaphore. This can have an effect on namespace scalability.

... and #2 uses that semaphore...

Patch #2, uses the global semaphore. Yes that patch would'nt have compiled without patch #4, because the global semaphore got defined only in the patch #4.

RP

#3 lore raw
Quoted 12 lines · Ram Pai
Quoted 5 lines · Al Viro
Quoted 2 lines · Ram

This patch removes the per-namespace semaphore in favor of a global semaphore. This can have an effect on namespace scalability.

... and #2 uses that semaphore...

Patch #2, uses the global semaphore. Yes that patch would'nt have compiled without patch #4, because the global semaphore got defined only in the patch #4.

Ordinarily that doesn't matter much. But if you're doing a `git bisect' and you happen to land in the middle of a patch series at a point where it doesn't compile or run, it can ruin your whole day.