Skip to contentSkip to conversation

Kbuild: avoid indexing .git directory for tags/cscope/...

PATCH New Paolo 'Blaisorblade' Giarrusso 1 participant 3 messages Sep 20, 2005

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/3 Kbuild: avoid indexing .git directory for tags/cscope/...

From: Paolo 'Blaisorblade' Giarrusso <[email protected]>

It is useless to pass to ctags or cscope the git objects - so skip them.

---

 Makefile |    6 ++++--
 1 files changed, 4 insertions(+), 2 deletions(-)
Makefile +4 -2
@@ -371,8 +371,10 @@ export MODVERDIR := $(if $(KBUILD_EXTMOD
 
 # Files to ignore in find ... statements
 
-RCS_FIND_IGNORE := \( -name SCCS -o -name BitKeeper -o -name .svn -o -name CVS -o -name .pc -o -name .hg \) -prune -o
-RCS_TAR_IGNORE := --exclude SCCS --exclude BitKeeper --exclude .svn --exclude CVS --exclude .pc --exclude .hg
+RCS_FIND_IGNORE := \( -name SCCS -o -name BitKeeper -o -name .svn -o -name CVS -o -name .pc -o -name .hg \
+	-o -name .git \) -prune -o
+RCS_TAR_IGNORE := --exclude SCCS --exclude BitKeeper --exclude .svn --exclude CVS --exclude .pc --exclude .hg \
+	--exclude .git
 
 # ===========================================================================
 # Rules shared between *config targets and build targets
#1 lore raw

PATCH 2/3 Kbuild: index asm-$(SUBARCH) headers for UML

From: Paolo 'Blaisorblade' Giarrusso <[email protected]>

In Uml, many definitions are borrowed from underlying subarch headers (with #include <asm/arch/stuff.h>). And it has become annoying to keep switching tag files all time, so by default index the underlying subarch headers too. Btw, it adds negligible space to the tags file (less than 1M surely, IIRC it was around 500k over 40M).

Finally, preserve the ALLSOURCE_ARCHS command line option (I hope) - if it is set, it is used for headers too as before. But check my construct please, I didn't test this.

---

 Makefile |   13 ++++++++++++-
 1 files changed, 12 insertions(+), 1 deletions(-)
Makefile +12 -1
@@ -1191,6 +1191,17 @@ else
 __srctree = $(srctree)/
 endif
 
+ifeq ($(ALLSOURCE_ARCHS),)
+ifeq ($(ARCH),um)
+ALLINCLUDE_ARCHS := $(ARCH) $(SUBARCH)
+else
+ALLINCLUDE_ARCHS := $(ARCH)
+endif
+else
+#Allow user to specify only ALLSOURCE_PATHS on the command line, keeping existing behaviour.
+ALLINCLUDE_ARCHS := $(ALLSOURCE_ARCHS)
+endif
+
 ALLSOURCE_ARCHS := $(ARCH)
 
 define all-sources
@@ -1206,7 +1217,7 @@ define all-sources
 	  find $(__srctree)include $(RCS_FIND_IGNORE) \
 	       \( -name config -o -name 'asm-*' \) -prune \
 	       -o -name '*.[chS]' -print; \
-	  for ARCH in $(ALLSOURCE_ARCHS) ; do \
+	  for ARCH in $(ALLINCLUDE_ARCHS) ; do \
 	       find $(__srctree)include/asm-$${ARCH} $(RCS_FIND_IGNORE) \
 	            -name '*.[chS]' -print; \
 	  done ; \
#2 lore raw

PATCH 3/3 HostAP: fix Kbuild warning

In reply to Paolo 'Blaisorblade' Giarrusso

From: Paolo 'Blaisorblade' Giarrusso <[email protected]>

The dependency on NET_RADIO is useless, because we select already it indirectly, through IEEE80211.

The "recursive dependency" warning is actually IMHO partially wrong in this context (we don't have a recursive dependency, but we *do* have recursion in the code, for the way we recurse on "select" dependencies), but fixing it properly doesn't seem easy (and I've not the time for this).

---

 drivers/net/wireless/hostap/Kconfig |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/net/wireless/hostap/Kconfig +1 -1
@@ -1,6 +1,6 @@
 config HOSTAP
 	tristate "IEEE 802.11 for Host AP (Prism2/2.5/3 and WEP/TKIP/CCMP)"
-	depends on NET_RADIO
+	#Dependency on NET_RADIO is implied by selecting IEEE80211 -> NET_RADIO.
 	select IEEE80211
 	select IEEE80211_CRYPT_WEP
 	---help---