Dont use shortcut when using send_IPI_all in flat mode
Hi
This got missed during the previous update for not doing shortcut since it introduces race in IPI, when using flat mode.
The earlier patches addressed send_IPI_allbutself, this one take care of the sendall() case as well.
Andrew: Please consider for -mm
Signature · 27 lines
Cheers, Ashok Raj - Open Source Technology Center Signed-off-by: Ashok Raj <[email protected]> -------------------------------------------------------- arch/x86_64/kernel/genapic_flat.c | 4 ++++ 1 files changed, 4 insertions(+) Index: linux-2.6.14-rc1-mm1/arch/x86_64/kernel/genapic_flat.c =================================================================== --- linux-2.6.14-rc1-mm1.orig/arch/x86_64/kernel/genapic_flat.c +++ linux-2.6.14-rc1-mm1/arch/x86_64/kernel/genapic_flat.c @@ -94,7 +94,11 @@ static void flat_send_IPI_allbutself(int static void flat_send_IPI_all(int vector) { +#ifndef CONFIG_HOTPLUG_CPU __send_IPI_shortcut(APIC_DEST_ALLINC, vector, APIC_DEST_LOGICAL); +#else + flat_send_IPI_mask(cpu_online_map, vector); +#endif } static int flat_apic_id_registered(void)
Quoted 9 lines · Ashok Raj
Hi
This got missed during the previous update for not doing shortcut since it introduces race in IPI, when using flat mode.
The earlier patches addressed
send_IPI_allbutself, this one take care of thesendall()case as well.Andrew: Please consider for -mm
It's not needed because genapic always sets physflat when CONFIG_HOTPLUG_CPU is set.
In fact the other HOTPLUG_CPU ifdefs in genapic_flat you added can be removed now.
-Andi