Skip to contentSkip to conversation

hwmon: adm9240 updates

PATCH New Grant Coady 3 participants 7 messages Sep 14, 2005 – Sep 23, 2005 Hardware monitoring

lore
Share & tools
lore
#0 lore raw

PATCH 1/3 hwmon: adm9240 updates

hwmon: adm9240 update 1/3: whitespace

---
 adm9240.c |   17 +++++++++++------
 1 files changed, 11 insertions(+), 6 deletions(-)
drivers/hwmon/adm9240.c +11 -6
@@ -350,7 +350,7 @@
 			"to %u\n", nr + 1, 1 << old, 1 << fan_div);
 }
 
-/* 
+/*
  * set fan speed low limit:
  *
  * - value is zero: disable fan speed low limit alarm
@@ -449,7 +449,8 @@
 show_fan_offset(2);
 
 /* alarms */
-static ssize_t show_alarms(struct device *dev, struct device_attribute *attr, char *buf)
+static ssize_t show_alarms(struct device *dev,
+		struct device_attribute *attr, char *buf)
 {
 	struct adm9240_data *data = adm9240_update_device(dev);
 	return sprintf(buf, "%u\n", data->alarms);
@@ -457,7 +458,8 @@
 static DEVICE_ATTR(alarms, S_IRUGO, show_alarms, NULL);
 
 /* vid */
-static ssize_t show_vid(struct device *dev, struct device_attribute *attr, char *buf)
+static ssize_t show_vid(struct device *dev,
+		struct device_attribute *attr, char *buf)
 {
 	struct adm9240_data *data = adm9240_update_device(dev);
 	return sprintf(buf, "%d\n", vid_from_reg(data->vid, data->vrm));
@@ -465,13 +467,15 @@
 static DEVICE_ATTR(cpu0_vid, S_IRUGO, show_vid, NULL);
 
 /* analog output */
-static ssize_t show_aout(struct device *dev, struct device_attribute *attr, char *buf)
+static ssize_t show_aout(struct device *dev,
+		struct device_attribute *attr, char *buf)
 {
 	struct adm9240_data *data = adm9240_update_device(dev);
 	return sprintf(buf, "%d\n", AOUT_FROM_REG(data->aout));
 }
 
-static ssize_t set_aout(struct device *dev, struct device_attribute *attr, const char *buf, size_t count)
+static ssize_t set_aout(struct device *dev,
+		struct device_attribute *attr, const char *buf, size_t count)
 {
 	struct i2c_client *client = to_i2c_client(dev);
 	struct adm9240_data *data = i2c_get_clientdata(client);
@@ -486,7 +490,8 @@
 static DEVICE_ATTR(aout_output, S_IRUGO | S_IWUSR, show_aout, set_aout);
 
 /* chassis_clear */
-static ssize_t chassis_clear(struct device *dev, struct device_attribute *attr, const char *buf, size_t count)
+static ssize_t chassis_clear(struct device *dev,
+		struct device_attribute *attr, const char *buf, size_t count)
 {
 	struct i2c_client *client = to_i2c_client(dev);
 	unsigned long val = simple_strtol(buf, NULL, 10);
#1 lore raw

PATCH 1/3 hwmon: adm9240 updates

Hi Grant,

Quoted 3 lines

hwmon: adm9240 update 1/3: whitespace

I see that your latter series had only two patches, this one not being there anymore. It looks correct to me though. Do you still want me to apply it, or not?

Signature · 1 line
Jean Delvare
#2 lore raw

PATCH 1/3 hwmon: adm9240 updates

In reply to Grant Coady

Hi Jean,

Quoted 9 lines · Jean Delvare

Hi Grant,

Quoted 3 lines

hwmon: adm9240 update 1/3: whitespace

I see that your latter series had only two patches, this one not being there anymore. It looks correct to me though. Do you still want me to apply it, or not?

GregKH already took the later two on 2005-09-17, was CC: to you, and yes. they apply after this 2005-09-10 whitespace patch.

I thought I did wrong thing numbering 1..3 as 1/3 already gone to Greg? Just my normal scattered confusion ;) Sorry.

Cheers,
Grant.

#3 lore raw

PATCH 1/3 hwmon: adm9240 updates

In reply to Grant Coady
Quoted 4 lines · Grant Coady

hwmon: adm9240 update 1/3: whitespace

Hm, Jean pointed out that I've missed this patch. Yet I applied another patch called 1/3 which is a bit confusing... So, could you just verify that I've accepted all of the patches that you want me to? And if not, care to resend them to me?

thanks,

greg k-h

#4 lore raw

PATCH 1/3 hwmon: adm9240 updates

In reply to Grant Coady

Hi Greg,

Quoted 10 lines · Greg KH
Quoted 4 lines · Grant Coady

hwmon: adm9240 update 1/3: whitespace

Hm, Jean pointed out that I've missed this patch. Yet I applied another patch called 1/3 which is a bit confusing... So, could you just verify that I've accepted all of the patches that you want me to? And if not, care to resend them to me?

Nothing missing, 2.6.14-rc2-mm1 looks fine, works as well, thank you.

Sorry for confusion, patches 2 and 3 got changed after review then l-k release changed and I got confused as to what to do with numbering.

Cheers,
Grant.

Grant.

#5 lore raw

PATCH 1/3 hwmon: adm9240 updates

In reply to Grant Coady

Hi Grant, Greg,

Quoted 2 lines

Nothing missing, 2.6.14-rc2-mm1 looks fine, works as well, thank you.

I just double-checked, the patch I had pointed Greg to is NOT in 2.6.14-rc2-mm1.

Nevermind, just forget about it for now, I'll respin it and include it in my next batch of patches to Greg.

Signature · 1 line
Jean Delvare
#6 lore raw

PATCH 1/3 hwmon: adm9240 updates

In reply to Grant Coady
Quoted 9 lines · Jean Delvare

Hi Grant,

Quoted 3 lines

hwmon: adm9240 update 1/3: whitespace

I see that your latter series had only two patches, this one not being there anymore. It looks correct to me though. Do you still want me to apply it, or not?

Please, I thought you already had, on Sept 10?

Thanks,
Grant.