Skip to contentSkip to conversation

I2C Documentation fix

PATCH New Hideki IWAMOTO 2 participants 4 messages Sep 14, 2005 – Oct 5, 2005

lore
Share & tools
lore

Hideki IWAMOTO

author
#0 lore raw

PATCH 1/1 I2C Documentation fix

Index: doc/functionality
=================================RCS file: /home/cvs/i2c/doc/functionality,v retrieving revision 1.3

functionality +2 -2
diff -u -r1.3 functionality
@@ -17,8 +17,8 @@
   I2C_FUNC_I2C                    Plain i2c-level commands (Pure SMBus
                                   adapters typically can not do these)
   I2C_FUNC_10BIT_ADDR             Handles the 10-bit address extensions
-  I2C_FUNC_PROTOCOL_MANGLING      Knows about the I2C_M_REV_DIR_ADDR,
-                                  I2C_M_REV_DIR_ADDR and I2C_M_REV_DIR_NOSTART
+  I2C_FUNC_PROTOCOL_MANGLING      Knows about the I2C_M_IGNORE_NAK,
+                                  I2C_M_REV_DIR_ADDR and I2C_M_NOSTART
                                   flags (which modify the i2c protocol!)
   I2C_FUNC_SMBUS_QUICK            Handles the SMBus write_quick command
   I2C_FUNC_SMBUS_READ_BYTE        Handles the SMBus read_byte command

----
Hideki IWAMOTO [email protected]

#1 lore raw

PATCH 1/1 I2C Documentation fix

Konbanwa Hideki,

functionality line 21

Quoted 7 lines
functionality +2 -2
(...)
-  I2C_FUNC_PROTOCOL_MANGLING      Knows about the I2C_M_REV_DIR_ADDR,
-                                  I2C_M_REV_DIR_ADDR and I2C_M_REV_DIR_NOSTART
+  I2C_FUNC_PROTOCOL_MANGLING      Knows about the I2C_M_IGNORE_NAK,
+                                  I2C_M_REV_DIR_ADDR and I2C_M_NOSTART

Good catch! Thanks for reporting. I just committed the fix to i2c CVS, and I'll port it to Linux 2.6 too.

Arigato,

Signature · 1 line
Jean Delvare
author
#2 lore raw

PATCH 1/1 I2C Documentation fix

In reply to Hideki IWAMOTO

The name which can be set to i2c_driver is up to 31 characters.

Index: doc/writing-clients
=================================RCS file: /home/cvs/i2c/doc/writing-clients,v retrieving revision 1.22

writing-clients +1 -1
diff -u -p -r1.22 writing-clients
@@ -35,7 +35,7 @@ static struct i2c_driver foo_driver = {
 	.dec_use	= foo_dec_use, /* May be NULL */
 }
  
-The name can be chosen freely, and may be upto 40 characters long. Please
+The name can be chosen freely, and may be up to 31 characters long. Please
 use something descriptive here.
 
 If used, the id should be a unique ID. The range 0xf000 to 0xffff is

----
Hideki IWAMOTO [email protected]

#3 lore raw

PATCH 1/1 I2C Documentation fix

In reply to Hideki IWAMOTO

Konbanwa Hideki,

Quoted 1 line

The name which can be set to i2c_driver is up to 31 characters.

Correct, I've committed your patch to CVS, thanks.

I'll port it to Linux 2.6 too, with some changes as the rules for this name are a bit different there.

Arigato,

Signature · 1 line
Jean Delvare