Skip to contentSkip to conversation

: show_free_area shows free pages in pcp list

PATCH In review Seth, Rohit 2 participants 5 messages Sep 28, 2005

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 : show_free_area shows free pages in pcp list

[PATCH]: The count field in pcp list represents the free pages in that list. Change the "used" to "free" in the print message in show_free_area routine.

mm/page_alloc.c +1 -1
@@ -1409,7 +1409,7 @@
 			pageset = zone_pcp(zone, cpu);
 
 			for (temperature = 0; temperature < 2; temperature++)
-				printk("cpu %d %s: low %d, high %d, batch %d used:%d\n",
+				printk("cpu %d %s: low %d, high %d, batch %d free:%d\n",
 					cpu,
 					temperature ? "cold" : "hot",
 					pageset->pcp[temperature].low,
#1 lore raw
Quoted 1 line · Rohit

[PATCH]: The count field in pcp list represents the free pages in that list.

Well, lets keep it the way it is.

Its the number of free pages used by the pcp list.

Its true that these are pages that are not "used" by the system but they are in use for the cache and not accounted for by the number of free pages.

author
#2 lore raw
Quoted 8 lines · Christoph Lameter
Quoted 1 line · Rohit

[PATCH]: The count field in pcp list represents the free pages in that list.

Well, lets keep it the way it is.

Its the number of free pages used by the pcp list.

As you said, pcp is a cache of free pages. From pcp's point-of-view, this is a count of free pages that is available for use.

Quoted 5 lines

Its true that these are pages that are not "used" by the system but they are in use for the cache and not accounted for by the number of free pages.

In case free is causing any confusion then I would like to get that changed to "count"...representing the number of elements on it (and the field of structure just like other values).

#3 lore raw
Quoted 3 lines · Rohit Seth
Quoted 1 line

Its the number of free pages used by the pcp list.

As you said, pcp is a cache of free pages. From pcp's point-of-view, this is a count of free pages that is available for use.

This is the number of free pages on the list. Its the number of free pages "used" by the list and no longer accounted for by the zone free_pages count.

author
#4 lore raw
Quoted 10 lines · Christoph Lameter
Quoted 3 lines · Rohit Seth
Quoted 1 line

Its the number of free pages used by the pcp list.

As you said, pcp is a cache of free pages. From pcp's point-of-view, this is a count of free pages that is available for use.

This is the number of free pages on the list. Its the number of free pages "used" by the list and no longer accounted for by the zone free_pages count.

As we are dumping the information so putting the field name "count" itself makes more sense.

-rohit