Problems with CF bluetooth (fwd) (fwd)
Hi!
Thanks, Russell. Marcel, this is probably solution to that oops.
Pavel
----- Forwarded message from Russell King
X-Original-To: [email protected]
To: Pavel Machek <[email protected]>, Alan Cox <[email protected]>
Subject: Re: Problems with CF bluetooth (fwd)
X-Spam-Checker-Version: SpamAssassin 3.0.2 (2004-11-16) on
atrey.karlin.mff.cuni.cz
X-Spam-Level:
X-Spam-Status: No, score=0.0 required=5.0 tests=none autolearn=failed
version=3.0.2
X-CRM114-Status: Good ( pR: 34.1646 )
Quoted 11 lines · Pavel Machek
(I had to hack serial driver a bit to default to 921600 bitrate; it does not have setserial).
# hciattach -s 921600 /dev/ttyS0 bcsp BCSP initialization timed out PavelSep 29 15:42:34 amd kernel: EIP: 0060:[<c02d4e2c>] Not tainted VLI Sep 29 15:42:34 amd kernel: EFLAGS: 00010082 (2.6.14-rc2-g5fb2493e) Sep 29 15:42:34 amd kernel: EIP is at uart_flush_buffer+0xc/0x30
Ok, you're in uart_flush_buffer(), and we got there through the ldisc being closed.
Quoted 5 lines
Sep 29 15:42:34 amd kernel: Call Trace: Sep 29 15:42:34 amd kernel: [<c03f9df6>] hci_uart_flush+0x66/0x80 Sep 29 15:42:34 amd kernel: [<c03f9e27>] hci_uart_close+0x17/0x20 Sep 29 15:42:34 amd kernel: [<c03f9f86>] hci_uart_tty_close+0x26/0x60 Sep 29 15:42:34 amd kernel: [<c02a5ed7>] release_dev+0x587/0x670
Looking at release_dev(), it does things in the following order:
1. various sanity checks
2. close the driver
3. more sanity checks and other housekeeping
4. close the ldisc
5. reset the ldisc for the tty to N_TTY
This means that bluetooth is calling into a TTY driver with a tty for which the driver has already shut down. No surprise it oopses. Bluetooth should not call the driver during it's closedown.
(There also appears to be an interesting race condition between the driver shutting down and the ldisc write functions getting to know about it... Alan?)
Signature · 6 lines
Russell King ----- End forwarded message ----- -- if you have sharp zaurus hardware you don't need... you know my address
Hi Pavel,
Quoted 1 line
Thanks, Russell. Marcel, this is probably solution to that oops.
cool that you worked something out. Do you have a patch for me?
Regards
Marcel
Hi!
Quoted 3 lines
Quoted 1 line
Thanks, Russell. Marcel, this is probably solution to that oops.
cool that you worked something out. Do you have a patch for me?
Well, I have that ugly workaround that helps me, but is wrong (as rmk confirmed). His comment was:
|> Sep 29 15:42:34 amd kernel: Call Trace: |> Sep 29 15:42:34 amd kernel: [<c03f9df6>] hci_uart_flush+0x66/0x80 |> Sep 29 15:42:34 amd kernel: [<c03f9e27>] hci_uart_close+0x17/0x20 |> Sep 29 15:42:34 amd kernel: [<c03f9f86>] |> hci_uart_tty_close+0x26/0x60 |> Sep 29 15:42:34 amd kernel: [<c02a5ed7>] release_dev+0x587/0x670 | |Looking at release_dev(), it does things in the following order: | |1. various sanity checks |2. close the driver |3. more sanity checks and other housekeeping |4. close the ldisc |5. reset the ldisc for the tty to N_TTY | |This means that bluetooth is calling into a TTY driver with a tty |for which the driver has already shut down. No surprise it oopses. |Bluetooth should not call the driver during it's closedown. | |(There also appears to be an interesting race condition between the |driver shutting down and the ldisc write functions getting to know |about it... Alan?)
But no, I do not have patch for that.
Pavel
Signature · 1 line
if you have sharp zaurus hardware you don't need... you know my address
Hi Pavel,
Quoted 30 lines
Quoted 3 lines
Quoted 1 line
Thanks, Russell. Marcel, this is probably solution to that oops.
cool that you worked something out. Do you have a patch for me?
Well, I have that ugly workaround that helps me, but is wrong (as rmk confirmed). His comment was:
|> Sep 29 15:42:34 amd kernel: Call Trace: |> Sep 29 15:42:34 amd kernel: [<c03f9df6>] hci_uart_flush+0x66/0x80 |> Sep 29 15:42:34 amd kernel: [<c03f9e27>] hci_uart_close+0x17/0x20 |> Sep 29 15:42:34 amd kernel: [<c03f9f86>] |> hci_uart_tty_close+0x26/0x60 |> Sep 29 15:42:34 amd kernel: [<c02a5ed7>] release_dev+0x587/0x670 | |Looking at release_dev(), it does things in the following order: | |1. various sanity checks |2. close the driver |3. more sanity checks and other housekeeping |4. close the ldisc |5. reset the ldisc for the tty to N_TTY | |This means that bluetooth is calling into a TTY driver with a tty |for which the driver has already shut down. No surprise it oopses. |Bluetooth should not call the driver during it's closedown. | |(There also appears to be an interesting race condition between the |driver shutting down and the ldisc write functions getting to know |about it... Alan?)
Quoted 1 line
But no, I do not have patch for that.
I won't have time to look at it for the next two weeks. So if someone comes up with a patch I am happy to create another -mh patch to make it available for testing.
Regards
Marcel