Skip to contentSkip to conversation

minor fix in asm-mips/module.h

PATCH In review Franck 2 participants 8 messages Sep 26, 2005 – Sep 30, 2005 MIPS

lore
Share & tools
lore

Franck

author
#0 lore raw

PATCH 1/1 minor fix in asm-mips/module.h

This patch replaces an empty preprocessor condition #elif by #else. It adds 4ksc and 4ksd as well.

Thanks.
--
Franck

#1 lore raw
Quoted 2 lines · Franck

This patch replaces an empty preprocessor condition #elif by #else. It adds 4ksc and 4ksd as well.

You forgot to include the patch ...

Ralf

author
#2 lore raw

2005/9/26, Ralf Baechle <[email protected]>:

Quoted 6 lines · Franck
Quoted 3 lines

This patch replaces an empty preprocessor condition #elif by #else. It adds 4ksc and 4ksd as well.

You forgot to include the patch ...

sorry for that, here it is...

Thanks
--
Franck

module.h renamed from module.h~old +5 -1
@@ -113,7 +113,11 @@ search_module_dbetables(unsigned long ad
 #define MODULE_PROC_FAMILY "RM9000"
 #elif defined CONFIG_CPU_SB1
 #define MODULE_PROC_FAMILY "SB1"
-#elif
+#elif defined CONFIG_CPU_4KSC
+#define MODULE_PROC_FAMILY "4KSC"
+#elif defined CONFIG_CPU_4KSD
+#define MODULE_PROC_FAMILY "4KSD"
+#else
 #error MODULE_PROC_FAMILY undefined for your processor configuration
 #endif
#3 lore raw
Quoted 4 lines · Franck

2005/9/26, Ralf Baechle <[email protected]>:

Quoted 3 lines · Franck
Quoted 2 lines

This patch replaces an empty preprocessor condition #elif by #else.

Thanks for noticing.

Quoted 1 line
Quoted 1 line
Quoted 1 line

It adds 4ksc and 4ksd as well.

module.h 2005-09-26 09:54:08.000000000 +0200 renamed from module.h~old 2005-09-26 14:02:32.000000000 +0200 +4 -1
@@ -113,7 +113,11 @@ search_module_dbetables(unsigned long ad
 #define MODULE_PROC_FAMILY "RM9000"
 #elif defined CONFIG_CPU_SB1
 #define MODULE_PROC_FAMILY "SB1"
-#elif
+#elif defined CONFIG_CPU_4KSC
+#define MODULE_PROC_FAMILY "4KSC"
+#elif defined CONFIG_CPU_4KSD
+#define MODULE_PROC_FAMILY "4KSD"

There are no CONFIG_CPU_4KSC and CONFIG_CPU_4KSD configuration options. Did you really create this patch against the linux module of the CVS repository or was it a different tree?

Thanks,

Ralf

author
#4 lore raw

Hi Ralf,

2005/9/30, Ralf Baechle <[email protected]>:

Quoted 4 lines

There are no CONFIG_CPU_4KSC and CONFIG_CPU_4KSD configuration options. Did you really create this patch against the linux module of the CVS repository or was it a different tree?

The patch was created against linux-mips CVS repository. I added 4KSC and 4KSD support in this tree. I thougth seeing reference of 4KSC somewhere. Anyway, if you don't want to include them in your tree that's ok.

Thanks
--
Franck

#5 lore raw
Quoted 10 lines · Franck

2005/9/30, Ralf Baechle <[email protected]>:

Quoted 4 lines

There are no CONFIG_CPU_4KSC and CONFIG_CPU_4KSD configuration options. Did you really create this patch against the linux module of the CVS repository or was it a different tree?

The patch was created against linux-mips CVS repository. I added 4KSC and 4KSD support in this tree. I thougth seeing reference of 4KSC somewhere. Anyway, if you don't want to include them in your tree that's ok.

It's just that references to CONFIG_* symbols that are being defined nowhere don't make sense. If however you want to contribute improved support for these processors, by all means I'm certainly going to appreciate a patch!

Ralf

author
#6 lore raw

2005/9/30, Ralf Baechle <[email protected]>:

Quoted 13 lines · Franck
Quoted 11 lines

2005/9/30, Ralf Baechle <[email protected]>:

Quoted 4 lines

There are no CONFIG_CPU_4KSC and CONFIG_CPU_4KSD configuration options. Did you really create this patch against the linux module of the CVS repository or was it a different tree?

The patch was created against linux-mips CVS repository. I added 4KSC and 4KSD support in this tree. I thougth seeing reference of 4KSC somewhere. Anyway, if you don't want to include them in your tree that's ok.

Quoted 5 lines

It's just that references to CONFIG_* symbols that are being defined nowhere don't make sense. If however you want to contribute improved support for these processors, by all means I'm certainly going to appreciate a patch!

I'm surprised you're interested in added support for 4KSC and 4KSD cpu...Anyway I could send a trivial patch to you if so.

Thanks
--
Franck

#7 lore raw
Quoted 11 lines · Franck
Quoted 11 lines
Quoted 10 lines

2005/9/30, Ralf Baechle <[email protected]>:

Quoted 4 lines

There are no CONFIG_CPU_4KSC and CONFIG_CPU_4KSD configuration options. Did you really create this patch against the linux module of the CVS repository or was it a different tree?

The patch was created against linux-mips CVS repository. I added 4KSC and 4KSD support in this tree. I thougth seeing reference of 4KSC somewhere. Anyway, if you don't want to include them in your tree that's ok.

Quoted 8 lines
Quoted 5 lines

It's just that references to CONFIG_* symbols that are being defined nowhere don't make sense. If however you want to contribute improved support for these processors, by all means I'm certainly going to appreciate a patch!

I'm surprised you're interested in added support for 4KSC and 4KSD cpu...Anyway I could send a trivial patch to you if so.

Yes, some people do strange things with Linux :-)

Ralf