Skip to contentSkip to conversation

Documentation fix (writing-clients)

PATCH New Hideki IWAMOTO 2 participants 2 messages Oct 1, 2005 – Oct 2, 2005 I2C

lore
Share & tools
lore

Hideki IWAMOTO

author
#0 lore raw

PATCH 1/1 Documentation fix (writing-clients)

o Remove flags parameter from detect function.
o i2c_smbus_read_i2c_block_data is not deleted in 2.6.10. It still exists.

Documentation/i2c/writing-clients renamed from Documentation/i2c/writing-clients.org +3 -6
@@ -246,10 +246,7 @@ the detection to stop: other addresses a
 This should only be done on fatal or internal errors, such as a memory
 shortage or i2c_attach_client failing.
 
-For now, you can ignore the `flags' parameter. It is there for future use.
-
-  int foo_detect_client(struct i2c_adapter *adapter, int address, 
-                        unsigned short flags, int kind)
+  int foo_detect_client(struct i2c_adapter *adapter, int address, int kind)
   {
     int err = 0;
     int i;

@@ -576,12 +573,12 @@ SMBus communication
   extern s32 i2c_smbus_write_block_data(struct i2c_client * client,
                                         u8 command, u8 length,
                                         u8 *values);
+  extern s32 i2c_smbus_read_i2c_block_data(struct i2c_client * client,
+                                           u8 command, u8 *values);
 
 These ones were removed in Linux 2.6.10 because they had no users, but could
 be added back later if needed:
 
-  extern s32 i2c_smbus_read_i2c_block_data(struct i2c_client * client,
-                                           u8 command, u8 *values);
   extern s32 i2c_smbus_read_block_data(struct i2c_client * client,
                                        u8 command, u8 *values);
   extern s32 i2c_smbus_write_i2c_block_data(struct i2c_client * client,

----
Hideki IWAMOTO [email protected]

#1 lore raw

PATCH 1/1 Documentation fix (writing-clients)

Ohaio Hideki,

Quoted 1 line

o Remove flags parameter from detect function.

This one I already fixed in one of Jeff Garzik's trees, as part of a larger documentation patch. It's just a matter of time before it reaches mainline.

http://www.kernel.org/git/?p=linux/kernel/git/jgarzik/misc-2.6.git;a=blobdiff;h›9b7d0e54f24d447fc07e3a25ac1696e5d60143;hpÌ25797017453600a686bbed6c18e0b8d07e6d03;hbc9dcdae08ec08daf1efd8e4bda78395a655240;f=Documentation/i2c/writing-clients

Quoted 1 line

o i2c_smbus_read_i2c_block_data is not deleted in 2.6.10. It still exists.

Correct, I've applied this one, thanks.

BTW, do not hesitate to sign the patches you send, by adding the following line in the header comments:

Signed-off-by Hideki Iwamoto <[email protected]>

That way you'll always get properly credited for your work. This also allows for easier tracking of changes if anyone has questions about a particular patch.

Arigato,

Signature · 1 line
Jean Delvare