arch/i386/kernel/doublefault.c

Signed-off-by Anton Brondz

arch/i386/kernel/doublefault.c +1 -1

@@ -23,23 +23,23 @@ static void doublefault_fn(void)
 	store_gdt(&gdt_desc);
 	gdt = gdt_desc.address;
 
-	printk("double fault, gdt at %08lx [%d bytes]\n", gdt, gdt_desc.size);
+	printk(KERN_WARNING "double fault, gdt at %08lx [%d bytes]\n", gdt, gdt_desc.size);
[...]

}
}

This is the third time I'm sending this. Hope you're not tired of me yet :). This time I've added a signed off line, used a different mail client to get the word wrap off and changed the constants.

Quoted 20 lines · Christophe Lucas

arch/i386/kernel/doublefault.c static void doublefault_fn(void) · line 28

Quoted 12 lines · [email protected] ([email protected]) wrote:

Signed-off-by Anton Brondz

arch/i386/kernel/doublefault.c +1 -1

@@ -23,23 +23,23 @@ static void doublefault_fn(void)
 	store_gdt(&gdt_desc);
 	gdt = gdt_desc.address;
 
-	printk("double fault, gdt at %08lx [%d bytes]\n", gdt, gdt_desc.size);
+	printk(KERN_WARNING "double fault, gdt at %08lx [%d bytes]\n", gdt, gdt_desc.size);
 
 

When a double fault happens we are not in good terms with os ;) So I don't think KERN_WARNING, KERN_NOTICE, KERN_ERR are the good flags. I think the issue is in KERN_CRIT, KERN_EMERG, KERN_ALERT.

Quoted 5 lines

Please read it (Debugging by printing : printk):

	http://lwn.net/images/pdf/LDD3/ch04.pdf

Have a nice day,

Now I've made some editing on the patch. I don't want to send the whole thing now as there may be some more editing. I'll put only the lines with the constants here now.

*printk(KERN_ALERT "double fault, gdt at %08lx [%d bytes]\n", gdt, gdt_desc.size);*
KERN_ALERT because it prints the address of the double fault which requires immediate action.

*printk(KERN_CRIT "double fault, tss at %08lx\n", tss);* KERN_CRIT because it prints the tss address.
*
printk(KERN_CRIT "eip = %08lx, esp = %08lx\n", t->eip, t->esp); *KERN_CRIT because it prints eip and esp address.

*printk(KERN_CRIT "eax = %08lx, ebx = %08lx, ecx = %08lx, edx = %08lx\n",

                t->eax, t->ebx, t->ecx, t->edx);

*KERN_CRIT because it prints eax, ebx, ecx and edx address.

*printk(KERN_CRIT "esi = %08lx, edi = %08lx\n",

                t->esi, t->edi);

*KERN_CRIT because it prints esi and edi address.

Hope this is better, so I can send the patch. ;-)

arch/i386/kernel/doublefault.c static void doublefault_fn(void) · line 28

Quoted 12 lines · [email protected] ([email protected]) wrote:

Signed-off-by Anton Brondz

arch/i386/kernel/doublefault.c +1 -1

@@ -23,23 +23,23 @@ static void doublefault_fn(void)
 	store_gdt(&gdt_desc);
 	gdt = gdt_desc.address;
 
-	printk("double fault, gdt at %08lx [%d bytes]\n", gdt, gdt_desc.size);
+	printk(KERN_WARNING "double fault, gdt at %08lx [%d bytes]\n", gdt, gdt_desc.size);
 
 

When a double fault happens we are not in good terms with os ;) So I don't think KERN_WARNING, KERN_NOTICE, KERN_ERR are the good flags. I think the issue is in KERN_CRIT, KERN_EMERG, KERN_ALERT.

Please read it (Debugging by printing : printk):

	http://lwn.net/images/pdf/LDD3/ch04.pdf

Have a nice day,

- Christophe ([email protected])

------------------------------------------------------------------------

_______________________________________________
Kernel-janitors mailing list
[email protected]
https://lists.osdl.org/mailman/listinfo/kernel-janitors

Quoted 17 lines · On Mon, Oct 03, 2005 at 04:54:41PM +0000, [email protected] wrote:

arch/i386/kernel/doublefault.c +1 -1

 
 
 
 
 
-	printk("double fault, gdt at %08lx [%d bytes]\n", gdt, gdt_desc.size);
+	printk(KERN_ALERT "double fault, gdt at %08lx [%d bytes]\n", gdt, gdt_desc.size);

	if (ptr_ok(gdt)) {
		gdt += GDT_ENTRY_TSS << 3;
		tss = *(u16 *)(gdt+2);
		tss += *(u8 *)(gdt+4) << 16;
		tss += *(u8 *)(gdt+7) << 24;

arch/i386/kernel/doublefault.c

Quoted 2 lines

arch/i386/kernel/doublefault.c +1 -1

-		printk("double fault, tss at %08lx\n", tss);
+		printk(KERN_CRIT "double fault, tss at %08lx\n", tss);

Different priorities?

------------------------------------------------------------------------

_______________________________________________
Kernel-janitors mailing list
[email protected]
https://lists.osdl.org/mailman/listinfo/kernel-janitors