Skip to contentSkip to conversation

sis190.c: fix multicast MAC filter

PATCH In review Aurelien Jarno 2 participants 3 messages Oct 5, 2005 Network drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 sis190.c: fix multicast MAC filter

Hi,

Here is a patch that changes the way the MAC filter is computed for the multicast addresses. The computation is taken from the SiS GPL driver.

This patch is necessary to get IPv6 working.

Thanks,
Aurelien

drivers/net/sis190.c +1 -1
@@ -842,7 +842,7 @@
 		for (i = 0, mclist = dev->mc_list; mclist && i < dev->mc_count;
 		     i++, mclist = mclist->next) {
 			int bit_nr =
-				ether_crc(ETH_ALEN, mclist->dmi_addr) >> 26;
+				ether_crc(ETH_ALEN, mclist->dmi_addr) & 0x3f;
 			mc_filter[bit_nr >> 5] |= 1 << (bit_nr & 31);
 			rx_mode |= AcceptMulticast;
 		}
Signature · 4 lines
  .''`.  Aurelien Jarno	            | GPG: 1024D/F1BCDB73
 : :' :  Debian developer           | Electrical Engineer
 `. `'   [email protected]         | [email protected]
   `-    people.debian.org/~aurel32 | www.aurel32.net
#1 lore raw

Aurelien Jarno <[email protected]> :

Quoted 2 lines

Here is a patch that changes the way the MAC filter is computed for the multicast addresses. The computation is taken from the SiS GPL driver.

Ok.

[...]

Quoted 1 line

This patch is necessary to get IPv6 working.

May I assume that it has been tested on the usual k8s-mx ?

If so, feel free to forward to [email protected] and [email protected]. I've just bought a mobo to test this adapter but it will not be ready before this week end.

--
Ueimor

#2 lore raw
Quoted 10 lines · Francois Romieu

Aurelien Jarno <[email protected]> :

Quoted 2 lines

Here is a patch that changes the way the MAC filter is computed for the multicast addresses. The computation is taken from the SiS GPL driver.

Ok.

[...]

Quoted 1 line

This patch is necessary to get IPv6 working.

May I assume that it has been tested on the usual k8s-mx ?

Yes, you're right.

Quoted 3 lines

If so, feel free to forward to [email protected] and [email protected]. I've just bought a mobo to test this adapter but it will not be ready before this week end.

Ok, will do that.

Thanks,
Aurelien

Signature · 4 lines
  .''`.  Aurelien Jarno	            | GPG: 1024D/F1BCDB73
 : :' :  Debian developer           | Electrical Engineer
 `. `'   [email protected]         | [email protected]
   `-    people.debian.org/~aurel32 | www.aurel32.net