Skip to contentSkip to conversation

sil24: implement tf_read callback

PATCH Applied Tejun Heo 2 participants 2 messages Oct 6, 2005

Subsystems (2)
SCSI libata
lore
Share & tools
lore

Tejun Heo

author
#0 lore raw

PATCH 1/1 sil24: implement tf_read callback

Hello, guys.

This patch implements ->tf_read callback for sil24. It didn't use to
be necessary but new ata_gen_fixed_sense now makes use of ->tf_read callback. This patch is taken from Edward Falk's driver.

Signed-off-by Tejun Heo <[email protected]>
drivers/scsi/sata_sil24.c +9 -0
@@ -229,6 +229,7 @@ static u8 sil24_check_status(struct ata_
 static u8 sil24_check_err(struct ata_port *ap);
 static u32 sil24_scr_read(struct ata_port *ap, unsigned sc_reg);
 static void sil24_scr_write(struct ata_port *ap, unsigned sc_reg, u32 val);
+static void sil24_tf_read(struct ata_port *ap, struct ata_taskfile *tf);
 static void sil24_phy_reset(struct ata_port *ap);
 static void sil24_qc_prep(struct ata_queued_cmd *qc);
 static int sil24_qc_issue(struct ata_queued_cmd *qc);

@@ -280,6 +281,8 @@ static struct ata_port_operations sil24_
 	.check_err		= sil24_check_err,
 	.dev_select		= ata_noop_dev_select,
 
+	.tf_read		= sil24_tf_read,
+
 	.phy_reset		= sil24_phy_reset,
 
 	.qc_prep		= sil24_qc_prep,

@@ -372,6 +375,12 @@ static void sil24_scr_write(struct ata_p
 	}
 }
 
+static void sil24_tf_read(struct ata_port *ap, struct ata_taskfile *tf)
+{
+	struct sil24_port_priv *pp = ap->private_data;
+	*tf = pp->tf;
+}
+
 static void sil24_phy_reset(struct ata_port *ap)
 {
 	__sata_phy_reset(ap);