Skip to contentSkip to conversation

Modular i810fb broken, partial fix

PATCH Bernhard Rosenkraenzer 4 participants 14 messages Oct 7, 2005 – Oct 10, 2005 Framebuffer layer

lore
Share & tools
lore
#0 lore raw

Hi,
i810fb as a module is broken (checked with 2.6.13-mm3 and 2.6.14-rc2-mm1). It compiles, but the module doesn't actually load because the kernel doesn't recognize the hardware (the MODULE_DEVICE_TABLE statement is missing).

The attached patch fixes this.

However, the resulting module still doesn't work.
It loads, and then garbles the display (black screen with a couple of yellow lines, no matter what is written into the framebuffer device).

Related .config entries:
CONFIG_I2C_I810=m
CONFIG_FB_I810=m
CONFIG_FB_I810_GTF=y
CONFIG_FB_I810_I2C=y

drivers/video/i810/i810_main.c renamed from drivers/video/i810/i810_main.c.ark +2 -0
@@ -83,6 +83,8 @@
 	{ 0 },
 };
 
+MODULE_DEVICE_TABLE(pci, i810fb_pci_tbl);
+
 static struct pci_driver i810fb_driver = {
 	.name     =	"i810fb",
 	.id_table =	i810fb_pci_tbl,
#1 lore raw
Quoted 7 lines · Bernhard Rosenkraenzer

Hi,
i810fb as a module is broken (checked with 2.6.13-mm3 and 2.6.14-rc2-mm1). It compiles, but the module doesn't actually load because the kernel doesn't recognize the hardware (the MODULE_DEVICE_TABLE statement is missing).

Quoted 5 lines

The attached patch fixes this.

However, the resulting module still doesn't work.
It loads, and then garbles the display (black screen with a couple of yellow lines, no matter what is written into the framebuffer device).

Did you compile CONFIG_FRAMEBUFFER_CONSOLE statically, or did a modprobe fbcon? Does i810fb work if compiled statically?

Tony

#2 lore raw
Quoted 2 lines · Antonino A. Daplas

Did you compile CONFIG_FRAMEBUFFER_CONSOLE statically, or did a modprobe fbcon? Does i810fb work if compiled statically?

CONFIG_FRAMEBUFFER_CONSOLE is compiled statically. Can't tell if it works if compiled statically because I don't have the hardware -- I'll try to get the user who reported this to check though.

#3 lore raw
In reply to Antonino A. Daplas
Quoted 7 lines · Antonino A. Daplas
Quoted 6 lines · Bernhard Rosenkraenzer

Hi,
i810fb as a module is broken (checked with 2.6.13-mm3 and 2.6.14-rc2-mm1). It compiles, but the module doesn't actually load because the kernel doesn't recognize the hardware (the MODULE_DEVICE_TABLE statement is missing).

Quoted 8 lines
Quoted 5 lines

The attached patch fixes this.

However, the resulting module still doesn't work.
It loads, and then garbles the display (black screen with a couple of yellow lines, no matter what is written into the framebuffer device).

Did you compile CONFIG_FRAMEBUFFER_CONSOLE statically, or did a modprobe fbcon? Does i810fb work if compiled statically?

Since this is *really* coming out often: is there a specific reason why the fb modules do not depend on fbcon?

Signature · 5 lines
Giuseppe "Oblomov" Bilotta

"They that can give up essential liberty to obtain
a little temporary safety deserve neither liberty
nor safety." Benjamin Franklin
#4 lore raw
Quoted 9 lines · Giuseppe Bilotta
Quoted 7 lines · Antonino A. Daplas
Quoted 6 lines · Bernhard Rosenkraenzer

Hi,
i810fb as a module is broken (checked with 2.6.13-mm3 and 2.6.14-rc2-mm1). It compiles, but the module doesn't actually load because the kernel doesn't recognize the hardware (the MODULE_DEVICE_TABLE statement is missing). The attached patch fixes this.

Quoted 9 lines
Quoted 5 lines
Quoted 3 lines

However, the resulting module still doesn't work.
It loads, and then garbles the display (black screen with a couple of yellow lines, no matter what is written into the framebuffer device).

Did you compile CONFIG_FRAMEBUFFER_CONSOLE statically, or did a modprobe fbcon? Does i810fb work if compiled statically?

Since this is *really* coming out often: is there a specific reason why the fb modules do not depend on fbcon?

Some need fbdev only, without fbcon, ie, embedded.

Tony

#5 lore raw
Quoted 13 lines · Antonino A. Daplas
Quoted 12 lines · Giuseppe Bilotta
Quoted 10 lines · Antonino A. Daplas
Quoted 9 lines · Bernhard Rosenkraenzer

Hi,
i810fb as a module is broken (checked with 2.6.13-mm3 and 2.6.14-rc2-mm1). It compiles, but the module doesn't actually load because the kernel doesn't recognize the hardware (the MODULE_DEVICE_TABLE statement is missing). The attached patch fixes this.

However, the resulting module still doesn't work.
It loads, and then garbles the display (black screen with a couple of yellow lines, no matter what is written into the framebuffer device).

Quoted 8 lines
Quoted 6 lines
Quoted 2 lines

Did you compile CONFIG_FRAMEBUFFER_CONSOLE statically, or did a modprobe fbcon? Does i810fb work if compiled statically?

Since this is *really* coming out often: is there a specific reason why the fb modules do not depend on fbcon?

Some need fbdev only, without fbcon, ie, embedded.

And does fbcon make sense *without* fbdevs?

Signature · 7 lines
Giuseppe "Oblomov" Bilotta

"Da grande lotterò per la pace"
"A me me la compra il mio babbo"
(Altan)
("When I grow up, I will fight for peace"
 "I'll have my daddy buy it for me")
#6 lore raw
Quoted 15 lines · Giuseppe Bilotta
Quoted 13 lines · Antonino A. Daplas
Quoted 12 lines · Giuseppe Bilotta
Quoted 10 lines · Antonino A. Daplas
Quoted 9 lines · Bernhard Rosenkraenzer

Hi,
i810fb as a module is broken (checked with 2.6.13-mm3 and 2.6.14-rc2-mm1). It compiles, but the module doesn't actually load because the kernel doesn't recognize the hardware (the MODULE_DEVICE_TABLE statement is missing). The attached patch fixes this.

However, the resulting module still doesn't work.
It loads, and then garbles the display (black screen with a couple of yellow lines, no matter what is written into the framebuffer device).

Quoted 9 lines
Quoted 6 lines
Quoted 5 lines
Quoted 2 lines

Did you compile CONFIG_FRAMEBUFFER_CONSOLE statically, or did a modprobe fbcon? Does i810fb work if compiled statically?

Since this is *really* coming out often: is there a specific reason why the fb modules do not depend on fbcon?

Some need fbdev only, without fbcon, ie, embedded.

And does fbcon make sense *without* fbdevs?

You can load fbcon only if you also load the core fb layer. But without any registered fbdevs, fbcon just stays in memory and will not take over the console.

Tony

#7 lore raw
In reply to Antonino A. Daplas
Quoted 8 lines · Antonino A. Daplas
Quoted 3 lines · Bernhard Rosenkraenzer

Hi,
i810fb as a module is broken (checked with 2.6.13-mm3 and 2.6.14-rc2-mm1).
It compiles, but the module doesn't actually load because the kernel doesn't recognize the hardware (the MODULE_DEVICE_TABLE statement is missing).

Quoted 8 lines
Quoted 4 lines

The attached patch fixes this.

However, the resulting module still doesn't work.
It loads, and then garbles the display (black screen with a couple of yellow lines, no matter what is written into the framebuffer device).

Did you compile CONFIG_FRAMEBUFFER_CONSOLE statically, or did a modprobe fbcon? Does i810fb work if compiled statically?

I tried the module on my i815 laptop, after modprobe the module does nothing. The call to pci_register_driver() returns 0, and thats it; the probe function does not get called. Same thing with Bernhard's patch applied. No problems when compiled-in. Kernel 2.6.14-rc2-mm1, AGP compiled in, no DRM.

thx,

Signature · 1 line
 Manuel Lauss.
#8 lore raw
Quoted 23 lines · Manuel Lauss
Quoted 13 lines · Antonino A. Daplas
Quoted 11 lines · Bernhard Rosenkraenzer

Hi,
i810fb as a module is broken (checked with 2.6.13-mm3 and 2.6.14-rc2-mm1).
It compiles, but the module doesn't actually load because the kernel doesn't recognize the hardware (the MODULE_DEVICE_TABLE statement is missing).

The attached patch fixes this.

Quoted 8 lines
Quoted 3 lines

However, the resulting module still doesn't work.
It loads, and then garbles the display (black screen with a couple of yellow lines, no matter what is written into the framebuffer device).

Did you compile CONFIG_FRAMEBUFFER_CONSOLE statically, or did a modprobe fbcon?
Does i810fb work if compiled statically?

Quoted 6 lines

I tried the module on my i815 laptop, after modprobe the module does nothing.
The call to pci_register_driver() returns 0, and thats it; the probe function
does not get called. Same thing with Bernhard's patch applied. No problems when compiled-in. Kernel 2.6.14-rc2-mm1, AGP compiled in, no DRM.

That's weird. Can you find out why the probe function is not called? Can you trace the pci_register_driver call starting in drivers/pci/pci-driver.c, then in drivers/base/*.c?

(Or you can #define DEBUG somewhere, perhaps in include/linux/device.h?)

Tony

#9 lore raw
Quoted 10 lines · Antonino A. Daplas
Quoted 6 lines · Manuel Lauss

I tried the module on my i815 laptop, after modprobe the module does nothing.
The call to pci_register_driver() returns 0, and thats it; the probe function
does not get called. Same thing with Bernhard's patch applied. No problems when compiled-in. Kernel 2.6.14-rc2-mm1, AGP compiled in, no DRM.

That's weird. Can you find out why the probe function is not called? Can

Stupid me, the i810_smbus driver grabbed the device and so the driver core didn't probe i810fb against it.
With that one out of the way, modprobing i810fb with the appropriate parameters correctly switches to graphics mode and fbcon gives me a nice console, with and without Bernhard's patch.

for reference:
modprobe i810fb mode_option=1024x768-8@60 hsync1=40 hsync2=60 vsync1=50 vsync2=70 vram=4

Signature · 1 line
 Manuel Lauss
#10 lore raw
Quoted 3 lines · Manuel Lauss

for reference:
modprobe i810fb mode_option=1024x768-8@60 hsync1=40 hsync2=60 vsync1=50 vsync2=70 vram=4

Can you try with 1024x768-16@60? That's what we're using in the installer (and what people reported to gable the display).

Thanks
bero

#11 lore raw
Quoted 9 lines · Bernhard Rosenkraenzer
Quoted 3 lines · Manuel Lauss

for reference:
modprobe i810fb mode_option=1024x768-8@60 hsync1=40 hsync2=60 vsync1=50 vsync2=70 vram=4

Can you try with 1024x768-16@60? That's what we're using in the installer (and what people reported to gable the display).

tried with -16 and -32, with/without accel=1, mtrr=1, extvga=1, no problems. I _do_ see problems with >8 bpp when warm-rebooting from windows. Cursor is a 8 character long random pixelpile or a 3x3 ch blinking block of text.
Cold boot and warm-rebooting from linux
are okay though (I suspect bios does not reset accel engine).

Signature · 1 line
 mano
#12 lore raw
In reply to Bernhard Rosenkraenzer
Quoted 9 lines · Bernhard Rosenkraenzer
Quoted 3 lines · Manuel Lauss

for reference:
modprobe i810fb mode_option=1024x768-8@60 hsync1=40 hsync2=60 vsync1=50 vsync2=70 vram=4

Can you try with 1024x768-16@60? That's what we're using in the installer (and what people reported to gable the display).

Are you using bootsplash in your installer kernels? Last time I tried that (2.4.22 iirc), it garbled the display horribly.

Signature · 1 line
 Manuel Lauss
#13 lore raw
In reply to Bernhard Rosenkraenzer
Quoted 8 lines · Bernhard Rosenkraenzer
Quoted 3 lines · Manuel Lauss

for reference:
modprobe i810fb mode_option=1024x768-8@60 hsync1=40 hsync2=60 vsync1=50 vsync2=70 vram=4

Can you try with 1024x768-16@60? That's what we're using in the installer (and what people reported to gable the display).

Try disabling I2C/DDC support of i810fb. A messed-up EDID block can give problems with the display.

Tony