UML TT-mode-only compile fix.
PATCH 1/1 UML TT-mode-only compile fix.
Hi,
In today's linus's git tree, uml doesn't compile when it's configured for only TT-mode.
This regression caused by:
8923648c125421b0fcb240cde607e2748d099ab8 [PATCH] uml: clear SKAS0/3 flags when running in TT mode
arch/um/kernel/um_arch.c +2 -0
@@ -334,8 +334,10 @@ int linux_main(int argc, char **argv)add_arg (DEFAULT_COMMAND_LINE );os_early_checks (); +#ifdef CONFIG_MODE_SKAS if (force_tt)clear_can_do_skas (); +#endif mode_tt = force_tt ?1 : !can_do_skas ();#ifndef CONFIG_MODE_TT if (mode_tt) {
Quoted 10 lines · Junichi Uekawa
Hi,
In today's linus's git tree, uml doesn't compile when it's configured for only TT-mode.
This regression caused by:
8923648c125421b0fcb240cde607e2748d099ab8 [PATCH] uml: clear SKAS0/3 flags when running in TT modeSigned-off-by Junichi Uekawa <[email protected]>
Thanks for the report and the patch, however I want to fix things a bit differently... the thing _should_ compile anyway.
The macro is declared anyway and the var should exist anyway. The problem is just that they aren't declared, I think. Will fix.
Quoted 14 lines
arch/um/kernel/um_arch.c +2
-0@@ -334,8 +334,10 @@ int linux_main(int argc, char **argv)add_arg (DEFAULT_COMMAND_LINE );os_early_checks (); +#ifdef CONFIG_MODE_SKAS if (force_tt)clear_can_do_skas (); +#endif mode_tt = force_tt ?1 : !can_do_skas ();#ifndef CONFIG_MODE_TT if (mode_tt) {
Signature · 11 lines
Inform me of my mistakes, so I can keep imitating Homer Simpson's "Doh!". Paolo Giarrusso, aka Blaisorblade (Skype ID "PaoloGiarrusso", ICQ 215621894) http://www.user-mode-linux.org/~blaisorblade ___________________________________ Yahoo! Mail: gratis 1GB per i messaggi e allegati da 10MB http://mail.yahoo.it
Quoted 5 lines · Blaisorblade
Thanks for the report and the patch, however I want to fix things a bit differently... the thing _should_ compile anyway.
The macro is declared anyway and the var should exist anyway. The problem is just that they aren't declared, I think. Will fix.
Junichi, ignore what I said earlier. If Blaisorblade wants to fix it differently, then we'll use his patch instead.
Jeff
-------------------------------------------------------
This SF.Net email is sponsored by:
Power Architecture Resource Center: Free content, downloads, discussions, and more. http://solutions.newsforge.com/ibmarch.tmpl
_______________________________________________
User-mode-linux-devel mailing list [email protected]
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel
Hi,
Quoted 9 lines · Blaisorblade
Quoted 5 lines
Thanks for the report and the patch, however I want to fix things a bit differently... the thing _should_ compile anyway.
The macro is declared anyway and the var should exist anyway. The problem is just that they aren't declared, I think. Will fix.
Junichi, ignore what I said earlier. If Blaisorblade wants to fix it differently, then we'll use his patch instead.
No problem with me.
regards,
junichi.
-------------------------------------------------------
This SF.Net email is sponsored by:
Power Architecture Resource Center: Free content, downloads, discussions, and more. http://solutions.newsforge.com/ibmarch.tmpl
_______________________________________________
User-mode-linux-devel mailing list [email protected]
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel
Quoted 10 lines · Junichi Uekawa
Hi,
In today's linus's git tree, uml doesn't compile when it's configured for only TT-mode.
This regression caused by:
8923648c125421b0fcb240cde607e2748d099ab8 [PATCH] uml: clear SKAS0/3 flags when running in TT modeSigned-off-by Junichi Uekawa <[email protected]>
Can you send this to Linus, with an Acked-by: me?
Jeff
-------------------------------------------------------
This SF.Net email is sponsored by:
Power Architecture Resource Center: Free content, downloads, discussions, and more. http://solutions.newsforge.com/ibmarch.tmpl
_______________________________________________
User-mode-linux-devel mailing list [email protected]
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel