Skip to contentSkip to conversation

qla2xxx: fix remote port timeout with qla2xxx driver

SCSI Olaf Hering 2 participants 2 messages Oct 10, 2005 – Oct 11, 2005 1 message not in the archive

Subsystems (2)
SCSI QLogic QLA2XXX FC-SCSI driver
lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

Olaf Hering

author
#1 lore raw
Quoted 10 lines · Linux Kernel Mailing List

tree e50f57f9c85bacf3fc07359b1a339432dea31a7a
parent 6f3a20242db2597312c50abc11f1e747c5d2326a
author Andrew Vasquez <[email protected]> Wed, 21 Sep 2005 03:32:11 -0700 committer James Bottomley <jejb@mulgrave.(none)> Sun, 25 Sep 2005 22:11:35 -0500

[SCSI] qla2xxx: fix remote port timeout with qla2xxx driver

drivers/scsi/qla2xxx/qla_rscn.c qla2x00_update_login_fcport(scsi_qla_hos · line 334

Quoted 5 lines
drivers/scsi/qla2xxx/qla_rscn.c +2 -0
@@ -330,6 +330,8 @@ qla2x00_update_login_fcport(scsi_qla_hos
 	fcport->flags &= ~FCF_FAILOVER_NEEDED;
 	fcport->iodesc_idx_sent = IODESC_INVALID_INDEX;
 	atomic_set(&fcport->state, FCS_ONLINE);
+	if (fcport->rport)
+		fc_remote_port_unblock(fcport->rport);

This patch lacks an #include, probably scsi/scsi_transport_fc.h:

drivers/scsi/qla2xxx/qla_rscn.c:334: error: implicit declaration of function 'fc_remote_port_unblock'

Signature · 2 lines
short story of a lazy sysadmin:
 alias appserv=wotan
#2 lore raw
Quoted 21 lines · Olaf Hering
Quoted 10 lines · Linux Kernel Mailing List

tree e50f57f9c85bacf3fc07359b1a339432dea31a7a
parent 6f3a20242db2597312c50abc11f1e747c5d2326a
author Andrew Vasquez <[email protected]> Wed, 21 Sep 2005 03:32:11 -0700 committer James Bottomley <jejb@mulgrave.(none)> Sun, 25 Sep 2005 22:11:35 -0500

[SCSI] qla2xxx: fix remote port timeout with qla2xxx driver

drivers/scsi/qla2xxx/qla_rscn.c qla2x00_update_login_fcport(scsi_qla_hos · line 334

Quoted 5 lines
drivers/scsi/qla2xxx/qla_rscn.c +2 -0
@@ -330,6 +330,8 @@ qla2x00_update_login_fcport(scsi_qla_hos
 	fcport->flags &= ~FCF_FAILOVER_NEEDED;
 	fcport->iodesc_idx_sent = IODESC_INVALID_INDEX;
 	atomic_set(&fcport->state, FCS_ONLINE);
+	if (fcport->rport)
+		fc_remote_port_unblock(fcport->rport);

This patch lacks an #include, probably scsi/scsi_transport_fc.h:

Quoted 1 line

drivers/scsi/qla2xxx/qla_rscn.c:334: error: implicit declaration of function 'fc_remote_port_unblock'

Yes, here's a one-liner to add the proper include.

---

drivers/scsi/qla2xxx/qla_rscn.c +2 -0
index 1eba988..11682a2 100644
@@ -18,6 +18,8 @@
  */
 #include "qla_def.h"
 
+#include <scsi/scsi_transport_fc.h>
+
 /**
  * IO descriptor handle definitions.
  *