radeonfb: prevent spurious recompilations

Hi Ben, all,

I'm doing frequent changes to the i2c header files, and noticed that the radeonfb driver was recompiled each time I do, although I did not include the I2C/DDC support. This is due to i2c header files being included when they are not needed. Here is a patch fixing the problem. Please consider applying it.

Thanks.

Prevent spurious recompilations of the radeonfb driver when I2C/DDC support is not included and i2c header files are modified.

 drivers/video/aty/radeon_base.c |    1 -
 drivers/video/aty/radeonfb.h    |    3 ++-
 2 files changed, 2 insertions(+), 2 deletions(-)

@@ -69,7 +69,6 @@
 #include <linux/pci.h>
 #include <linux/vmalloc.h>
 #include <linux/device.h>
-#include <linux/i2c.h>
 
 #include <asm/io.h>
 #include <asm/uaccess.h>

@@ -10,9 +10,10 @@
 #include <linux/fb.h>
 
 
+#ifdef CONFIG_FB_RADEON_I2C
 #include <linux/i2c.h>
-#include <linux/i2c-id.h>
 #include <linux/i2c-algo-bit.h>
+#endif
 
 #include <asm/io.h>
 

Jean Delvare


-------------------------------------------------------
This SF.Net email is sponsored by:
Power Architecture Resource Center: Free content, downloads, discussions,
and more. http://solutions.newsforge.com/ibmarch.tmpl

I generally quite dislike such #ifdef clutter ...

Ben.

-------------------------------------------------------
This SF.Net email is sponsored by:
Power Architecture Resource Center: Free content, downloads, discussions, and more. http://solutions.newsforge.com/ibmarch.tmpl

Hi Ben,

#ifdef CONFIG_FB_RADEON_I2C is already used 12 times in the radeonfb driver, I don't think one more time will really make a difference.

Or do you have a different fix for my problem, that you would prefer?

Thanks,
--
Jean Delvare

-------------------------------------------------------
This SF.Net email is sponsored by:
Power Architecture Resource Center: Free content, downloads, discussions, and more. http://solutions.newsforge.com/ibmarch.tmpl

Yah, that sucks, I should fix that

Nah, just submit that patch for now, I'll do a better fix later

Ben.

-------------------------------------------------------
This SF.Net email is sponsored by:
Power Architecture Resource Center: Free content, downloads, discussions, and more. http://solutions.newsforge.com/ibmarch.tmpl

Hi Ben,

Submit to whom? I thought you were the right person (and the linux-fbdev-devel list the right place) to submit it to.

Thanks,
--
Jean Delvare

-------------------------------------------------------
This SF.Net email is sponsored by:
Power Architecture Resource Center: Free content, downloads, discussions, and more. http://solutions.newsforge.com/ibmarch.tmpl