Skip to contentSkip to conversation

small Kconfig help text correction for CONFIG_FRAME_POINTER

PATCH In review Jesper Juhl 3 participants 4 messages Oct 11, 2005 – Oct 12, 2005 Library code

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 small Kconfig help text correction for CONFIG_FRAME_POINTER

Fix-up the CONFIG_FRAME_POINTER help text language a bit.

---

"on some architectures or you use external debuggers"
doesn't sound too good
"on some architectures or if you use external debuggers"
is better.

 lib/Kconfig.debug |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
lib/Kconfig.debug +2 -2
@@ -174,7 +174,7 @@
 	default y if DEBUG_INFO && UML
 	help
 	  If you say Y here the resulting kernel image will be slightly larger
-	  and slower, but it might give very useful debugging information
-	  on some architectures or you use external debuggers.
+	  and slower, but it might give very useful debugging information on
+	  some architectures or if you use external debuggers.
 	  If you don't debug the kernel, you can say N.
 
#1 lore raw
Quoted 9 lines · Jesper Juhl

Fix-up the CONFIG_FRAME_POINTER help text language a bit.

---

"on some architectures or you use external debuggers"
doesn't sound too good
"on some architectures or if you use external debuggers"
is better.

Why bother anyway since the original is brief and neat. (yours could be s/if/when/ even)

Coywolf

Quoted 19 lines
 lib/Kconfig.debug |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
lib/Kconfig.debug +2 -3
@@ -174,7 +174,7 @@
 	default y if DEBUG_INFO && UML
 	help
 	  If you say Y here the resulting kernel image will be slightly larger
-	  and slower, but it might give very useful debugging information
-	  on some architectures or you use external debuggers.
+	  and slower, but it might give very useful debugging information on
+	  some architectures or if you use external debuggers.
 	  If you don't debug the kernel, you can say N.
 
 
 
-
#2 lore raw
Quoted 4 lines · Coywolf Qi Hunt

On Tue, Oct 11, 2005 at 11:22:21PM +0200, Jesper Juhl wrote:

Why bother anyway since the original is brief and neat. (yours could be s/if/when/ even)

I would definitely agree with Jesper that the current version needs changing. However, I don't know technically whether it means:

a) you will need an external debugger to get this information
b) this information will be available in the log (etc) and ALSO via an external debugger

regards,
Felix

Quoted 7 lines
Quoted 7 lines
lib/Kconfig.debug +2 -2
 	  If you say Y here the resulting kernel image will be slightly larger
-	  and slower, but it might give very useful debugging information
-	  on some architectures or you use external debuggers.
+	  and slower, but it might give very useful debugging information on
+	  some architectures or if you use external debuggers.
 	  If you don't debug the kernel, you can say N.
#3 lore raw
In reply to Coywolf Qi Hunt
Quoted 6 lines · Coywolf Qi Hunt
Quoted 5 lines · Jesper Juhl

Fix-up the CONFIG_FRAME_POINTER help text language a bit.

---

Quoted 8 lines
Quoted 4 lines

"on some architectures or you use external debuggers"
doesn't sound too good
"on some architectures or if you use external debuggers"
is better.

Why bother anyway since the original is brief and neat. (yours could be s/if/when/ even)

We can argue the exact wording (using "when" is probably better, I agree), but the current text is just not proper english.

--
Jesper Juhl <[email protected]>
Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please http://www.expita.com/nomime.html