Make physmap messages more user friendly
PATCH 1/1 Make physmap messages more user friendly
Can I commit the following to CVS? It makes the message a bit more readalbe (and obvious that it is in hex) and tells the user if the probe failed.
drivers/mtd/maps/physmap.c +5 -2
@@ -50,11 +50,12 @@ static int __init init_physmap(void)static const char *rom_probe_types[] = {"cfi_probe" ,"jedec_probe" ,"map_rom" ,NULL };const char **type; -printk (KERN_NOTICE "physmap flash device: %lx at %lx\n" , physmap_map.size, physmap_map.phys); +printk (KERN_NOTICE "MTD physmap flash device: %#010lx @ %#010lx\n" , + physmap_map.size, physmap_map.phys); physmap_map.virt =ioremap (physmap_map.phys, physmap_map.size);if (!physmap_map.virt) { -printk ("Failed to ioremap\n" ); +printk ("MTD physmap: Failed to ioremap\n" );return -EIO ; }
@@ -90,6 +91,8 @@ static int __init init_physmap(void)add_mtd_device (mymtd);return 0 ; + }else { +printk ("MTD physmap: failed to probe flash\n" ); }iounmap (physmap_map.virt);
Signature · 3 lines
Deepak Saxena - [email protected] - http://www.plexity.net Even a stopped clock gives the right time twice a day.
Quoted 4 lines · Deepak Saxena
Can I commit the following to CVS? It makes the message a bit more readalbe (and obvious that it is in hex) and tells the user if the probe failed.
I'd like to wait until tglx considers cvs stable enough for a mainline merge. Thomas, besides the general lack of time, are there any major blockers left?
Quoted 21 lines
Signed-off-by Deepak Saxena <[email protected]>drivers/mtd/maps/physmap.c +3
-2@@ -50,11 +50,12 @@ static int __init init_physmap(void)static const char *rom_probe_types[] = {"cfi_probe" ,"jedec_probe" ,"map_rom" ,NULL };const char **type; -printk (KERN_NOTICE "physmap flash device: %lx at %lx\n" , physmap_map.size, physmap_map.phys); +printk (KERN_NOTICE "MTD physmap flash device: %#010lx @ %#010lx\n" , + physmap_map.size, physmap_map.phys); physmap_map.virt =ioremap (physmap_map.phys, physmap_map.size);if (!physmap_map.virt) { -printk ("Failed to ioremap\n" ); +printk ("MTD physmap: Failed to ioremap\n" );return -EIO ; }
drivers/mtd/maps/physmap.c static int __init init_physmap(void) · line 95
Quoted 5 lines
drivers/mtd/maps/physmap.c +2
-0@@ -90,6 +91,8 @@ static int __init init_physmap(void)add_mtd_device (mymtd);return 0 ; + }else { +printk ("MTD physmap: failed to probe flash\n" );
^
All other messages were KERN_NOTICE.
drivers/mtd/maps/physmap.c static int __init init_physmap(void) · line 98
Quoted 4 lines
drivers/mtd/maps/physmap.c +0
-0}iounmap (physmap_map.virt);
Jörn
Signature · 3 lines
Mundie uses a textbook tactic of manipulation: start with some reasonable talk, and lead the audience to an unreasonable conclusion. -- Bruce Perens
Quoted 9 lines · Jörn Engel
Quoted 4 lines · Deepak Saxena
Can I commit the following to CVS? It makes the message a bit more readalbe (and obvious that it is in hex) and tells the user if the probe failed.
I'd like to wait until tglx considers cvs stable enough for a mainline merge. Thomas, besides the general lack of time, are there any major blockers left?
Not that I'm aware of. I put it on the agenda for the weekend.
tglx