Skip to contentSkip to conversation

: Fix infinite loop in udp_v6_get_port().

SECURITY,2.4,IPV6 Horms 1 participant 1 message Oct 27, 2005

Subsystems (2)
lore
Share & tools
lore

Horms

author
#0 lore raw

[IPV6]: Fix infinite loop in udp_v6_get_port()

This is CVE-2005-2973, and 87bf9c97b4b3af8dec7b2b79cdfe7bfc0a0a03b2 in Linus' 2.6 Git Tree. It seems to be relevant to 2.4

[IPV6]: Fix infinite loop in udp_v6_get_port()

Original sign-off

Mine, indicating that I think it is relevant to 2.4

net/ipv6/udp.c +3 -1
index 471180b..4395aa4 100644
@@ -89,7 +89,7 @@ static int udp_v6_get_port(struct sock *
 		next:;
 		}
 		result = best;
-		for(;; result += UDP_HTABLE_SIZE) {
+		for(i = 0; i < (1 << 16) / UDP_HTABLE_SIZE; i++, result += UDP_HTABLE_SIZE) {
 			if (result > sysctl_local_port_range[1])
 				result = sysctl_local_port_range[0]
 					+ ((result - sysctl_local_port_range[0]) &
@@ -97,6 +97,8 @@ static int udp_v6_get_port(struct sock *
 			if (!udp_lport_inuse(result))
 				break;
 		}
+		if (i >= (1 << 16) / UDP_HTABLE_SIZE)
+			goto fail;
 gotit:
 		udp_port_rover = snum = result;
 	} else {