mips: prom_free_prom_memory() returns `unsigned long'

PATCH In review Arthur Othieno 2 participants 2 messages Oct 28, 2005 MIPS

lore

Share & tools

lore

Arthur Othieno

author

2005-10-28 04:43 UTC #0 lore raw

PATCH 1/1 mips: prom_free_prom_memory() returns `unsigned long'

Hi,

Some boards have, eg.:

arch/mips/momentum/ocelot_3/prom.c:242:void __init prom_free_prom_memory(void)

yet free_initmem() expects a return:

  arch/mips/mm/init.c:285:extern unsigned long prom_free_prom_memory(void);
  arch/mips/mm/init.c:291:	freed = prom_free_prom_memory();

Fix those up and return 0 instead, just like everyone else does.

Signed-off-by Arthur Othieno <[email protected]>

---

 arch/mips/momentum/jaguar_atx/prom.c |    3 ++-
 arch/mips/momentum/ocelot_3/prom.c   |    3 ++-
 arch/mips/pmc-sierra/yosemite/prom.c |    3 ++-
 3 files changed, 6 insertions(+), 3 deletions(-)

718345abbb965ef544659d6cb0e90dee1535107b

arch/mips/momentum/jaguar_atx/prom.c +2 -1

@@ -236,8 +236,9 @@ void __init prom_init(void)
 #endif
 }
 
-void __init prom_free_prom_memory(void)
+unsigned long __init prom_free_prom_memory(void)
 {
+	return 0;
 }
 
 void __init prom_fixup_mem_map(unsigned long start, unsigned long end)

arch/mips/momentum/ocelot_3/prom.c +2 -1

@@ -239,8 +239,9 @@ void __init prom_init(void)
 #endif
 }
 
-void __init prom_free_prom_memory(void)
+unsigned long __init prom_free_prom_memory(void)
 {
+	return 0;
 }
 
 void __init prom_fixup_mem_map(unsigned long start, unsigned long end)

arch/mips/pmc-sierra/yosemite/prom.c +2 -1

@@ -132,8 +132,9 @@ void __init prom_init(void)
 	prom_grab_secondary();
 }
 
-void __init prom_free_prom_memory(void)
+unsigned long __init prom_free_prom_memory(void)
 {
+	return 0;
 }
 
 void __init prom_fixup_mem_map(unsigned long start, unsigned long end)

Ralf Baechle

2005-10-28 10:12 UTC #1 lore raw

Quoted 10 lines · Arthur Othieno

Some boards have, eg.:
arch/mips/momentum/ocelot_3/prom.c:242:void __init prom_free_prom_memory(void)
yet free_initmem() expects a return:
  arch/mips/mm/init.c:285:extern unsigned long prom_free_prom_memory(void);
  arch/mips/mm/init.c:291:	freed = prom_free_prom_memory();
Fix those up and return 0 instead, just like everyone else does.

Thanks alot, applied.

Ralf