Skip to contentSkip to conversation

fix XFS_QUOTA for modular XFS

PATCH In review Adrian Bunk 3 participants 4 messages Oct 28, 2005 – Oct 31, 2005

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 fix XFS_QUOTA for modular XFS

This patch by Dimitri Puzin submitted through kernel Bugzilla #5514 fixes the following issue:

Cannot build XFS filesystem support as module with quota support. It works only when the XFS filesystem support is compiled into the kernel. Menuconfig prevents from setting CONFIG_XFS_FS=m and CONFIG_XFS_QUOTA=y.

How to reproduce: configure the XFS filesystem with quota support as module. The resulting kernel won't have quota support compiled into xfs.ko.

Fix: Changing the fs/xfs/Kconfig file from tristate to bool lets you configure the quota support to be compiled into the XFS module. The Makefile-linux-2.6 checks only for CONFIG_XFS_QUOTA=y.

From: Dimitri Puzin <[email protected]>

fs/xfs/Kconfig renamed from fs/xfs/Kconfig.old +1 -1
@@ -24,7 +24,7 @@
 	default y
 
 config XFS_QUOTA
-	tristate "XFS Quota support"
+	bool "XFS Quota support"
 	depends on XFS_FS
 	help
 	  If you say Y here, you will be able to set limits for disk usage on
#2 lore raw
In reply to Adrian Bunk
Quoted 6 lines · * Adrian Bunk ([email protected]) wrote:

This patch by Dimitri Puzin submitted through kernel Bugzilla #5514 fixes the following issue:

Cannot build XFS filesystem support as module with quota support. It works only when the XFS filesystem support is compiled into the kernel. Menuconfig prevents from setting CONFIG_XFS_FS=m and CONFIG_XFS_QUOTA=y.

Thanks, will queue for -stable, but this hasn't made it upstream yet.

thanks,
-chris

#3 lore raw
Quoted 9 lines · Chris Wright
Quoted 6 lines · * Adrian Bunk ([email protected]) wrote:

This patch by Dimitri Puzin submitted through kernel Bugzilla #5514 fixes the following issue:

Cannot build XFS filesystem support as module with quota support. It works only when the XFS filesystem support is compiled into the kernel. Menuconfig prevents from setting CONFIG_XFS_FS=m and CONFIG_XFS_QUOTA=y.

Thanks, will queue for -stable, but this hasn't made it upstream yet.

Sorry, public holiday here has meant no action on that front - it is "good to go" though, and will be sent to Linus when I'm back in the office.

cheers.

Signature · 1 line
Nathan