Skip to contentSkip to conversation

remove Scsi_Host.eh_active

PATCH In review Christoph Hellwig 1 participant 1 message Oct 28, 2005 SCSI

lore
Share & tools
lore
#0 lore raw

PATCH 2/2 remove Scsi_Host.eh_active

now that the abuse in qla2xxx is gone this field can be remove.

drivers/scsi/scsi_error.c +0 -4
Index: linux-2.6/drivers/scsi/scsi_error.c
===================================================================
@@ -1613,8 +1613,6 @@
 			printk("Error handler scsi_eh_%d waking up\n",
 				shost->host_no));
 
-		shost->eh_active = 1;
-
 		/*
 		 * We have a host that is failing for some reason.  Figure out
 		 * what we need to do to get it up and online again (if we can).
@@ -1625,8 +1623,6 @@
 		else
 			scsi_unjam_host(shost);
 
-		shost->eh_active = 0;
-
 		/*
 		 * Note - if the above fails completely, the action is to take
 		 * individual devices offline and flush the queue of any
include/scsi/scsi_host.h +0 -2
Index: linux-2.6/include/scsi/scsi_host.h
===================================================================
@@ -469,8 +469,6 @@
 	struct task_struct    * ehandler;  /* Error recovery thread. */
 	struct semaphore      * eh_action; /* Wait for specific actions on the
                                           host. */
-	unsigned int            eh_active:1; /* Indicates the eh thread is awake and active if
-                                          this is true. */
 	wait_queue_head_t       host_wait;
 	struct scsi_host_template *hostt;
 	struct scsi_transport_template *transportt;