bluetooth hidp is broken on s390

PATCH In review Al Viro 3 participants 4 messages Oct 29, 2005 – Oct 31, 2005 Bluetooth

Share & tools

Al Viro

author

2005-10-29 11:02 UTC #0 lore raw

PATCH 1/1 bluetooth hidp is broken on s390

Bluetooth HIDP selects INPUT and it really needs it to be
there - module depends on input core. And input core is never built on s390... Marked as broken on s390, for now; if somebody has better ideas, feel free to fix it and remove dependency...

Signed-off-by Al Viro <[email protected]>

----

net/bluetooth/hidp/Kconfig +1 -1

diff -urN RC14-base/net/bluetooth/hidp/Kconfig current/net/bluetooth/hidp/Kconfig
@@ -1,6 +1,6 @@
 config BT_HIDP
 	tristate "HIDP protocol support"
-	depends on BT && BT_L2CAP
+	depends on BT && BT_L2CAP && (BROKEN || !S390)
 	select INPUT
 	help
 	  HIDP (Human Interface Device Protocol) is a transport layer

Marcel Holtmann

maintainer

2005-10-29 11:06 UTC #1 lore raw

Hi Al,

Quoted 6 lines

Bluetooth HIDP selects INPUT and it really needs it to be
there - module depends on input core. And input core is never built on s390... Marked as broken on s390, for now; if somebody has better ideas, feel free to fix it and remove dependency...
Signed-off-by Al Viro <[email protected]>

basically I think someone should fix the input layer on S390, but I am fine with your fix.

Signed-off-by Marcel Holtmann <[email protected]>

Regards

Marcel

Al Viro

author

2005-10-29 18:48 UTC #2 lore raw

Quoted 11 lines · Marcel Holtmann

Hi Al,
Quoted 6 lines
Bluetooth HIDP selects INPUT and it really needs it to be
there - module depends on input core. And input core is never built on s390... Marked as broken on s390, for now; if somebody has better ideas, feel free to fix it and remove dependency...
Signed-off-by Al Viro <[email protected]>
basically I think someone should fix the input layer on S390, but I am fine with your fix.

There's a problem with that patch, though ;-/ S390 is never defined by arch/s390/Kconfig; ARCH_S390 is. From the fast grep it looks like there is one more place with the same problem: drivers/char/Kconfig has config HW_CONSOLE

        bool
        depends on VT && !S390 && !UML
        default y

and the second term is always true here. Why do we have that dependency, anyway, when s390 doesn't include drivers/char/Kconfig at all?

Martin Schwidefsky

2005-10-31 09:01 UTC #3 lore raw

Quoted 8 lines · Al Viro

Quoted 7 lines · Marcel Holtmann
Hi Al,
Quoted 5 lines
Bluetooth HIDP selects INPUT and it really needs it to be
there - module depends on input core. And input core is never built on s390... Marked as broken on s390, for now; if somebody has better ideas, feel free to fix it and remove dependency...

Quoted 4 lines

Quoted 4 lines
Quoted 1 line
Signed-off-by Al Viro <[email protected]>
basically I think someone should fix the input layer on S390, but I am fine with your fix.

And since there isn't a Bluetooth device on s390 (yet), we can live with the broken input core for now. Would be nicer if the input layer would work but there are more important things..

Quoted 9 lines

There's a problem with that patch, though ;-/ S390 is never defined by arch/s390/Kconfig; ARCH_S390 is. From the fast grep it looks like there is one more place with the same problem: drivers/char/Kconfig has config HW_CONSOLE
        bool
        depends on VT && !S390 && !UML
        default y
and the second term is always true here. Why do we have that dependency, anyway, when s390 doesn't include drivers/char/Kconfig at all?

.. e.g. this one. I tried to cleanup the Kconfig for s390 once. After the patch has grown over 2000 lines of code I gave up. If you have the feeling that this should be fixed I'll give it another try. At least the issue with ARCH_S390/ARCH_S390X vs. S390/S390_64 should be fixed.

Signature · 6 lines

blue skies,
   Martin

Martin Schwidefsky
Linux for zSeries Development & Services
IBM Deutschland Entwicklung GmbH