megaraid_sas: fix EH locking

PATCH New Christoph Hellwig 1 participant 1 message Oct 31, 2005

Subsystems (2)

SCSI Megaraid SCSI/SAS drivers

lore

Share & tools

lore

Christoph Hellwig

author

2005-10-31 18:51 UTC #0 lore raw

PATCH 1/1 megaraid_sas: fix EH locking

recent kernels call the eh_ methods without the host lock held. megaraid_sas doesn't need it but drops it before calling a sleeping routine and reqcquires it afterwards. Just remove the spin_unlock/spin_lock calls.

Signed-off-by Christoph Hellwig <[email protected]>

drivers/scsi/megaraid/megaraid_sas.c +0 -5

Index: linux-2.6/drivers/scsi/megaraid/megaraid_sas.c
===================================================================
@@ -768,17 +764,12 @@
 		return FAILED;
 	}
 
-	spin_unlock(scmd->device->host->host_lock);
-
 	ret_val = megasas_wait_for_outstanding(instance);
-
 	if (ret_val == SUCCESS)
 		printk(KERN_NOTICE "megasas: reset successful \n");
 	else
 		printk(KERN_ERR "megasas: failed to do reset\n");
 
-	spin_lock(scmd->device->host->host_lock);
-
 	return ret_val;
 }