remove fs/jffs2/ioctl.c
RFC PATCH 1/1 remove fs/jffs2/ioctl.c
Is there any reason for keeping fs/jffs2/ioctl.c?
Signed-off-by Adrian Bunk <[email protected]>
---
fs/jffs2/Makefile | 2 +- fs/jffs2/dir.c | 1 - fs/jffs2/file.c | 1 - fs/jffs2/ioctl.c | 23 ----------------------- fs/jffs2/os-linux.h | 3 --- 5 files changed, 1 insertion(+), 29 deletions(-)
fs/jffs2/os-linux.h renamed from fs/jffs2/os-linux.h.old +0 -3
@@ -147,9 +147,6 @@int jffs2_fsync (struct file *,struct dentry *,int );int jffs2_do_readpage_unlock (struct inode *inode,struct page *pg); -/* ioctl.c */ -int jffs2_ioctl (struct inode *,struct file *,unsigned int ,unsigned long ); -/* symlink.c */ extern struct inode_operations jffs2_symlink_inode_operations;
fs/jffs2/dir.c renamed from fs/jffs2/dir.c.old +0 -1
@@ -41,7 +41,6 @@ { .read = generic_read_dir, .readdir = jffs2_readdir, - .ioctl = jffs2_ioctl, .fsync = jffs2_fsync };
fs/jffs2/file.c renamed from fs/jffs2/file.c.old +0 -1
@@ -44,7 +44,6 @@ .open = generic_file_open, .read = generic_file_read, .write = generic_file_write, - .ioctl = jffs2_ioctl, .mmap = generic_file_readonly_mmap, .fsync = jffs2_fsync, .sendfile = generic_file_sendfile
fs/jffs2/Makefile renamed from fs/jffs2/Makefile.old +1 -1
@@ -6,7 +6,7 @@ obj-$(CONFIG_JFFS2_FS) += jffs2.o -jffs2-y := compr.o dir.o file.o ioctl.o nodelist.o malloc.o +jffs2-y := compr.o dir.o file.o nodelist.o malloc.o jffs2-y += read.o nodemgmt.o readinode.o write.o scan.o gc.o jffs2-y += symlink.o build.o erase.o background.o fs.o writev.o jffs2-y += super.o
fs/jffs2/ioctl.c deleted +0 -23
@@ -1,23 +0,0 @@ -/* -* JFFS2 -- Journalling Flash File System, Version 2. -* -* Copyright (C) 2001-2003 Red Hat, Inc. -* -* Created by David Woodhouse <[email protected]> -* -* For licensing information, see the file 'LICENCE' in this directory. -* -* $Id: ioctl.c,v 1.9 2004/11/16 20:36:11 dwmw2 Exp $ -* -*/ - -#include <linux/fs.h> - -int jffs2_ioctl (struct inode *inode,struct file *filp,unsigned int cmd, -unsigned long arg) -{ -/* Later, this will provide for lsattr.jffs2 and chattr.jffs2, which -will include compression support etc. */ -return -ENOTTY ; -} -
Quoted 1 line · Adrian Bunk
Is there any reason for keeping
fs/jffs2/ioctl.c?
I can think of some various things that could be done with it, but that would require time and effort. Unless David or Thomas have an objections, I think it can go.
josh
Quoted 6 lines · Josh Boyer
Quoted 1 line · Adrian Bunk
Is there any reason for keeping
fs/jffs2/ioctl.c?I can think of some various things that could be done with it, but that would require time and effort. Unless David or Thomas have an objections, I think it can go.
And for the last couple of years, no problem seemed urgent enough for someone to actually implement something. I vote for removal.
Jörn
Signature · 2 lines
This above all: to thine own self be true. -- Shakespeare