Skip to contentSkip to conversation

pktgen: remove useless assignment

PATCH New Adrian Bunk 1 participant 1 message Nov 2, 2005

Subsystems (2)
Networking Network drivers
lore
Share & tools
lore

Adrian Bunk

author
#0 lore raw

PATCH 1/1 pktgen: remove useless assignment

On main codepath pkt_dev is immediately rewritten. On error codepath it isn't used.

Noticed by Coverity checker.

From: Alexey Dobriyan <[email protected]>

Signed-off-by Alexey Dobriyan <[email protected]>
Signed-off-by Adrian Bunk <[email protected]>
net/core/pktgen.c +1 -1
@@ -2882,7 +2882,7 @@ static int pktgen_add_device(struct pktg
 	
 	/* We don't allow a device to be on several threads */
 
-	if( (pkt_dev = __pktgen_NN_threads(ifname, FIND)) == NULL) {
+	if(__pktgen_NN_threads(ifname, FIND) == NULL) {
 						   
 		pkt_dev = kmalloc(sizeof(struct pktgen_dev), GFP_KERNEL);
                 if (!pkt_dev)