Skip to contentSkip to conversation

: linux-2.6.14-uc0 (MMU-less support)

PATCH Milton Miller 3 participants 4 messages Nov 5, 2005 – Nov 7, 2005

lore
Share & tools
lore
#0 lore raw
Quoted 8 lines · Greg Ungerer

Hi All,

An update of the uClinux (MMU-less) fixups against 2.6.14.

Some new platform support, for the 5207/5208 ColdFire parts. A few bug fixes and some other minor cleanups.

http://www.uclinux.org/pub/uClinux/uClinux-2.6.x/linux-2.6.14-uc0.patch.gz

Hi Greg.

I'm not a user but thought I would give it a once over to see what you were carrying.

Review

Quoted 9 lines

/*
+ * The Freescale 5208EVB board has 32MB of RAM.
+ */

(quoted diff) +6 -0
+#if defined(CONFIG_M5208EVB)
+#define	RAM_START	0x40020000
+#define	RAM_LENGTH	0x01e00000
+#endif
+
+/*

That doesn't quite add up to 32MB. Should that be 0x1FE0000 or is the last 0x1E0000 (1920k) supposed to be reserved too? Again, I am not a user.

Quoted 35 lines

diff -Naur linux-2.6.14/drivers/net/Kconfig linux-2.6.14-uc0/drivers/net/Kconfig
--- linux-2.6.14/drivers/net/Kconfig 2005-10-31 15:39:46.000000000
+1000
+++ linux-2.6.14-uc0/drivers/net/Kconfig 2005-10-31 15:41:58.000000000
+1000

(quoted diff) +1 -1
@@ -730,7 +730,7 @@
 
 config NET_VENDOR_SMC
 	bool "Western Digital/SMC cards"
-	depends on NET_ETHERNET && (ISA || MCA || EISA || MAC)
+	depends on NET_ETHERNET && (ISA || MCA || EISA || MAC || EMBEDDED)
 	help
 	  If you have a network (Ethernet) card belonging to this class, say  

Y

(quoted diff) +2 -2
 	  and read the Ethernet-HOWTO, available from
@@ -820,7 +820,7 @@
 
 config SMC9194
 	tristate "SMC 9194 support"
-	depends on NET_VENDOR_SMC && (ISA || MAC && BROKEN)
+	depends on NET_VENDOR_SMC && (ISA || MAC && BROKEN || EMBEDDED)
 	select CRC32
 	---help---
 	  This is support for the SMC9xxx based Ethernet cards. Choose this
@@ -1059,7 +1059,7 @@
 
 config NE2000
 	tristate "NE2000/NE1000 support"
-	depends on NET_ISA || (Q40 && m) || M32R
+	depends on NET_ISA || (Q40 && m) || M32R || EMBEDDED
 	select CRC32
 	---help---
 	  If you have a network (Ethernet) card of this type, say Y and read

Review line 1196

Quoted 8 lines
(quoted diff) +1 -1
@@ -1190,7 +1190,7 @@
 
 config NET_PCI
 	bool "EISA, VLB, PCI and on board controllers"
-	depends on NET_ETHERNET && (ISA || EISA || PCI)
+	depends on NET_ETHERNET && (ISA || EISA || PCI || EMBEDDED)
 	help
 	  This is another class of network cards which attach directly to the
 	  bus. If you have one of those, say Y and read the Ethernet-HOWTO,

Lots of people turn on EMBEDDED for lots of reasons, asking about a lot more drivers seems burdensome.

Care to create a single intermediate Kconfig var for those? Something like "Controllers attached directly to a cpu?"

Review

Quoted 10 lines
(quoted diff) +6 -0
+config CS89x0_SWAPPED
+	bool "Hardware swapped CS89x0"
+	depends on CS89x0 && !NET_PCI && !ISA
+	---help---
+	  Say Y if your CS89x0 data bus is swapped.
+	  This option is for single board computers using a CS89x0 chip. If  

you

(quoted diff) +2 -0
+	  are using a regular Ethernet card, say N.
+

This would then depend on your directly attached config and you could have both it and pci configured.

Review

Quoted 6 lines

ifdef CONFIG_CC_OPTIMIZE_FOR_SIZE

(quoted diff) +1 -1
-CFLAGS		+= -Os
+CFLAGS		+= -O
 else
 CFLAGS		+= -O2
 endif

Sees this undoes part of the benefit, perhaps you should add a third option.

milton

#1 lore raw
Quoted 16 lines · Milton Miller

On Tue Nov 01 2005 - 23:01:02 EST, Greg Ungerer wrote:
...

Quoted 10 lines
(quoted diff) +0 -0
@@ -1190,7 +1190,7 @@
 

config NET_PCI
bool "EISA, VLB, PCI and on board controllers"

(quoted diff) +1 -1
-	depends on NET_ETHERNET && (ISA || EISA || PCI)
+	depends on NET_ETHERNET && (ISA || EISA || PCI || EMBEDDED)

help
This is another class of network cards which attach directly to the bus. If you have one of those, say Y and read the Ethernet-HOWTO,

Lots of people turn on EMBEDDED for lots of reasons, asking about a lot more drivers seems burdensome.

Quoted 2 lines

Care to create a single intermediate Kconfig var for those? Something like "Controllers attached directly to a cpu?"

It seems the real problem is a misunderstanding regarding the semantics of EMBEDDED.

EMBEDDED is _not_ strictly connected to any usage of the kernel.

All EMBEDDED does is to offer additional option for people needing a small kernel in space-limited environments.

CC_OPTIMIZE_FOR_SIZE is one example, but it also allows to e.g. deselect futex support.

(ISA || EISA || PCI || EMBEDDED) doesn't make any sense since this dependency expresses the supported busses. If this was required for any purpose, it should be reported to find a proper solution.

Quoted 10 lines

...

Quoted 6 lines

ifdef CONFIG_CC_OPTIMIZE_FOR_SIZE

(quoted diff) +1 -1
-CFLAGS		+= -Os
+CFLAGS		+= -O

else
CFLAGS += -O2
endif

Sees this undoes part of the benefit, perhaps you should add a third option.

Even further, I don't see any reason for using -O - the resulting code is expected to be both bigger and slower than with -Os.

Is this a workaround for a gcc bug on some platform?

Quoted 1 line

milton

cu
Adrian

Signature · 4 lines
       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed
#2 lore raw

Hi Adrian,

Quoted 12 lines · Adrian Bunk
Quoted 10 lines
Quoted 7 lines

ifdef CONFIG_CC_OPTIMIZE_FOR_SIZE

(quoted diff) +1 -1
-CFLAGS		+= -Os
+CFLAGS		+= -O

else
CFLAGS += -O2
endif

Sees this undoes part of the benefit, perhaps you should add a third option.

Quoted 3 lines

Even further, I don't see any reason for using -O - the resulting code is expected to be both bigger and slower than with -Os.

Is this a workaround for a gcc bug on some platform?

Yes, extacly, it is. See other post on this for more details. Still shouldn't be here though.

Regards
Greg

------------------------------------------------------------------------

Greg Ungerer  --  Chief Software Dude       EMAIL:     [email protected]
SnapGear -- a CyberGuard Company            PHONE:       +61 7 3435 2888
825 Stanley St,                             FAX:         +61 7 3891 3630
Woolloongabba, QLD, 4102, Australia         WEB: http://www.SnapGear.com
#3 lore raw
In reply to Milton Miller

Hi Milton,

Quoted 14 lines · Milton Miller
Quoted 6 lines · Greg Ungerer

An update of the uClinux (MMU-less) fixups against 2.6.14.

Some new platform support, for the 5207/5208 ColdFire parts. A few bug fixes and some other minor cleanups.

http://www.uclinux.org/pub/uClinux/uClinux-2.6.x/linux-2.6.14- uc0.patch.gz

Hi Greg.

I'm not a user but thought I would give it a once over to see what you were carrying.

Quoted 14 lines

Review

Quoted 9 lines

/*
+ * The Freescale 5208EVB board has 32MB of RAM.
+ */

(quoted diff) +6 -0
+#if defined(CONFIG_M5208EVB)
+#define    RAM_START    0x40020000
+#define    RAM_LENGTH    0x01e00000
+#endif
+
+/*

That doesn't quite add up to 32MB. Should that be 0x1FE0000 or is the last 0x1E0000 (1920k) supposed to be reserved too? Again, I am not a user.

Yeah, your right, that should be 0x1fe0000. Looks like a yank bug.

Quoted 48 lines
Quoted 41 lines

diff -Naur linux-2.6.14/drivers/net/Kconfig linux-2.6.14-uc0/drivers/net/Kconfig
--- linux-2.6.14/drivers/net/Kconfig 2005-10-31 15:39:46.000000000
+1000
+++ linux-2.6.14-uc0/drivers/net/Kconfig 2005-10-31
15:41:58.000000000 +1000

(quoted diff) +1 -1
@@ -730,7 +730,7 @@
 
 config NET_VENDOR_SMC
     bool "Western Digital/SMC cards"
-    depends on NET_ETHERNET && (ISA || MCA || EISA || MAC)
+    depends on NET_ETHERNET && (ISA || MCA || EISA || MAC || EMBEDDED)
     help
       If you have a network (Ethernet) card belonging to this class, 

say Y
and read the Ethernet-HOWTO, available from

(quoted diff) +3 -3
@@ -820,7 +820,7 @@
 
 config SMC9194
     tristate "SMC 9194 support"
-    depends on NET_VENDOR_SMC && (ISA || MAC && BROKEN)
+    depends on NET_VENDOR_SMC && (ISA || MAC && BROKEN || EMBEDDED)
     select CRC32
     ---help---
       This is support for the SMC9xxx based Ethernet cards. Choose this
@@ -1059,7 +1059,7 @@
 
 config NE2000
     tristate "NE2000/NE1000 support"
-    depends on NET_ISA || (Q40 && m) || M32R
+    depends on NET_ISA || (Q40 && m) || M32R || EMBEDDED
     select CRC32
     ---help---
       If you have a network (Ethernet) card of this type, say Y and read
@@ -1190,7 +1190,7 @@
 
 config NET_PCI
     bool "EISA, VLB, PCI and on board controllers"
-    depends on NET_ETHERNET && (ISA || EISA || PCI)
+    depends on NET_ETHERNET && (ISA || EISA || PCI || EMBEDDED)
     help
       This is another class of network cards which attach directly to 
Quoted 3 lines

the
bus. If you have one of those, say Y and read the Ethernet-HOWTO,

Lots of people turn on EMBEDDED for lots of reasons, asking about a lot more drivers seems burdensome.

Quoted 2 lines

Care to create a single intermediate Kconfig var for those? Something like "Controllers attached directly to a cpu?"

Yes indeed, this is a mis-use of CONFIG_EMBEDDED.

I would be happy to see another config option for another more generic bus type. There is a whole bunch of peripherals that are attached to directly (or at least to some other fixed) bus type - not just network adapters.

I can see that some will argue that these are ISA bus peripherals, therefore CONFIG_ISA should be enabled. Maybe. But in this type of deeply embedded hardware it is not hooked up to an ISA bus in the normal sense. Typically there is some dedicated logic to massage the signals just enough for the periperal device to work.

Quoted 14 lines

Review

Quoted 10 lines
(quoted diff) +6 -0
+config CS89x0_SWAPPED
+    bool "Hardware swapped CS89x0"
+    depends on CS89x0 && !NET_PCI && !ISA
+    ---help---
+      Say Y if your CS89x0 data bus is swapped.
+      This option is for single board computers using a CS89x0 chip. 

If you

(quoted diff) +2 -0
+      are using a regular Ethernet card, say N.
+

This would then depend on your directly attached config and you could have both it and pci configured.

Quoted 10 lines

Review

Quoted 6 lines

ifdef CONFIG_CC_OPTIMIZE_FOR_SIZE

(quoted diff) +1 -1
-CFLAGS        += -Os
+CFLAGS        += -O
 else
 CFLAGS        += -O2
 endif

Sees this undoes part of the benefit, perhaps you should add a third option.

This is a bug workaround for some versions of gcc (arm targeted) that produced huge stack consumption on some codes. I recall some crypto functions where the problem. I could dig around and find out more about the extac versions, etc, if interrested...

This one crept in here, and doesn't belong here at all.

Thanks
Greg

------------------------------------------------------------------------

Greg Ungerer  --  Chief Software Dude       EMAIL:     [email protected]
SnapGear -- a CyberGuard Company            PHONE:       +61 7 3435 2888
825 Stanley St,                             FAX:         +61 7 3891 3630
Woolloongabba, QLD, 4102, Australia         WEB: http://www.SnapGear.com