Skip to contentSkip to conversation

Framebuffer mode required for PowerBook Titanium

PATCH In review Michael Hanselmann 3 participants 7 messages Nov 5, 2005 – Nov 6, 2005 Framebuffer layer

lore
Share & tools
lore

Michael Hanselmann

author
#0 lore raw

PATCH 1/1 Framebuffer mode required for PowerBook Titanium

This patch adds the framebuffer mode required for an Apple PowerBook G4 Titanium.

Signed-off-by Michael Hanselmann <[email protected]>

---

drivers/video/modedb.c renamed from drivers/video/modedb.c.orig +4 -0
@@ -251,6 +251,10 @@ static const struct fb_videomode modedb[
 	NULL, 60, 1920, 1200, 5177, 128, 336, 1, 38, 208, 3,
 	FB_SYNC_HOR_HIGH_ACT | FB_SYNC_VERT_HIGH_ACT,
 	FB_VMODE_NONINTERLACED
+    }, {
+	/* 1152x768, 60 Hz, PowerBook G4 Titanium I and II */
+	"mac21", 60, 1152, 768, 15386, 158, 26, 29, 3, 136, 6,
+	FB_SYNC_HOR_HIGH_ACT|FB_SYNC_VERT_HIGH_ACT, FB_VMODE_NONINTERLACED
     },
 };
#1 lore raw
Quoted 3 lines · Michael Hanselmann

This patch adds the framebuffer mode required for an Apple PowerBook G4 Titanium.

Does booting with video=xxxfb:1152x768M@60 work? If it does, I would prefer that we avoid adding more entries to the global mode database.

Tony

author
#2 lore raw
Quoted 2 lines

Does booting with video=xxxfb:1152x768M@60 work? If it does, I would prefer that we avoid adding more entries to the global mode database.

It boots but the picture is stretched over the display. That's what I first tried, too, but only adding the mode definition fixed it.

Greets,
Michael

#3 lore raw
Quoted 5 lines · Michael Hanselmann
Quoted 2 lines

Does booting with video=xxxfb:1152x768M@60 work? If it does, I would prefer that we avoid adding more entries to the global mode database.

It boots but the picture is stretched over the display. That's what I first tried, too, but only adding the mode definition fixed it.

Okay.

Tony

#4 lore raw
In reply to Michael Hanselmann
Quoted 9 lines · Michael Hanselmann

This patch adds the framebuffer mode required for an Apple PowerBook G4 Titanium.

Signed-off-by Michael Hanselmann <[email protected]>

---

drivers/video/modedb.c static const struct fb_videomode modedb[ · line 259

Quoted 9 lines
drivers/video/modedb.c renamed from drivers/video/modedb.c.orig +4 -0
@@ -251,6 +251,10 @@ static const struct fb_videomode modedb[
 	NULL, 60, 1920, 1200, 5177, 128, 336, 1, 38, 208, 3,
 	FB_SYNC_HOR_HIGH_ACT | FB_SYNC_VERT_HIGH_ACT,
 	FB_VMODE_NONINTERLACED
+    }, {
+	/* 1152x768, 60 Hz, PowerBook G4 Titanium I and II */
+	"mac21", 60, 1152, 768, 15386, 158, 26, 29, 3, 136, 6,
+	FB_SYNC_HOR_HIGH_ACT|FB_SYNC_VERT_HIGH_ACT, FB_VMODE_NONINTERLACED
     },
 };

Please, re-do it without the "mac21" name, just leave NULL there.

Ben.

author
#5 lore raw

This patch adds the framebuffer mode required for an Apple PowerBook G4 Titanium.

---

Redone with NULL instead of "mac21".

drivers/video/modedb.c renamed from drivers/video/modedb.c.orig +4 -0
@@ -251,6 +251,10 @@
 	NULL, 60, 1920, 1200, 5177, 128, 336, 1, 38, 208, 3,
 	FB_SYNC_HOR_HIGH_ACT | FB_SYNC_VERT_HIGH_ACT,
 	FB_VMODE_NONINTERLACED
+    }, {
+	/* 1152x768, 60 Hz, PowerBook G4 Titanium I and II */
+	NULL, 60, 1152, 768, 15386, 158, 26, 29, 3, 136, 6,
+	FB_SYNC_HOR_HIGH_ACT|FB_SYNC_VERT_HIGH_ACT, FB_VMODE_NONINTERLACED
     },
 };