Skip to contentSkip to conversation

drivers/md/kcopyd.c: remove kcopyd_cancel()

PATCH In review Adrian Bunk 2 participants 3 messages Nov 8, 2005 Device mapper

lore
Share & tools
lore

Adrian Bunk

author
#0 lore raw

PATCH 1/1 drivers/md/kcopyd.c: remove kcopyd_cancel()

A function that is
- not used
- empty
- without a prototype in any header file
should be removed.

Signed-off-by Adrian Bunk <[email protected]>

---

This patch was already sent on:
- 5 Nov 2005

 drivers/md/kcopyd.c |   11 -----------
 1 file changed, 11 deletions(-)
drivers/md/kcopyd.c renamed from drivers/md/kcopyd.c.old +0 -11
@@ -558,16 +558,6 @@
 	return 0;
 }
 
-/*
- * Cancels a kcopyd job, eg. someone might be deactivating a
- * mirror.
- */
-int kcopyd_cancel(struct kcopyd_job *job, int block)
-{
-	/* FIXME: finish */
-	return -1;
-}
-
 /*-----------------------------------------------------------------
  * Unit setup
  *---------------------------------------------------------------*/

@@ -685,4 +675,3 @@
 EXPORT_SYMBOL(kcopyd_client_create);
 EXPORT_SYMBOL(kcopyd_client_destroy);
 EXPORT_SYMBOL(kcopyd_copy);
-EXPORT_SYMBOL(kcopyd_cancel);
maintainer
#1 lore raw
Quoted 5 lines · Adrian Bunk

A function that is
- not used
- empty
- without a prototype in any header file
should be removed.

I'd rather you submitted a patch to complete the function and invoke it in the appropriate place:-) But please don't remove comments indicating missing functionality: commenting it out till it's written would be better.

Alasdair

Signature · 1 line
[email protected]
Quoted 9 lines
drivers/md/kcopyd.c renamed from drivers/md/kcopyd.c.old +0 -9
-/*
- * Cancels a kcopyd job, eg. someone might be deactivating a
- * mirror.
- */
-int kcopyd_cancel(struct kcopyd_job *job, int block)
-{
-	/* FIXME: finish */
-	return -1;
-}
author
#2 lore raw

PATCH 1/1 drivers/md/kcopyd.c: #if 0 kcopyd_cancel()

Quoted 10 lines · Alasdair G Kergon
Quoted 5 lines · Adrian Bunk

A function that is
- not used
- empty
- without a prototype in any header file
should be removed.

I'd rather you submitted a patch to complete the function and invoke it in the appropriate place:-) But please don't remove comments indicating missing functionality: commenting it out till it's written would be better.

Updated patch below.

Quoted 1 line

Alasdair

cu
Adrian

<-- snip -->

This patch #if 0's the not yet implemented global function kcopyd_cancel().

Signed-off-by Adrian Bunk <[email protected]>

---

 drivers/md/kcopyd.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/md/kcopyd.c renamed from drivers/md/kcopyd.c.old +2 -1
@@ -562,11 +562,13 @@
  * Cancels a kcopyd job, eg. someone might be deactivating a
  * mirror.
  */
+#if 0
 int kcopyd_cancel(struct kcopyd_job *job, int block)
 {
 	/* FIXME: finish */
 	return -1;
 }
+#endif  /*  0  */
 
 /*-----------------------------------------------------------------
  * Unit setup

@@ -685,4 +687,3 @@
 EXPORT_SYMBOL(kcopyd_client_create);
 EXPORT_SYMBOL(kcopyd_client_destroy);
 EXPORT_SYMBOL(kcopyd_copy);
-EXPORT_SYMBOL(kcopyd_cancel);