Skip to contentSkip to conversation

i386: fix bound check IDT gate

PATCH In review Jan Beulich 2 participants 2 messages Nov 8, 2005

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 i386: fix bound check IDT gate

Other than apparently commonly assumed, the bound instruction does not require the corresponding IDT entry to have DPL 3.

From: Jan Beulich <[email protected]>

(actual patch attached)

Other than apparently commonly assumed, the bound instruction does not require the corresponding IDT entry to have DPL 3.

From: Jan Beulich <[email protected]>

arch/i386/kernel/traps.c +2 -2
@@ -1081,9 +1081,9 @@ void __init trap_init(void)
 	set_trap_gate(0,&divide_error);
 	set_intr_gate(1,&debug);
 	set_intr_gate(2,&nmi);
-	set_system_intr_gate(3, &int3); /* int3-5 can be called from all */
+	set_system_intr_gate(3, &int3); /* int3/4 can be called from all */
 	set_system_gate(4,&overflow);
-	set_system_gate(5,&bounds);
+	set_trap_gate(5,&bounds);
 	set_trap_gate(6,&invalid_op);
 	set_trap_gate(7,&device_not_available);
 	set_task_gate(8,GDT_ENTRY_DOUBLEFAULT_TSS);
#1 lore raw
Quoted 4 lines · Jan Beulich

Other than apparently commonly assumed, the bound instruction does not require the corresponding IDT entry to have DPL 3.

From: Jan Beulich <[email protected]>

Shouldn't this be "Signed-off-by:" instead?

Quoted 1 line

(actual patch attached)

Can you put it in-line?

thanks,

greg k-h