remove USB_AUDIO and USB_MIDI drivers
PATCH 1/1 remove USB_AUDIO and USB_MIDI drivers
Since I've gotten exactly zero negative feedback, this patch removes the obsolete USB_AUDIO and USB_MIDI drivers.
It also makes the global function usb_get_string() static since this function no longer has any external user.
---
drivers/usb/Makefile | 2 drivers/usb/class/Kconfig | 47 drivers/usb/class/Makefile | 2 drivers/usb/class/audio.c | 3870 ----------------------------------- drivers/usb/class/audio.h | 110 drivers/usb/class/usb-midi.c | 2154 ------------------- drivers/usb/class/usb-midi.h | 164 - drivers/usb/core/message.c | 5 include/linux/usb.h | 2 9 files changed, 2 insertions(+), 6354 deletions(-)
Due to it's size, the patch is attached gzip'ed.
Quoted 22 lines · Adrian Bunk
Since I've gotten exactly zero negative feedback, this patch removes the obsolete
USB_AUDIOandUSB_MIDIdrivers.It also makes the global function
usb_get_string()static since this function no longer has any external user.Signed-off-by Adrian Bunk <[email protected]>---
drivers/usb/Makefile | 2 drivers/usb/class/Kconfig | 47 drivers/usb/class/Makefile | 2 drivers/usb/class/audio.c | 3870 ----------------------------------- drivers/usb/class/audio.h | 110 drivers/usb/class/usb-midi.c | 2154 ------------------- drivers/usb/class/usb-midi.h | 164 - drivers/usb/core/message.c | 5 include/linux/usb.h | 2 9 files changed, 2 insertions(+), 6354 deletions(-)
Quoted 1 line
Due to it's size, the patch is attached gzip'ed.
Ugh, care to send it not gziped? I can handle large patches...
And please split the get_string one out into a separate patch.
thanks,
greg k-h
Quoted 23 lines · Greg KH
Quoted 22 lines · Adrian Bunk
Since I've gotten exactly zero negative feedback, this patch removes the obsolete
USB_AUDIOandUSB_MIDIdrivers.It also makes the global function
usb_get_string()static since this function no longer has any external user.Signed-off-by Adrian Bunk <[email protected]>---
drivers/usb/Makefile | 2 drivers/usb/class/Kconfig | 47 drivers/usb/class/Makefile | 2 drivers/usb/class/audio.c | 3870 ----------------------------------- drivers/usb/class/audio.h | 110 drivers/usb/class/usb-midi.c | 2154 ------------------- drivers/usb/class/usb-midi.h | 164 - drivers/usb/core/message.c | 5 include/linux/usb.h | 2 9 files changed, 2 insertions(+), 6354 deletions(-)
Quoted 3 lines
Quoted 1 line
Due to it's size, the patch is attached gzip'ed.
Ugh, care to send it not gziped? I can handle large patches...
Sure, I'll send it with the Cc' to linux-kernel removed.
Quoted 1 line
And please split the
get_stringone out into a separate patch.
OK.
Quoted 3 lines
thanks,
greg k-h
cu
Adrian
Signature · 4 lines
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon SeedPATCH 1/1 drivers/usb/core/message.c: make usb_get_string() static
In reply to Greg KHAfter the removal of usb-midi.c, there's no longer any external user of usb_get_string().
---
drivers/usb/core/message.c | 5 ++--- include/linux/usb.h | 2 -- 2 files changed, 2 insertions(+), 5 deletions(-)
include/linux/usb.h renamed from include/linux/usb.h.old +0 -2
@@ -1004,8 +1004,6 @@ unsigned char descindex, void *buf, int size);extern int usb_get_status (struct usb_device *dev,int type,int target,void *data); -extern int usb_get_string (struct usb_device *dev, -unsigned short langid,unsigned char index,void *buf,int size);extern int usb_string (struct usb_device *dev,int index,char *buf,size_t size);
drivers/usb/core/message.c renamed from drivers/usb/core/message.c.old +2 -3
@@ -637,8 +637,8 @@* Returns the number of bytes received on success, or else the status code * returned by the underlying usb_control_msg() call. */ -int usb_get_string (struct usb_device *dev,unsigned short langid, -unsigned char index,void *buf,int size) +static int usb_get_string (struct usb_device *dev,unsigned short langid, +unsigned char index,void *buf,int size) {int i;int result;
@@ -1488,7 +1488,6 @@// synchronous control message convenience routines EXPORT_SYMBOL (usb_get_descriptor);EXPORT_SYMBOL (usb_get_status); -EXPORT_SYMBOL (usb_get_string);EXPORT_SYMBOL (usb_string);// synchronous calls that also maintain usbcore state