Skip to contentSkip to conversation

i386: always use 4k stacks

PATCH Wed, 16 Nov 2005 00:41:11 +0100 6 participants 6 messages Nov 15, 2005 – Nov 16, 2005

lore
Share & tools
lore
#1 lore raw
Quoted 9 lines · On Nov 15, 2005, at 6:41 PM, Wed, 16 Nov 2005 00:41:11 +0100 wrote:
Quoted 5 lines

documentation for broadcom wireless:
http://bcm-specs.sipsolutions.net/
embrionic driver based on this spec:
http://bcm43xx.berlios.de/

Maybe a good deal would be to delay the 4K patch until some preliminary version of those is merged?

Andi had some pretty valid comments against the 4K approach. Here - http://lkml.org/lkml/2005/9/6/4
I didn't see anyone contradicting his opinion. Seems very plausible to me.

Parag

#2 lore raw
Quoted 9 lines · Parag Warudkar
Quoted 7 lines · On Nov 15, 2005, at 6:41 PM, Wed, 16 Nov 2005 00:41:11 +0100 wrote:
Quoted 5 lines

documentation for broadcom wireless:
http://bcm-specs.sipsolutions.net/
embrionic driver based on this spec:
http://bcm43xx.berlios.de/

Quoted 8 lines
Quoted 3 lines

Maybe a good deal would be to delay the 4K patch until some preliminary
version of those is merged?

Andi had some pretty valid comments against the 4K approach. Here - http://lkml.org/lkml/2005/9/6/4
I didn't see anyone contradicting his opinion. Seems very plausible to me.

the only argument I see is "we had overflows in 2.4 with 8k". In fact that is part of why 4K stacks was done! With 4k/4k stacks there is MORE stack space than in 2.4. Most of the overflows I've seen in 2.4 were nested interrupts with complex softirqs; with the 4k/4k stack approach interrupts have MORE stack space available than in 2.4, making overflows less likely. In addition the 2.6 kernel has undergone a "stack diet", the final piece of which is the IO submission change that is now in -mm.

#3 lore raw
In reply to Wed, 16 Nov 2005 00:41:11 +0100

On Wed, 2005-11-16 at 00:41 +0100, Wed, 16 Nov 2005 00:41:11 +0100

                                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
                                   Interesting Name.
Quoted 8 lines · wrote:
Quoted 4 lines

documentation for broadcom wireless:
http://bcm-specs.sipsolutions.net/
embrionic driver based on this spec:
http://bcm43xx.berlios.de/

Maybe a good deal would be to delay the 4K patch until some preliminary version of those is merged?

Set the default value to "4k" and - to streß it further - remove the questions on make *config so that sufficiently interesting people must edit by hand after searching for it.
This will give the correct impression for everyone where it will go, possibly raises the awareness of this area (WLAN drivers) and it doesn't break ATM anything seriously.

Bernd

Signature · 3 lines
Firmix Software GmbH                   http://www.firmix.at/
mobil: +43 664 4416156                 fax: +43 1 7890849-55
          Embedded Linux Development and Services
#4 lore raw
Quoted 10 lines · Bernd Petrovitsch

On Wed, 2005-11-16 at 00:41 +0100, Wed, 16 Nov 2005 00:41:11 +0100

                                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
                                   Interesting Name.
Quoted 6 lines · wrote:
Quoted 4 lines

documentation for broadcom wireless:
http://bcm-specs.sipsolutions.net/
embrionic driver based on this spec:
http://bcm43xx.berlios.de/

Quoted 6 lines
Quoted 2 lines

Maybe a good deal would be to delay the 4K patch until some preliminary version of those is merged?

Set the default value to "4k" and - to streß it further - remove the questions on make *config so that sufficiently interesting people must edit by hand after searching for it.

If you are sufficiently interested, reverting my patch would be more simple than manually hacking a Kconfig file.

Quoted 5 lines

This will give the correct impression for everyone where it will go, possibly raises the awareness of this area (WLAN drivers) and it doesn't break ATM anything seriously.

Bernd

cu
Adrian

Signature · 4 lines
       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed
#5 lore raw
In reply to Bernd Petrovitsch
Quoted 3 lines · Bernd Petrovitsch

Set the default value to "4k" and - to streß it further - remove the questions on make *config so that sufficiently interesting people must edit by hand after searching for it.

Haven't Red Hat tested that long enough?

Signature · 1 line
Krzysztof Halasa