Skip to contentSkip to conversation

remove drivers/net/tulip/xircom_tulip_cb.c

RFC PATCH In review Adrian Bunk 2 participants 3 messages Nov 18, 2005 – Nov 19, 2005

Subsystems (2)
Networking Network drivers
lore
Share & tools
lore

Adrian Bunk

author
#0 lore raw

RFC PATCH 1/1 remove drivers/net/tulip/xircom_tulip_cb.c

This patch removes the obsolete drivers/net/tulip/xircom_tulip_cb.c driver.

Is there any reason why it should be kept?

Signed-off-by Adrian Bunk <[email protected]>

---

 drivers/net/tulip/Kconfig           |   16 
 drivers/net/tulip/Makefile          |    1 
 drivers/net/tulip/xircom_tulip_cb.c | 1748 ----------------------------
 3 files changed, 1 insertion(+), 1764 deletions(-)
drivers/net/tulip/Kconfig renamed from drivers/net/tulip/Kconfig.old +1 -15
@@ -148,7 +148,7 @@
 	  be called uli526x.
 	  
 config PCMCIA_XIRCOM
-	tristate "Xircom CardBus support (new driver)"
+	tristate "Xircom CardBus support"
 	depends on NET_TULIP && CARDBUS
 	---help---
 	  This driver is for the Digital "Tulip" Ethernet CardBus adapters.

@@ -160,19 +160,5 @@
 	  <file:Documentation/networking/net-modules.txt>.  The module will
 	  be called xircom_cb.  If unsure, say N.
 
-config PCMCIA_XIRTULIP
-	tristate "Xircom Tulip-like CardBus support (old driver)"
-	depends on NET_TULIP && CARDBUS && BROKEN_ON_SMP
-	select CRC32
-	---help---
-	  This driver is for the Digital "Tulip" Ethernet CardBus adapters.
-	  It should work with most DEC 21*4*-based chips/ethercards, as well
-	  as with work-alike chips from Lite-On (PNIC) and Macronix (MXIC) and
-	  ASIX.
-
-	  To compile this driver as a module, choose M here and read
-	  <file:Documentation/networking/net-modules.txt>.  The module will
-	  be called xircom_tulip_cb.  If unsure, say N.
-
 endmenu
drivers/net/tulip/Makefile renamed from drivers/net/tulip/Makefile.old +0 -1
@@ -2,7 +2,6 @@
 # Makefile for the Linux "Tulip" family network device drivers.
 #
 
-obj-$(CONFIG_PCMCIA_XIRTULIP)	+= xircom_tulip_cb.o
 obj-$(CONFIG_PCMCIA_XIRCOM)	+= xircom_cb.o
 obj-$(CONFIG_DM9102)		+= dmfe.o
 obj-$(CONFIG_WINBOND_840)	+= winbond-840.o
drivers/net/tulip/xircom_tulip_cb.c deleted +0 -1748

1,748 lines not on this page · raw message

#1 lore raw
Quoted 3 lines · Adrian Bunk

This patch removes the obsolete drivers/net/tulip/xircom_tulip_cb.c driver.

Is there any reason why it should be kept?

Yes. It is the only driver that works
without lockups on Xircom Cardbus cards.
Or so has been the case any time I've tried
the alternatives.

Is there any good reason to nuke it?

author
#2 lore raw
Quoted 4 lines · Mark Lord
Quoted 3 lines · Adrian Bunk

This patch removes the obsolete drivers/net/tulip/xircom_tulip_cb.c driver.

Quoted 8 lines
Quoted 1 line

Is there any reason why it should be kept?

Yes. It is the only driver that works
without lockups on Xircom Cardbus cards.
Or so has been the case any time I've tried
the alternatives.

Is there any good reason to nuke it?

- there's a more recent driver for the same hardware
- the driver uses the deprecated virt_to_bus/bus_to_virt we want to get rid of

Can you give me a pointer to your bug report containing more details regarding the problems you had with the xircom_cb driver?

cu
Adrian

Signature · 4 lines
       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed