drivers/scsi/dpt_i2o.c: fix a NULL pointer dereference
PATCH 1/1 drivers/scsi/dpt_i2o.c: fix a NULL pointer dereference
The Coverity checker spotted this obvious NULL pointer dereference.
Signed-off-by Adrian Bunk <[email protected]>
---
drivers/scsi/dpt_i2o.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-)
drivers/scsi/dpt_i2o.c renamed from drivers/scsi/dpt_i2o.c.old +5 -4
@@ -816,7 +816,7 @@static void adpt_i2o_sys_shutdown (void ) {adpt_hba *pHba, *pNext; -struct adpt_i2o_post_wait_data *p1, *p2; +struct adpt_i2o_post_wait_data *p1, *old;printk (KERN_INFO "Shutting down Adaptec I2O controllers.\n" );printk (KERN_INFO " This could take a few minutes if there are many devices attached\n" );
@@ -830,13 +830,14 @@ }/* Remove any timedout entries from the wait queue. */ - p2 =NULL ;// spin_lock_irqsave(&adpt_post_wait_lock, flags); /* Nothing should be outstanding at this point so just * free them */ -for (p1 = adpt_post_wait_queue; p1; p2 = p1, p1 = p2->next) { -kfree (p1); +for (p1 = adpt_post_wait_queue; p1;) { + old = p1; + p1 = p1->next; +kfree (old); }// spin_unlock_irqrestore(&adpt_post_wait_lock, flags); adpt_post_wait_queue =NULL ;
Re: [stable] [2.6 patch] drivers/infiniband/core/mad.c: fix a NULL pointer dereference
Please send these again to the stable@ address when they have been accepted into upstream.
thanks,
greg k-h
PATCH 1/1 drivers/message/i2o/pci.c: fix a NULL pointer dereference
The Coverity checker spotted this obvious NULL pointer dereference.
Signed-off-by Adrian Bunk <[email protected]>
drivers/message/i2o/pci.c renamed from drivers/message/i2o/pci.c.old +1 -1
@@ -421,8 +421,8 @@i2o_pci_free (c); free_controller: -i2o_iop_free (c);put_device (c->device.parent); +i2o_iop_free (c); disable:pci_disable_device (pdev);
PATCH 1/1 drivers/infiniband/core/mad.c: fix a NULL pointer dereference
The Coverity checker spotted this obvious NULL pointer dereference caused by a wrong order of the cleanups.
Signed-off-by Adrian Bunk <[email protected]>
drivers/infiniband/core/mad.c renamed from drivers/infiniband/core/mad.c.old +2 -2
@@ -355,9 +355,9 @@spin_unlock_irqrestore (&port_priv->reg_lock, flags);kfree (reg_req); error3: -kfree (mad_agent_priv); -error2:ib_dereg_mr (mad_agent_priv->agent.mr); +error2: +kfree (mad_agent_priv); error1:return ret; }